You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[Doc Gap] applicationinsights_recommendation_list — global options table incorrectly claims --auth-method applies to all commands after PR
[Content truncated due to length] #2899
PR #2874 migrated RecommendationListCommand from the old tool design (SubscriptionCommand<RecommendationListOptions> with GlobalOptions base) to the new two-type-parameter design (SubscriptionCommand<RecommendationListOptions, RecommendationListCommandResult>). RecommendationListOptions was changed from extending SubscriptionOptions (which inherits GlobalOptions → includes --auth-method) to implementing ISubscriptionOption directly with only explicit [Option] attributes.
This is a breaking change documented in the changelog entry added by the PR:
The new RecommendationListOptions explicitly declares only: Tenant, Subscription, ResourceGroup, RetryPolicy.
The current global options section in azmcp-commands.md (unchanged by PR #2874):
## Global Options
The following options are available for all commands:
| Option | Required | Default | Description ||-----------|----------|---------|-------------||`--subscription`| No | Environment variable `AZURE_SUBSCRIPTION_ID`| Azure subscription ID for target resources ||`--tenant-id`| No | - | Azure tenant ID for authentication ||`--auth-method`| No | 'credential' | Authentication method ('credential', 'key', 'connectionString') |
...
📐 Implementation Guide
This section contains step-by-step instructions for a coding agent to implement the changes described above.
Locate the Global Options section. If a "Note" or exception list already exists (from the fix for issues #2827 and/or #2845), extend it to include applicationinsights recommendation list:
Note: The following commands do not support --auth-method (and other global options where noted):
cloudarchitect design — does not support --subscription, --tenant-id, --auth-method, or any --retry-* options
acr registry list and acr registry repository list — do not support --auth-method
applicationinsights recommendation list — does not support --auth-method
If no such note exists yet (issues #2827 and #2845 are unresolved), create it after the Global Options table with all three exceptions included.
The Global Options section note (or a new note) lists applicationinsights recommendation list as an exception to --auth-method
The Application Insights section command signatures remain accurate (they already correctly show --subscription and optional --resource-group)
Step 3: Validate
Run these commands in order. Each must succeed before proceeding to the next:
dotnet build servers/Azure.Mcp.Server/ — confirms the server project compiles cleanly
dotnet build tools/Azure.Mcp.Tools.ApplicationInsights/src/ — confirms the Application Insights toolset compiles
dotnet test tools/Azure.Mcp.Tools.ApplicationInsights/tests/Azure.Mcp.Tools.ApplicationInsights.Tests/ --filter "TestType!=Live" — runs unit tests for the affected toolset
.\eng\common\spelling\Invoke-Cspell.ps1 — checks spelling in new or modified documentation
Next Steps
Tip
Ready for automated implementation? Assign this issue to @copilot to have Copilot coding agent implement the changes described in the Implementation Guide above
Documentation Gap
Server:
Azure.Mcp.ServerTool directory:
tools/Azure.Mcp.Tools.ApplicationInsightsTriggered by: commit 35bff42 / PR #2874 by
@alzimmermsftChanged files:
tools/Azure.Mcp.Tools.ApplicationInsights/src/Commands/Recommendation/RecommendationListCommand.cstools/Azure.Mcp.Tools.ApplicationInsights/src/Options/RecommendationListOptions.csWhat Changed
PR #2874 migrated
RecommendationListCommandfrom the old tool design (SubscriptionCommand<RecommendationListOptions>withGlobalOptionsbase) to the new two-type-parameter design (SubscriptionCommand<RecommendationListOptions, RecommendationListCommandResult>).RecommendationListOptionswas changed from extendingSubscriptionOptions(which inheritsGlobalOptions→ includes--auth-method) to implementingISubscriptionOptiondirectly with only explicit[Option]attributes.This is a breaking change documented in the changelog entry added by the PR:
The removed option is
--auth-method(and theAuthMethodproperty formerly inherited viaGlobalOptions).Gaps Found
azmcp-commands.mdGlobal Options table states "The following options are available for all commands" and lists--auth-method. However,applicationinsights recommendation listis now an exception that does not accept--auth-method. The global options section needs to be updated to listapplicationinsights recommendation listas an exception, consistent with the same fix needed forcloudarchitect design(tracked in [Doc Gap] cloudarchitect_design tool — docs show removed global options and wrong--stateparameter #2827) andacr registry list/acr registry repository list(tracked in [Doc Gap] acr_registry_list and acr_registry_repository_list — global options table incorrectly claims --auth-method applies to all comman [Content truncated due to length] #2845).Files to Update
servers/Azure.Mcp.Server/docs/azmcp-commands.mdContext
Before the migration, the option inheritance chain was:
After the migration:
The new
RecommendationListOptionsexplicitly declares only:Tenant,Subscription,ResourceGroup,RetryPolicy.The current global options section in
azmcp-commands.md(unchanged by PR #2874):📐 Implementation Guide
This section contains step-by-step instructions for a coding agent to implement the changes described above.
Step 1: Modify files
File:
servers/Azure.Mcp.Server/docs/azmcp-commands.mdLocate the Global Options section. If a "Note" or exception list already exists (from the fix for issues #2827 and/or #2845), extend it to include
applicationinsights recommendation list:If no such note exists yet (issues #2827 and #2845 are unresolved), create it after the Global Options table with all three exceptions included.
Step 2: Verify documentation structure
servers/Azure.Mcp.Server/docs/azmcp-commands.md— confirm:applicationinsights recommendation listas an exception to--auth-method--subscriptionand optional--resource-group)Step 3: Validate
Run these commands in order. Each must succeed before proceeding to the next:
dotnet build servers/Azure.Mcp.Server/— confirms the server project compiles cleanlydotnet build tools/Azure.Mcp.Tools.ApplicationInsights/src/— confirms the Application Insights toolset compilesdotnet test tools/Azure.Mcp.Tools.ApplicationInsights/tests/Azure.Mcp.Tools.ApplicationInsights.Tests/ --filter "TestType!=Live"— runs unit tests for the affected toolset.\eng\common\spelling\Invoke-Cspell.ps1— checks spelling in new or modified documentationNext Steps
Tip
Ready for automated implementation? Assign this issue to
@copilotto have Copilot coding agent implement the changes described in the Implementation Guide above