From 2498be18c9ab221d3c515dbd259fc50a71e1f0b6 Mon Sep 17 00:00:00 2001 From: Varun Nuthalapati Date: Tue, 28 Apr 2026 19:38:33 -0700 Subject: [PATCH] fix: include available device IDs in device lookup error messages When a caller passes an unknown device ID to assign_task_to_device, connect_device, or get_device_status, the previous error messages ("Device X is not registered") gave no hint of what valid IDs exist. Include the full list of registered device IDs in every not-found error so callers can immediately see the valid options without additional debugging. --- galaxy/client/device_manager.py | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/galaxy/client/device_manager.py b/galaxy/client/device_manager.py index 81f6532f..3a1b4dd6 100644 --- a/galaxy/client/device_manager.py +++ b/galaxy/client/device_manager.py @@ -229,7 +229,11 @@ async def connect_device( :return: True if connection successful """ if not self.device_registry.is_device_registered(device_id): - self.logger.error(f"❌ Device {device_id} not registered") + available_ids = list(self.device_registry.get_all_devices().keys()) + self.logger.error( + f"❌ Device '{device_id}' not registered. " + f"Available device IDs: {available_ids}" + ) return False device_info = self.device_registry.get_device(device_id) @@ -562,7 +566,11 @@ async def assign_task_to_device( # Check if device is registered and connected device_info = self.device_registry.get_device(device_id) if not device_info: - raise ValueError(f"Device {device_id} is not registered") + available_ids = list(self.device_registry.get_all_devices().keys()) + raise ValueError( + f"Device '{device_id}' is not registered. " + f"Available device IDs: {available_ids}" + ) if device_info.status not in [ DeviceStatus.CONNECTED, @@ -782,7 +790,11 @@ def get_device_status(self, device_id: str) -> Dict[str, Any]: """Get device status information""" device_info = self.device_registry.get_device(device_id) if not device_info: - return {"error": f"Device {device_id} not found"} + available_ids = list(self.device_registry.get_all_devices().keys()) + return { + "error": f"Device '{device_id}' not found", + "available_device_ids": available_ids, + } return { "device_id": device_info.device_id,