From 64dd8251056af2b5dd577d7a97b5a1157aa300e7 Mon Sep 17 00:00:00 2001 From: Varun Nuthalapati Date: Sat, 25 Apr 2026 11:56:52 -0700 Subject: [PATCH] fix: replace bare except clauses in WinCOMReceiverBasic Bare except clauses catch all exceptions including SystemExit and KeyboardInterrupt, which can mask unexpected errors and make debugging harder. Replace with except Exception to only catch non-system exceptions in full_path, save, save_to_xml, and close methods. --- ufo/automator/app_apis/basic.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ufo/automator/app_apis/basic.py b/ufo/automator/app_apis/basic.py index f9fc1e00d..3da098405 100644 --- a/ufo/automator/app_apis/basic.py +++ b/ufo/automator/app_apis/basic.py @@ -97,7 +97,7 @@ def full_path(self) -> str: try: full_path = self.com_object.FullName return full_path - except: + except Exception: return "" def save(self) -> None: @@ -106,7 +106,7 @@ def save(self) -> None: """ try: self.com_object.Save() - except: + except Exception: pass def save_to_xml(self, file_path: str) -> None: @@ -116,7 +116,7 @@ def save_to_xml(self, file_path: str) -> None: """ try: self.com_object.SaveAs(file_path, self.xml_format_code) - except: + except Exception: pass def close(self) -> None: @@ -125,7 +125,7 @@ def close(self) -> None: """ try: self.com_object.Close() - except: + except Exception: pass @property