From 502f301fcec962286f347d8d90ef2cd979e968fc Mon Sep 17 00:00:00 2001 From: Eddy Lynch Date: Thu, 22 Jan 2026 13:16:57 +0000 Subject: [PATCH 1/3] Change order of ContextProperties param in MicrosoftUserFeedback.Codeunit.al --- .../src/MicrosoftUserFeedback.Codeunit.al | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al b/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al index cc82ee0294..db5093a3cd 100644 --- a/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al +++ b/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al @@ -141,9 +141,9 @@ codeunit 1590 "Microsoft User Feedback" /// The name of the feature for which dislike feedback is requested. /// The area or sub-area of the feature. ID of the sub-area on OCV. /// The display name of the feature area. - /// Additional data to pass properties to the feedback mechanism. /// Map of filename to base64 file to attach to the feedback. Must contain the filename in the extension. - procedure RequestDislikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text; ContextProperties: Dictionary of [Text, Text]; ContextFiles: Dictionary of [Text, Text]) + /// Additional data to pass properties to the feedback mechanism. + procedure RequestDislikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text; ContextFiles: Dictionary of [Text, Text]; ContextProperties: Dictionary of [Text, Text]) var CallerModuleInfo: ModuleInfo; begin From 17e9bf3e1a004ca92c526371926b815bb2d865cd Mon Sep 17 00:00:00 2001 From: Eddy Lynch Date: Thu, 22 Jan 2026 13:37:07 +0000 Subject: [PATCH 2/3] Add on prem scope --- .../src/MicrosoftUserFeedback.Codeunit.al | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al b/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al index db5093a3cd..cc270f30f5 100644 --- a/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al +++ b/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al @@ -18,6 +18,7 @@ codeunit 1590 "Microsoft User Feedback" /// Requests general feedback for a feature, optionally specifying if it is a Copilot feature and its area. /// /// The name of the feature for which feedback is requested. + [Scope('OnPrem')] procedure RequestFeedback(FeatureName: Text) var CallerModuleInfo: ModuleInfo; @@ -34,6 +35,7 @@ codeunit 1590 "Microsoft User Feedback" /// The name of the feature for which feedback is requested. /// The area or sub-area of the feature. ID on OCV. /// The display name of the feature area. + [Scope('OnPrem')] procedure RequestFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text) var CallerModuleInfo: ModuleInfo; @@ -52,6 +54,7 @@ codeunit 1590 "Microsoft User Feedback" /// The display name of the feature area. /// Map of filename to base64 file to attach to the feedback. Must contain the filename in the extension. /// Additional data to pass properties to the feedback mechanism. + [Scope('OnPrem')] procedure RequestFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text; ContextFiles: Dictionary of [Text, Text]; ContextProperties: Dictionary of [Text, Text]) var CallerModuleInfo: ModuleInfo; @@ -64,6 +67,7 @@ codeunit 1590 "Microsoft User Feedback" /// Requests a 'like' (positive) feedback for a feature, optionally specifying if it is a Copilot feature and its area. /// /// The name of the feature for which like feedback is requested. + [Scope('OnPrem')] procedure RequestLikeFeedback(FeatureName: Text) var CallerModuleInfo: ModuleInfo; @@ -80,6 +84,7 @@ codeunit 1590 "Microsoft User Feedback" /// The name of the feature for which like feedback is requested. /// The area or sub-area of the feature. ID on OCV. /// The display name of the feature area. + [Scope('OnPrem')] procedure RequestLikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text) var CallerModuleInfo: ModuleInfo; @@ -97,6 +102,7 @@ codeunit 1590 "Microsoft User Feedback" /// The area or sub-area of the feature. /// Map of filename to base64 file to attach to the feedback. Must contain the filename in the extension. /// Additional data to pass properties to the feedback mechanism. + [Scope('OnPrem')] procedure RequestLikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text; ContextFiles: Dictionary of [Text, Text]; ContextProperties: Dictionary of [Text, Text]) var CallerModuleInfo: ModuleInfo; @@ -109,6 +115,7 @@ codeunit 1590 "Microsoft User Feedback" /// Requests a 'dislike' (negative) feedback for a feature, optionally specifying if it is a Copilot feature and its area. /// /// The name of the feature for which dislike feedback is requested. + [Scope('OnPrem')] procedure RequestDislikeFeedback(FeatureName: Text) var CallerModuleInfo: ModuleInfo; @@ -125,6 +132,7 @@ codeunit 1590 "Microsoft User Feedback" /// The name of the feature for which dislike feedback is requested. /// The area or sub-area of the feature. ID of the sub-area on OCV. /// The display name of the feature area. + [Scope('OnPrem')] procedure RequestDislikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text) var CallerModuleInfo: ModuleInfo; @@ -143,6 +151,7 @@ codeunit 1590 "Microsoft User Feedback" /// The display name of the feature area. /// Map of filename to base64 file to attach to the feedback. Must contain the filename in the extension. /// Additional data to pass properties to the feedback mechanism. + [Scope('OnPrem')] procedure RequestDislikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text; ContextFiles: Dictionary of [Text, Text]; ContextProperties: Dictionary of [Text, Text]) var CallerModuleInfo: ModuleInfo; @@ -156,6 +165,7 @@ codeunit 1590 "Microsoft User Feedback" /// /// True if the feedback is for an AI feature; otherwise, false. /// The current instance of the "Microsoft User Feedback Impl" codeunit. + [Scope('OnPrem')] procedure SetIsAIFeedback(IsAIFeedback: Boolean): Codeunit "Microsoft User Feedback" begin this.FeedbackImpl := this.FeedbackImpl.SetIsAIFeedback(IsAIFeedback); @@ -168,6 +178,7 @@ codeunit 1590 "Microsoft User Feedback" /// /// The name of the activity for which the timer is started or stopped. /// If true, starts the timer; if false, stops the timer. + [Scope('OnPrem')] procedure SurveyTimerActivity(ActivityName: Text; Start: Boolean) var CallerModuleInfo: ModuleInfo; @@ -181,6 +192,7 @@ codeunit 1590 "Microsoft User Feedback" /// The event could be, for example, a user clicking a button /// /// The name of the activity that triggers the survey. + [Scope('OnPrem')] procedure SurveyTriggerActivity(ActivityName: Text) var CallerModuleInfo: ModuleInfo; From 11f208b84b82c4fc19a568712263948d450bf8b4 Mon Sep 17 00:00:00 2001 From: Eddy Lynch Date: Thu, 22 Jan 2026 13:45:04 +0000 Subject: [PATCH 3/3] Add pragmas --- .../src/MicrosoftUserFeedback.Codeunit.al | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al b/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al index cc270f30f5..c1093de6b1 100644 --- a/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al +++ b/src/System Application/App/Microsoft User Feedback/src/MicrosoftUserFeedback.Codeunit.al @@ -18,6 +18,7 @@ codeunit 1590 "Microsoft User Feedback" /// Requests general feedback for a feature, optionally specifying if it is a Copilot feature and its area. /// /// The name of the feature for which feedback is requested. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestFeedback(FeatureName: Text) var @@ -28,6 +29,7 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestFeedback(FeatureName, '', '', EmptyContextFiles, EmptyContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Requests general feedback for a feature, optionally specifying if it is a Copilot feature and its area. @@ -35,6 +37,7 @@ codeunit 1590 "Microsoft User Feedback" /// The name of the feature for which feedback is requested. /// The area or sub-area of the feature. ID on OCV. /// The display name of the feature area. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text) var @@ -45,6 +48,7 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestFeedback(FeatureName, FeatureArea, FeatureAreaDisplayName, EmptyContextFiles, EmptyContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Requests general feedback for a feature, optionally specifying if it is a Copilot feature and its area. @@ -54,6 +58,7 @@ codeunit 1590 "Microsoft User Feedback" /// The display name of the feature area. /// Map of filename to base64 file to attach to the feedback. Must contain the filename in the extension. /// Additional data to pass properties to the feedback mechanism. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text; ContextFiles: Dictionary of [Text, Text]; ContextProperties: Dictionary of [Text, Text]) var @@ -62,11 +67,13 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestFeedback(FeatureName, FeatureArea, FeatureAreaDisplayName, ContextFiles, ContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Requests a 'like' (positive) feedback for a feature, optionally specifying if it is a Copilot feature and its area. /// /// The name of the feature for which like feedback is requested. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestLikeFeedback(FeatureName: Text) var @@ -77,6 +84,7 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestLikeFeedback(FeatureName, '', '', EmptyContextFiles, EmptyContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Requests a 'like' (positive) feedback for a feature, optionally specifying if it is a Copilot feature and its area. @@ -84,6 +92,7 @@ codeunit 1590 "Microsoft User Feedback" /// The name of the feature for which like feedback is requested. /// The area or sub-area of the feature. ID on OCV. /// The display name of the feature area. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestLikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text) var @@ -94,6 +103,7 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestLikeFeedback(FeatureName, FeatureArea, FeatureAreaDisplayName, EmptyContextFiles, EmptyContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Requests a 'like' (positive) feedback for a feature, optionally specifying if it is a Copilot feature and its area. @@ -102,6 +112,7 @@ codeunit 1590 "Microsoft User Feedback" /// The area or sub-area of the feature. /// Map of filename to base64 file to attach to the feedback. Must contain the filename in the extension. /// Additional data to pass properties to the feedback mechanism. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestLikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text; ContextFiles: Dictionary of [Text, Text]; ContextProperties: Dictionary of [Text, Text]) var @@ -110,11 +121,13 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestLikeFeedback(FeatureName, FeatureArea, FeatureAreaDisplayName, ContextFiles, ContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Requests a 'dislike' (negative) feedback for a feature, optionally specifying if it is a Copilot feature and its area. /// /// The name of the feature for which dislike feedback is requested. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestDislikeFeedback(FeatureName: Text) var @@ -125,6 +138,7 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestDislikeFeedback(FeatureName, '', '', EmptyContextFiles, EmptyContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Requests a 'dislike' (negative) feedback for a feature, optionally specifying if it is a Copilot feature and its area. @@ -132,6 +146,7 @@ codeunit 1590 "Microsoft User Feedback" /// The name of the feature for which dislike feedback is requested. /// The area or sub-area of the feature. ID of the sub-area on OCV. /// The display name of the feature area. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestDislikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text) var @@ -142,6 +157,7 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestDislikeFeedback(FeatureName, FeatureArea, FeatureAreaDisplayName, EmptyContextFiles, EmptyContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Requests a 'dislike' (negative) feedback for a feature, optionally specifying if it is a Copilot feature and its area. @@ -151,6 +167,7 @@ codeunit 1590 "Microsoft User Feedback" /// The display name of the feature area. /// Map of filename to base64 file to attach to the feedback. Must contain the filename in the extension. /// Additional data to pass properties to the feedback mechanism. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure RequestDislikeFeedback(FeatureName: Text; FeatureArea: Text; FeatureAreaDisplayName: Text; ContextFiles: Dictionary of [Text, Text]; ContextProperties: Dictionary of [Text, Text]) var @@ -159,18 +176,21 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.RequestDislikeFeedback(FeatureName, FeatureArea, FeatureAreaDisplayName, ContextFiles, ContextProperties, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Sets whether the General/Like/Dislike feedback being collected is for an AI feature. /// /// True if the feedback is for an AI feature; otherwise, false. /// The current instance of the "Microsoft User Feedback Impl" codeunit. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure SetIsAIFeedback(IsAIFeedback: Boolean): Codeunit "Microsoft User Feedback" begin this.FeedbackImpl := this.FeedbackImpl.SetIsAIFeedback(IsAIFeedback); exit(this); end; +#pragma warning restore AS0022 /// /// Starts or stops a survey timer activity. This is used to start a timer to count up user usage @@ -178,6 +198,7 @@ codeunit 1590 "Microsoft User Feedback" /// /// The name of the activity for which the timer is started or stopped. /// If true, starts the timer; if false, stops the timer. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure SurveyTimerActivity(ActivityName: Text; Start: Boolean) var @@ -186,12 +207,14 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.SurveyTimerActivity(ActivityName, Start, CallerModuleInfo); end; +#pragma warning restore AS0022 /// /// Sends a one-time trigger event based on a specific activity name. /// The event could be, for example, a user clicking a button /// /// The name of the activity that triggers the survey. +#pragma warning disable AS0022 [Scope('OnPrem')] procedure SurveyTriggerActivity(ActivityName: Text) var @@ -200,6 +223,7 @@ codeunit 1590 "Microsoft User Feedback" NavApp.GetCallerModuleInfo(CallerModuleInfo); this.FeedbackImpl.SurveyTriggerActivity(ActivityName, CallerModuleInfo); end; +#pragma warning restore AS0022 var FeedbackImpl: Codeunit "Microsoft User Feedback Impl";