fix: Address PR review feedback from Copilot

- Make default endpoint protocol-aware: 4317 for gRPC, 4318 for HTTP
- Add suppress_invoke_agent_input as explicit param on public configure()
- Fix insecure default from False to True in brainstorm docs (BRAINSTORM.md,
  TLDR.md, ARCHITECTURE.md) to match implementation
- Add tests for HTTP default endpoint and explicit endpoint override

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: juliomenendez

docs/brainstorm/spectra-collector-integration/ARCHITECTURE.md

@@ -51,7 +51,7 @@ configure(exporter_options=SpectraExporterOptions(...))
 │  │ SpectraExporterOpts │    │ Agent365ExporterOptions  │    │
 │  │ endpoint (4317)     │    │ token_resolver           │    │
 │  │ protocol (gRPC)     │    │ cluster_category         │    │
-│  │ insecure (false)    │    │ use_s2s_endpoint         │    │
+│  │ insecure (true)     │    │ use_s2s_endpoint         │    │
 │  │ batch settings      │    │ batch settings           │    │
 │  └────────┬────────────┘    └────────┬────────────────┘    │
 │           │                          │                      │
@@ -92,7 +92,7 @@ class SpectraExporterOptions:
         self,
         endpoint: str = "http://localhost:4317",
         protocol: str = "grpc",
-        insecure: bool = False,
+        insecure: bool = True,
         max_queue_size: int = 2048,
         scheduled_delay_ms: int = 5000,
         exporter_timeout_ms: int = 30000,
@@ -113,7 +113,7 @@ class SpectraExporterOptions:
 |-------|------|---------|-------------|
 | `endpoint` | `str` | `http://localhost:4317` | Spectra sidecar OTLP endpoint |
 | `protocol` | `str` | `grpc` | OTLP protocol: `"grpc"` or `"http"` |
-| `insecure` | `bool` | `False` | Whether to use insecure (no TLS) connection |
+| `insecure` | `bool` | `True` | Whether to use insecure (no TLS) connection |
 | `max_queue_size` | `int` | `2048` | Batch processor queue size |
 | `scheduled_delay_ms` | `int` | `5000` | Export interval (ms) |
 | `exporter_timeout_ms` | `int` | `30000` | Export timeout (ms) |
@@ -252,4 +252,4 @@ configure(
 | Sidecar not running → silent failure | Medium | OTLP exporter logs connection errors; document deployment prereqs |
 | Consumer passes both A365 env var + Spectra options | Low | Spectra options take precedence; env var ignored. Document. |
 | gRPC dependency not installed | Low | `opentelemetry-exporter-otlp` (core dep) includes both gRPC and HTTP |
-| `insecure=False` default may fail on plain HTTP localhost | Low | Document: set `insecure=True` if sidecar doesn't have TLS |
+| Consumer sets `insecure=False` for remote Spectra endpoint but forgets TLS setup | Low | Only relevant for non-sidecar deployments. Default `insecure=True` is correct for localhost. |

docs/brainstorm/spectra-collector-integration/BRAINSTORM.md

@@ -110,12 +110,12 @@ The `TelemetryManager.configure()` method (`config.py`) creates the exporter pip
 |------|----------|------------|
 | Sidecar not running → silent failure | Medium | OTLP exporter logs connection errors; document deployment prereqs |
 | Consumer passes both A365 env var + Spectra options | Low | Spectra options take precedence; env var ignored |
-| `insecure=False` default may fail on plain HTTP localhost | Low | Document: set `insecure=True` if sidecar doesn't have TLS |
+| Consumer sets `insecure=False` for remote Spectra endpoint but forgets TLS setup | Low | Only relevant for non-sidecar deployments. Default `insecure=True` is correct for localhost. |
 
 ### Open Questions (Resolved)
 1. **Union type vs separate param** → Union type on `exporter_options`
 2. **A365 env var behavior** → Ignored entirely when SpectraExporterOptions provided
-3. **Insecure config** → Exposed, defaults to `False`
+3. **Insecure config** → Exposed, defaults to `True` (localhost sidecar)
 4. **Protocol config** → Exposed (`"grpc"` or `"http"`), defaults to `"grpc"`
 5. **Package exports** → `SpectraExporterOptions` added to `__init__.py`
 6. **Test strategy** → Mock `OTLPSpanExporter`

docs/brainstorm/spectra-collector-integration/TLDR.md

@@ -13,7 +13,7 @@ Weave/Copilot Cowork needs Spectra Collector as their telemetry destination. Spe
 
 ## How
 
-- New `SpectraExporterOptions` class with sensible defaults for K8s sidecar (`http://localhost:4317`, gRPC, insecure=false)
+- New `SpectraExporterOptions` class with sensible defaults for K8s sidecar (`http://localhost:4317`, gRPC, insecure=true)
 - `configure(exporter_options=...)` accepts `Agent365ExporterOptions | SpectraExporterOptions` — type-based dispatch selects the exporter
 - When `SpectraExporterOptions` is provided, `ENABLE_A365_OBSERVABILITY_EXPORTER` env var is ignored
 - Under the hood, creates an `OTLPSpanExporter` pointed at the Spectra endpoint — no new dependencies

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py

@@ -272,6 +272,7 @@ def configure(
     token_resolver: Callable[[str, str], str | None] | None = None,
     cluster_category: str = "prod",
     exporter_options: Agent365ExporterOptions | SpectraExporterOptions | None = None,
+    suppress_invoke_agent_input: bool = False,
     **kwargs: Any,
 ) -> bool:
     """
@@ -287,6 +288,7 @@ def configure(
     :param exporter_options: Exporter configuration. Pass Agent365ExporterOptions for A365 API
         export, SpectraExporterOptions for Spectra Collector sidecar export, or None (default)
         to construct Agent365ExporterOptions from legacy parameters.
+    :param suppress_invoke_agent_input: If True, suppress input messages for InvokeAgent spans.
     :return: True if configuration succeeded, False otherwise.
     """
     return _telemetry_manager.configure(
@@ -296,6 +298,7 @@ def configure(
         token_resolver,
         cluster_category,
         exporter_options,
+        suppress_invoke_agent_input,
         **kwargs,
     )
 

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/spectra_exporter_options.py

@@ -17,9 +17,12 @@ class SpectraExporterOptions:
     options classes have no shared base class per design decision C4.
     """
 
+    _DEFAULT_GRPC_ENDPOINT = "http://localhost:4317"
+    _DEFAULT_HTTP_ENDPOINT = "http://localhost:4318"
+
     def __init__(
         self,
-        endpoint: str = "http://localhost:4317",
+        endpoint: str | None = None,
         protocol: Literal["grpc", "http"] = "grpc",
         insecure: bool = True,
         max_queue_size: int = 2048,
@@ -29,7 +32,8 @@ def __init__(
     ):
         """
         Args:
-            endpoint: Spectra sidecar OTLP endpoint. Default: http://localhost:4317.
+            endpoint: Spectra sidecar OTLP endpoint. Defaults to
+                http://localhost:4317 for gRPC or http://localhost:4318 for HTTP.
             protocol: OTLP protocol — "grpc" or "http". Default: grpc.
             insecure: Use insecure (no TLS) connection. Default: True (localhost sidecar).
             max_queue_size: Batch processor queue size. Default: 2048.
@@ -39,6 +43,10 @@ def __init__(
         """
         if protocol not in ("grpc", "http"):
             raise ValueError(f"protocol must be 'grpc' or 'http', got '{protocol}'")
+        if endpoint is None:
+            endpoint = (
+                self._DEFAULT_GRPC_ENDPOINT if protocol == "grpc" else self._DEFAULT_HTTP_ENDPOINT
+            )
         self.endpoint = endpoint
         self.protocol = protocol
         self.insecure = insecure

tests/observability/core/test_spectra_exporter.py

@@ -39,6 +39,16 @@ def test_spectra_exporter_options_defaults(self):
         self.assertEqual(opts.exporter_timeout_ms, 30000)
         self.assertEqual(opts.max_export_batch_size, 512)
 
+    def test_spectra_exporter_options_http_default_endpoint(self):
+        """HTTP protocol defaults to port 4318."""
+        opts = SpectraExporterOptions(protocol="http")
+        self.assertEqual(opts.endpoint, "http://localhost:4318")
+
+    def test_spectra_exporter_options_explicit_endpoint_overrides_default(self):
+        """Explicit endpoint overrides protocol-based default."""
+        opts = SpectraExporterOptions(protocol="http", endpoint="http://custom:9999")
+        self.assertEqual(opts.endpoint, "http://custom:9999")
+
     def test_spectra_options_invalid_protocol_raises(self):
         """ValueError for invalid protocol."""
         with self.assertRaises(ValueError) as ctx:
@@ -102,7 +112,7 @@ def test_configure_with_spectra_options_creates_http_exporter(self, mock_http):
         )
         self.assertTrue(result)
         mock_http.assert_called_once_with(
-            endpoint="http://localhost:4317",
+            endpoint="http://localhost:4318",
         )
 
     @patch("microsoft_agents_a365.observability.core.config.GrpcOTLPSpanExporter")