From 069ec85d361aef37892ceef6af4e0a77a53425ff Mon Sep 17 00:00:00 2001 From: "Edgar Y. Walker" <> Date: Sat, 14 Nov 2026 18:36:58 -0800 Subject: [PATCH] fix(pipeline): loaded side-effect node passes run_alone the unchecked source ids (#381 x #384) Co-Authored-By: Claude Sonnet 5.5 --- src/orcapod/pipeline/loaded_side_effects.py | 3 ++- .../hotfix-loaded-side-effect-run-alone.md | 11 ++++++++++ .../test_loaded_side_effect_nodes.py | 20 +++++++++++++++++++ 3 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 superpowers/plans/hotfix-loaded-side-effect-run-alone.md diff --git a/src/orcapod/pipeline/loaded_side_effects.py b/src/orcapod/pipeline/loaded_side_effects.py index 05222a024..fc8d6ca79 100644 --- a/src/orcapod/pipeline/loaded_side_effects.py +++ b/src/orcapod/pipeline/loaded_side_effects.py @@ -343,7 +343,8 @@ def run(self, *, load_only: bool = False) -> StreamView: run_job_node( self, load_only=True, - run_alone=lambda: self._run_alone(load_only=True), + # As the live node: a run alone has no use for the unchecked source ids. + run_alone=lambda _unchecked: self._run_alone(load_only=True), caller=sys._getframe(1), # pyright: ignore[reportPrivateUsage] # the caller's line is where a failure warning is shown ) return self._with_run_status(self._view_of_rows(self.as_table(), "held")) diff --git a/superpowers/plans/hotfix-loaded-side-effect-run-alone.md b/superpowers/plans/hotfix-loaded-side-effect-run-alone.md new file mode 100644 index 000000000..b801f5c23 --- /dev/null +++ b/superpowers/plans/hotfix-loaded-side-effect-run-alone.md @@ -0,0 +1,11 @@ +# Hotfix: loaded side-effect node passes run_alone the unchecked source ids + +Cause: #384 (ITL-1102) made `run_job_node`'s `run_alone` take the unchecked source ids; #381 +(ITL-1094) `LoadedSideEffectJobNode.run` still passes a zero-argument lambda (basedpyright error, +TypeError if reached). + +Plan: +1. Failing test: a `LoadedSideEffectJobNode` over a non-job stream (an `ArrowTableSource` + stream) runs `run(load_only=True)`; this reaches `run_alone`. +2. Fix: `lambda _unchecked: ...`, as the live `SideEffectJobNode.run` does (the ids are unused). +3. basedpyright, ruff, targeted tests, changelog check; PR. diff --git a/tests/test_pipeline/loaded_job/test_loaded_side_effect_nodes.py b/tests/test_pipeline/loaded_job/test_loaded_side_effect_nodes.py index 67b33c909..1fc48dd67 100644 --- a/tests/test_pipeline/loaded_job/test_loaded_side_effect_nodes.py +++ b/tests/test_pipeline/loaded_job/test_loaded_side_effect_nodes.py @@ -403,3 +403,23 @@ def deliver(ctx: Any, x: int) -> None: loaded = Pipeline.load(blueprint) with pytest.raises(RuntimeError, match="SideEffectNode.*no live side-effect pod"): _ = loaded.to_invocations() + + +def test_a_loaded_side_effect_node_over_a_non_job_stream_runs_load_only( + saved: tuple[PipelineJob, list[int], pathlib.Path], +) -> None: + """A load-only run reaches ``run_alone`` when no job node feeds the node. + + ``PipelineJob.load`` always puts a job node upstream, so the node is built directly + over a source's stream (#381 x #384: ``run_alone`` takes the unchecked source ids). + """ + from orcapod.pipeline.loaded_side_effects import LoadedSideEffectJobNode + + _, sent, path = saved + delivered_before = list(sent) + descriptor = _descriptors(path)["delivered"] + node = LoadedSideEffectJobNode(descriptor, _source()) # pyright: ignore[reportArgumentType] # a source is a stream + view = node.run(load_only=True) + assert view.status is ViewStatus.LOADED_ONLY + assert view.as_table().num_rows == ROWS + assert sent == delivered_before