feat(lora): add dynamic coding rate policy#10327
Draft
Komzpa wants to merge 5 commits into
Draft
Conversation
405c8ee to
a4f69a6
Compare
9257f23 to
e9c9e26
Compare
8 tasks
c912d15 to
3b0e4ef
Compare
3b0e4ef to
8ca98c0
Compare
Store the initial retransmission countdown in PendingPacket so DCR can derive retry attempts from packet state instead of sender role assumptions. Inspired-by: @NomDeTom in meshtastic#10359
Expose only the DCR on/off mode in LoRaConfig and keep the tuned policy clamps internal for now. Meshtasticator modeling showed small knob changes can help one scenario while hurting dense collision-heavy cases, so avoid committing an oversized public config surface before field validation.
8ca98c0 to
46c200a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a first firmware implementation of Dynamic Coding Rate as a shared
AirtimePolicyinstead of backend-local heuristics.MeshPacketfieldDependency
Depends on meshtastic/protobufs#902 for the source
LoRaConfigfields. The firmware submodule pointer is intentionally not advanced in this PR; only the generated firmware-side protobuf files are included here.Rollout Notes
DCR is a simple on/off policy gate:
DCR_OFFkeeps the configured static coding rate, andDCR_ONapplies per-packet coding-rate selection. There is no observe-only mode, and this PR does not reserve debug/capability fields that are not consumed by the firmware.Hardware interop still needs real-radio validation across SX126x, SX127x/RF95, SX128x, LR11x0, static-CR nodes, and mixed DCR/static relays.
Tests
git diff --check./bin/test-native-docker.sh -f test_dynamic_coding_rate(16/16)platformio run -e heltec-v3platformio run -e tbeamAttestations
heltec-v3andtbeam; native Portduino policy tests pass. Real-radio interop remains pending as noted above.