Repository navigation
Commit cb91861
committed
toolchain: a stated linker reaches the link on every shape, and gcc says it cannot
`--ld-path` was appended inside the Linux clang branch, the only one that
consumes `link_toolchain_flags`. On macOS the stated linker therefore entered the
fingerprint -- touching the wrapper declined the fast path -- and took no part in
the link, with nothing said; the toolchain lab measured it on macos-15, where
build.ninja held no `--ld-path`. e2e 875 asserts that flag but skips on a host
without the llvm payload, which macOS CI is.
The flag belongs to the driver, not to a platform, so it is added once after every
shape has built its line. For a gcc toolchain the declaration is now refused where
it is read: gcc selects a linker by the name `ld` inside a `-B` directory, so a
program named anything else could not be chosen, and a silent `-B` would be the
same defect in the other direction.1 parent 49abb10 commit cb91861
3 files changed
Lines changed: 41 additions & 8 deletions
File tree
- .agents/docs
- src/build
- prepare
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
153 | 159 | | |
154 | 160 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
975 | 975 | | |
976 | 976 | | |
977 | 977 | | |
978 | | - | |
979 | | - | |
980 | | - | |
981 | | - | |
982 | | - | |
983 | | - | |
984 | | - | |
985 | | - | |
986 | 978 | | |
987 | 979 | | |
988 | 980 | | |
| |||
2401 | 2393 | | |
2402 | 2394 | | |
2403 | 2395 | | |
| 2396 | + | |
| 2397 | + | |
| 2398 | + | |
| 2399 | + | |
| 2400 | + | |
| 2401 | + | |
| 2402 | + | |
| 2403 | + | |
| 2404 | + | |
| 2405 | + | |
| 2406 | + | |
| 2407 | + | |
| 2408 | + | |
| 2409 | + | |
| 2410 | + | |
| 2411 | + | |
| 2412 | + | |
| 2413 | + | |
| 2414 | + | |
| 2415 | + | |
| 2416 | + | |
2404 | 2417 | | |
2405 | 2418 | | |
2406 | 2419 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
243 | 257 | | |
244 | 258 | | |
245 | 259 | | |
| |||
0 commit comments