From 27ce9a8ef4e277fedff2ad737e03d24eb1ce11b0 Mon Sep 17 00:00:00 2001 From: Martin Bertschler Date: Sun, 7 Jun 2026 14:27:26 +0200 Subject: [PATCH] ci: drop redundant `go build ./...` step MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `go vet ./...` already compiles and type-checks every package (including test files, which `go build` skips), so for the default build it fully subsumes `go build ./...` as a compile check. The only thing build adds is linking the main binaries — and this is a pure-Go tree (modernc.org/ sqlite, no cgo/import "C", no assembly, no //go:linkname), so a successful vet guarantees a successful link. The `go build -tags wailsdesktop` step stays: it compiles tag-gated code vet never sees and links a real cgo/WebKit binary, where link errors are genuinely possible. --- .github/workflows/ci.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d8fc2c1..4844355 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,8 +31,8 @@ jobs: # Native deps for `go build -tags wailsdesktop` below. Wails v3 # alpha targets WebKitGTK 6.0 (which pulls in GTK4 + libsoup-3.0); # Ubuntu 24.04 (ubuntu-latest) ships these as libwebkitgtk-6.0-dev. - # The default `go build ./...` doesn't need any of this — it's - # only the wailsdesktop-tagged build that links to the webview. + # The default build/vet/test don't need any of this — only the + # wailsdesktop-tagged build links to the webview. - name: Install Wails native deps run: | sudo apt-get update @@ -40,9 +40,6 @@ jobs: libgtk-4-dev libwebkitgtk-6.0-dev libsoup-3.0-dev \ pkg-config - - name: go build - run: go build ./... - # Catch regressions in cmd/squirrel-desktop/main_wailsdesktop.go, # which is excluded from the default build by its build tag and # would otherwise never be compiled in CI.