fix: remove unsafe exec() in tracer.go#90
Open
orbisai0security wants to merge 2 commits into
Open
Conversation
Automated security fix generated by Orbis Security AI
Owner
|
It needs a rebase on main to run e2e tests |
maxgio92
reviewed
Jun 4, 2026
| return report.WriteReport(file) | ||
| } | ||
|
|
||
| func dropElevatedCapabilities() error { |
Owner
There was a problem hiding this comment.
This doesn't work with the Go scheduler, since it is going to apply only to the current thread - it is persistent with goroutine preemption or new ones scheduled on different runtime threads - unless probably GOMAXPROCS=1
capset() only affects the calling OS thread. With Go's M:N scheduler, goroutines can migrate between threads, leaving other threads with elevated capabilities. Use syscall.AllThreadsSyscall6 to execute capset on all runtime threads atomically. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
I've addressed the code review comments. Pls review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
pkg/trace/tracer.go.Vulnerability
V-003pkg/trace/tracer.go:274Description: The application integrates libbpfgo (v0.9.2) and resurgo (v0.4.2) to load and execute eBPF programs, which requires CAP_BPF or CAP_SYS_ADMIN privileges. The security assessment does not confirm that the application drops these elevated capabilities after the BPF programs are loaded, meaning the entire process lifetime (including file I/O, argument parsing, and report generation) runs with kernel-level privileges. This privilege retention critically amplifies the impact of all other vulnerabilities in the application: the path traversal findings (V-001, V-002) become capable of overwriting any file on the system when combined with root/CAP_SYS_ADMIN execution. Additionally, the eBPF tracing capability can observe sensitive data from all processes on the system.
Changes
pkg/trace/tracer.goVerification
Automated security fix by OrbisAI Security