From fe8a2bbeb230f8ab410ef90cf8c49064acf25650 Mon Sep 17 00:00:00 2001 From: bRong Njam Date: Thu, 8 Oct 2026 10:31:30 +0800 Subject: [PATCH] fix(tests): qualify importer types in unity builds --- test/c/test_extension_import.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/c/test_extension_import.cpp b/test/c/test_extension_import.cpp index 5bfbeb43..426b3410 100644 --- a/test/c/test_extension_import.cpp +++ b/test/c/test_extension_import.cpp @@ -26,7 +26,7 @@ class ImportHandler final : public SubstraitExtensionHandler { types++; return LogicalType::BIGINT; // test-only carrier, not numeric execution } - unique_ptr Literal(ClientContext &, const SubstraitExtensionIdentity &id, + duckdb::unique_ptr Literal(ClientContext &, const SubstraitExtensionIdentity &id, const substrait::Expression_Literal &literal) const override { REQUIRE(id.name == "exact"); REQUIRE(literal.user_defined().type_parameters_size() == 3); @@ -35,18 +35,18 @@ class ImportHandler final : public SubstraitExtensionHandler { literals++; return make_uniq(Value::BIGINT(23)); } - unique_ptr Scalar(ClientContext &, const SubstraitExtensionIdentity &id, + duckdb::unique_ptr Scalar(ClientContext &, const SubstraitExtensionIdentity &id, const substrait::Expression_ScalarFunction &fn, - vector> children) const override { + duckdb::vector> children) const override { REQUIRE(id.name == "identity:complete-signature"); REQUIRE(fn.has_output_type()); REQUIRE(children.size() == 1); scalars++; return std::move(children[0]); } - unique_ptr Aggregate(ClientContext &, const SubstraitExtensionIdentity &id, + duckdb::unique_ptr Aggregate(ClientContext &, const SubstraitExtensionIdentity &id, const substrait::AggregateFunction &fn, - vector> children) const override { + duckdb::vector> children) const override { REQUIRE(id.name == "total:complete-signature"); REQUIRE(fn.has_output_type()); REQUIRE(children.size() == 1); @@ -90,13 +90,13 @@ void Parameters(Parameterized *type) { } } -unique_ptr Execute(Connection &con, const substrait::Plan &plan, - shared_ptr handler) { +duckdb::unique_ptr Execute(Connection &con, const substrait::Plan &plan, + duckdb::shared_ptr handler) { SubstraitToDuckDB converter(con.context, plan.SerializeAsString(), false, false, std::move(handler)); return converter.TransformPlan()->Execute(); } -void CheckValue(unique_ptr result, int64_t expected) { +void CheckValue(duckdb::unique_ptr result, int64_t expected) { REQUIRE_FALSE(result->HasError()); auto chunk = result->Fetch(); REQUIRE(chunk);