From 0b3178ef0e42eb0954157fb0bd0ce0189376f9bd Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sat, 14 Nov 2026 20:52:57 +0700 Subject: [PATCH 01/25] feat(gui): deploy compact GAIN LED knob and black/green LCD to approved preview (#690) Preserve the approved operator UI. Add static brushed-steel PNG with slimmer cap, 30-segment LED ring and fixed green pointer, true-black LCD, contextual vertical GAIN label, and focused three-viewport Chromium QA. --- .github/workflows/ui-smoke.yml | 28 +++++ .../assets/mixer-gain-knob-brushed-steel.png | Bin 0 -> 5206 bytes .../assets/mixer-section-controls.css | 101 ++++++++++++++---- site/preview-v2/index.html | 13 ++- tests/sof_contextual_console_smoke.py | 66 ++++++++++++ 5 files changed, 189 insertions(+), 19 deletions(-) create mode 100644 site/preview-v2/assets/mixer-gain-knob-brushed-steel.png diff --git a/.github/workflows/ui-smoke.yml b/.github/workflows/ui-smoke.yml index 1fb9d5d8d..140bc60f1 100644 --- a/.github/workflows/ui-smoke.yml +++ b/.github/workflows/ui-smoke.yml @@ -139,6 +139,34 @@ jobs: - name: Block incomplete product release only when preparing product review if: ${{ github.event_name == 'pull_request' && !github.event.pull_request.draft && startsWith(github.head_ref, 'integration/product-') }} run: node scripts/check_console_puzzle.mjs --release + gain-metal-knob-preview: + name: GAIN metal knob Chromium FAT (3 viewports) + needs: quick + # One scoped browser validation for the new photographic GAIN control; + # no PCM rebuild, installer or heavyweight generic visual suite. + if: ${{ github.event_name == 'pull_request' && startsWith(github.head_ref, 'feat/gain-metal-knob-') }} + runs-on: ubuntu-latest + timeout-minutes: 10 + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-python@v5 + with: + python-version: "3.12" + - name: Install one scoped Chromium + run: | + python -m pip install playwright + python -m playwright install --with-deps chromium + - name: Validate approved /preview/ GAIN, FX and SOF at 3 sizes + run: python tests/sof_contextual_console_smoke.py + - name: Retain rendered operator evidence + if: ${{ always() }} + uses: actions/upload-artifact@v4 + with: + name: ArSonMix-GAIN-Brushed-Metal-${{ github.run_id }} + path: arsonmix-gain-knob-*.png + if-no-files-found: ignore + retention-days: 7 + floating-window-preview: name: Modeless floating cards actual Chromium interactions (2 viewports) needs: quick diff --git a/site/preview-v2/assets/mixer-gain-knob-brushed-steel.png b/site/preview-v2/assets/mixer-gain-knob-brushed-steel.png new file mode 100644 index 0000000000000000000000000000000000000000..7bae3ba396c9c952d7e549e7236bf4ece257d147 GIT binary patch literal 5206 zcmV-c6shZpP)B} zN|ly*8nn#AQj>r)CYoqTg-4_)EwJS1 z7yo&$z)Md#>ylNMtp3T>&pd%82qhH-MJRP7g#_`y6g~Qw1@0PO_u#*N@D_ltx{Hp= zh@&!K#(v%_n9DDD&Rf@9eCpD*tY)dlFEB47*&}1dvcQr&)?J_Y@F#EEX83?PvYa?F17xGQ%){kxJoWw0JL@E-s=iK{zVzu~ zDHySv1;z{+u|UC?k}*RHN-6>s0k8Aw!%6x1ta^0!hc5pc^sDZo>PKS0tocw-UUA;p zAAasD*DzH&$xO}^1E%SdQL?}u=2@U%$cPaIV+smJlz1u%DgugUsHHz8e<{npe%tT- z;jL;=S!6z##V&un+YmH=^PgPsjk905q6}4OD-%!xfeKI1KtQPLmS7M90nqqW{}w7d zne^Sm{4u=(` zB;W~nDm|r3xxaeAo%!mwpLNG|pBrwpn-&oTyC}-ESNe-D{qZk8 z?{o?kV+;-#U1G?{$#7yQ7&D5gTTmwWR0P0B_|$O&CD1o}^pPI1Gwna2N~*!2%T}C7wV@Nl6vIN-8QU0s)Pt)K|cW zF}Ig)?aMA*H@D%Duewi%V;cdPl?~yIA3x*0gR(-5kl~_@^>>OO5k%TqbQMkU@!ydC ztykE9DWD9@ebt`j7hd*~n=XHNKT(h)Phy#s4PoZ0Gk#Nxp;f7qw2Wz4L!?Z27c7#1 zWl}=dE2!V2F*Arp5bw0qe!KkgisydiBQM!dZQR?rdZZDM8FOWr`G+5SlOIe2ss9W zjlq>j~!$U{}9BGfUc4I<{*w7b6azxL5rT;}(Jk#r3>2z*Zcqv_Q{k0JUeLLqv* zqKwNB#tf-qYI};v_BH0q$X0Fbt(QvFLfy=0;Z%cS#5Z;IpOVe!#5%QWzyaa&;&WHL zZN3Vw_P9pKg!o|K%-No+LWsBYDfCShHBmkccp-Ebdv|*qeitIkhIC}+c>DEN3|DkchOSQ-!;A>Ydmt{NWm4Hu-hWn);=o2HT3=21d32d`w^;D{&F)LP1HO zV4hI~kVM^I7d(>|=wmHV(N4oT`F;J$?Sp>)ygzuk=!`uq1J)Zj<&A@-MTux?2OCyt zMc5dhbf%B`v!GVKvb#se*v2P=!ZX{;M!^coDeKBZJEn zBt*}*WhUSwESiXviGfNA7Fb|R#fTw+9vKEhU@R4=L?Q@DPNdFQyG=i6svJnb*#{Y4 z@|u;G?I)4@3S?JpUrtH<8W$0CeKTedjCUKqPboSYt*5oT@{f1yyX`o3yT% zFLi{(iLooBy`ZK9WZH>!%gAx6aVAyNv zzEg`sr#-JaIZ!fWfg!uu%^o~1zOziNeQ12jB>$_b3aV((HietNw6a6X=l=YuIVWODg}Fl73SL)L*c3g&dB?tvziqb4=k zB%_ZbtU4a;5OEI+Ji+7aphB5v#Jr4R9DIlQB^A4->5uBZ{ZEV$SQ!zX16PEDMqpzQ z%!xj>-|gV3Cc`%LntrG8BTUql21`c87{eo+LSTX23@Os=q0TIkx}o?>)MdT#IPs{v)7}Gp(t6s+Ec$sC2;;CfJ*f5Nj4PW)F|iXTZa?{1((; zT2D*UtIGswc2rOtP1bP@qG*qd;!sJPY2KC@(;0QNtW77eCDu=!5W>x0e2a6Ks(S_n z5$%8@q@N6;BF%kFjE;6vG!nYqxA5+3KnOuQIB&IiNCDNK+U(VeP_h@?5`>AZ%O z+|O>jR1<|uqHpVEid*%GP)fqKCcr5gz0@Xh<9|V=j#a&Quw-N` zXC;<%*+q{r!?qT8$hgKl+PpK=MJ-9WCJKTh6jZWT<2h-73R;9c(p`27ikQS*z(@p{ zncxkBBWIc=Ppa~&j3S-VI{jFLp4NOVWOyLuwD=7>+cL8 zilicjP^e{oE8J)Z2QlCYf$@DImMz)O&`2g~WOuCEEZ>mPr_U4v93Ejg%VS+I2;&G7 z)9g|LqF%a1tfnjxVyOg!W%R(lQer<^Xnu1Ub;^NucDl^nO*Iqo?_v@=98faNG^4bo zB#Z%%rNZM9@|$5yNK=ZY3JZ!A7~WNjor4%K7hu<2qiTs0)s7z2&cY{mn_Dh7ajVHj zOxJUvKuMozh79Sa9pXmDHTMc)a7jYf^+!dL@I$Q|m0RzGO$Rps6}CTEZE@?o52nip zIsq0EawU$@CFOvN>6yiRs4xuZGZi~C9|7vg2o2&Xu_z|SAVhek&(~=w9(wShx*i;? zBhyPQ<-#|7q#xO9;3xap@oWo^iQ7qzJegFFgL8WH=+mQ5A4flJfk@nhGM%E;Zc3%i zsnF9s-=w_MatH(1DzM|4u~-q1mfBjrFp2F=^mcdgHgbuJ{;!+LoD55ke%w2A^dgzM zXndZID_A6fuz5Kt<;gGCBy$J@Zuao~>-RimGtsV2Hxs^>R26L6p*QhEGqPl~Qc*FY z!m)%LOOGBoJ#rjEMjpN1EZ0USm`*g%o?CeOyEnj`KlEHkXDr+ITrU{kOqSarx#`U0 z+tOuliRx_felNzt#}Sv1Gr*EFO%@kg8!Tk;-L3;38{;Zuz9+k{-?MGTa_F%NYyzJC z`+2OPgUXicC6T61u)mE4G(Y*ciB!)mGIDw`0usI7!;oRfCnDW`Vhu2hGoD93v;QIV ze(C^TMQ&Jg$8*jOUQMGKZ4?!)RtdOdph-k((!PMi?TcE+<_sw4Q!*x_q)&mzP~fN{ z*VLb3JJbLHLf<}i?>*P5NI1;#`h}Ki$6t)ZsU)Fh5|9KN<*;^Iz$|3~F#=kBNS?>3uftE7bS1p^`^FMscCt-)_==4Vd#P4`21f{nnY#;@?II*O)-3 z0^11_+uh%Gju&EbI{NftwGJ_N>Iz_E4KW=>C7952k8S+4=spO z=_pUzncLWeTbrbuo!}2mJDc@JNQNV)pD0r3At{OT4t3Udsrf0_V77jkUHkX{0e5KT z{H%HGs>g0KS>4XsBzD`XVA9mUMjy6`=*Z$S8VDJ3dXf2UEOtUhrb;%5@e#RS*#d>PD%jjlrim$ zg=^Z)V)E9|A=YRcHw5#z@ES^4WwY;Iwe>4Ac9TDX!ycQ$ta;$Qk8W|f1R~bk9;x9Q zhZQ=#RI6&*jlp_yXJd_Sgoff6MD}vAjMaC@>l_J#?4Cz&eb=lx*eS+?o&=dQjK;T3 z{mKgUBGNLw?ZC-In3%*KV58dUb%aBPi`(P%rfk(=teTLs6jy_yI?xBrw_d++_uf6& zVoq%7dUx+bez^SNeyP@U05Yi-8~$k`lSM{pdV(4xIX0f-YK}XFNUwDrkwgVbV5)jD z|N8rW@R{}QVSf}y&K?fy-CZ|@(@r?wl`0~1v{9o~=%~h)$(ydgCDrND_8y&`H|e}P z#PS%JDtGq2_Nn`SZ@rtVj`GOaoS(5}JRUBSwtUDX)4!FLA%KU+(N(_qE$E(V=kYMgaPIqRtF{M3w)ug<3wqwg!FIR(NThw^JS-g%iU=s~$>@kfsp zE4!cESe?1zg;Q0ClYN<(p}Dxo_LW6I7i(|5d>hYmmGQi9eT3QL8B|4n-RRnP zJn@lPb0dfUSkPjQ-zzd}zI5#q-(mgA6?p}SbXr3jTT4l^&xV(5hgzFseH3J&(Ls9-Xmwb0iPM9r=TBR=mRWnzx+t>nEST zmT9OYAZncCF^%gndoEMjCu6{Xf%bz{HM`sc+@#-{`})Vj=Lsqz9O09dNAo0K^BAJ^ z)<5_16JPtRXPwA28LqOyVlYz6iavb?x`b&4cFI;f!Y$mg<=bDl?<#HuK`s6$7QxY7 zf)TF(%cov)@~c)~u=31RD^6e~eWnusI}8=Oc$`PJZP|S9+yggoEAv7SF`XUT{}BVC z5i`_}gaRkAZtc41QyTIwotw17E&9lwrW|L?B<0t8bW;r^~} Q0ssI207*qoM6N<$f@%pM_5c6? literal 0 HcmV?d00001 diff --git a/site/preview-v2/assets/mixer-section-controls.css b/site/preview-v2/assets/mixer-section-controls.css index 193d4ed4a..161238237 100644 --- a/site/preview-v2/assets/mixer-section-controls.css +++ b/site/preview-v2/assets/mixer-section-controls.css @@ -109,34 +109,101 @@ display:flex;flex-direction:column;min-height:0;overflow:hidden; background:linear-gradient(180deg,#21343d,#172832); } +/* Compact hardware GAIN: the photographic steel cap and its fixed lift-shadow + never rotate. Only the separate LED segments and luminous needle track the + existing native-ACK-backed --gain-rotation value. No SVG filters or animation. */ .console-body .strip .gain-view-body{ min-height:0;flex:1;display:flex;flex-direction:column; - justify-content:center;align-items:center;gap:2px;padding:2px 2px 4px; + justify-content:center;align-items:center;gap:8px;padding:7px 3px 10px; } .console-body .strip .gain-dial{ - position:relative;display:block;flex:0 0 39px;width:39px;height:39px; - border-radius:50%;cursor:ns-resize; + position:relative;display:block;box-sizing:border-box; + flex:0 0 auto;width:min(68px,calc(100% - 20px)); + aspect-ratio:1/1;height:auto;min-height:0;border-radius:50%; + cursor:ns-resize;touch-action:none;isolation:isolate; } .console-body .strip .gain-dial-face{ - display:block;position:absolute;inset:2px;border:2px solid #5c747f; - border-radius:50%;background:radial-gradient(circle at 38% 31%,#617480,#273842 65%,#15242b); - box-shadow:inset 0 1px #9aafb844,0 2px 3px #0007; -} -.console-body .strip .gain-dial-face::after{ - content:"";position:absolute;left:50%;top:4px;width:2px;height:10px; - border-radius:2px;background:#d2ecf3;box-shadow:0 0 1px #fff8; - transform-origin:1px 12px;transform:translateX(-50%) rotate(var(--gain-rotation,0deg)); + position:absolute;display:block;inset:7px;border-radius:50%; + background:#45484b url("mixer-gain-knob-brushed-steel.png") center/cover no-repeat; + /* One thin PNG edge: no extra heavy CSS bezel. Static contact + lift shadow. */ + box-shadow:0 2px 3px #000d,0 5px 8px #0009; + pointer-events:none; +} +.console-body .strip .gain-dial-arc{ + position:absolute;inset:1px;display:block;border-radius:50%;pointer-events:none; + /* A 5px annular LED track. Conic masks limit it to a 270-degree travel; + 6-degree bars / 3-degree gaps make 30 discrete hardware-style LEDs. */ + -webkit-mask:radial-gradient(farthest-side,transparent calc(100% - 5.5px),#000 calc(100% - 5px)); + mask:radial-gradient(farthest-side,transparent calc(100% - 5.5px),#000 calc(100% - 5px)); +} +.console-body .strip .gain-dial-arc::before, +.console-body .strip .gain-dial-arc::after{ + content:"";position:absolute;inset:0;border-radius:50%; +} +.console-body .strip .gain-dial-arc::before{ + background:repeating-conic-gradient(from 225deg,#345349 0deg 6deg,transparent 6deg 9deg); + -webkit-mask:conic-gradient(from 225deg,#000 0deg 270deg,transparent 270deg 360deg); + mask:conic-gradient(from 225deg,#000 0deg 270deg,transparent 270deg 360deg); +} +.console-body .strip .gain-dial-arc::after{ + background:repeating-conic-gradient(from 225deg,#69ffab 0deg 6deg,transparent 6deg 9deg); + -webkit-mask:conic-gradient(from 225deg,#000 0deg calc(135deg + var(--gain-rotation,0deg)),transparent 0deg 360deg); + mask:conic-gradient(from 225deg,#000 0deg calc(135deg + var(--gain-rotation,0deg)),transparent 0deg 360deg); +} +.console-body .strip .gain-dial-pointer{ + display:block;position:absolute;inset:7px;border-radius:50%; + transform:rotate(var(--gain-rotation,0deg));pointer-events:none; +} +.console-body .strip .gain-dial-pointer::before{ + content:"";position:absolute;top:8%;left:50%;width:3px;height:23%; + transform:translateX(-50%);border-radius:3px; + background:linear-gradient(90deg,#137a47,#deffe5 47%,#4dffa0); + box-shadow:0 0 2px #9cffc8,0 0 6px #15ef85,0 0 9px #20d77c8c; +} +.console-body .strip .gain-dial-pointer::after{ + content:"";position:absolute;top:7%;left:50%; + width:4px;height:4px;transform:translateX(-50%);border-radius:50%; + background:#eaffed;box-shadow:0 0 4px 1px #42f9a8; } .console-body .strip .gain-dial input{ position:absolute;inset:0;width:100%;height:100%;margin:0;opacity:0; cursor:ns-resize;writing-mode:vertical-lr;direction:rtl; } -.console-body .strip .gain-dial:focus-within{outline:2px solid #7ebccf;outline-offset:1px} +.console-body .strip .gain-dial:focus-within{outline:2px solid #7ce7ba;outline-offset:6px} +.console-body .strip .gain-dial:has(input:disabled){opacity:.55;cursor:not-allowed} +.console-body .strip .gain-dial input:disabled{cursor:not-allowed} .console-body .strip .gain-readout{ - display:block;text-align:center;font-size:10px;line-height:15px; - min-width:65px;max-width:100%;padding:0 4px;border-radius:2px; - background:#102530;border:1px solid #3c606e;color:#b9e8f3; - font-variant-numeric:tabular-nums;font-weight:500;white-space:nowrap; + position:relative;box-sizing:border-box;display:flex;align-items:center;justify-content:center; + width:min(98px,calc(100% - 10px));max-width:100%;min-height:29px; + padding:3px 4px;overflow:hidden;border-radius:3px; + /* A true black LCD well, not the previous teal-blue textbox gradient. */ + border:1px solid #405a4b;background:#020503; + box-shadow:inset 0 2px 5px #000,0 1px 0 #9cbda51f; + color:#74fda0;text-shadow:0 0 5px #43f78b88; + font:600 13px/19px Consolas,'Lucida Console',monospace; + font-variant-numeric:tabular-nums;letter-spacing:.01em;white-space:nowrap; +} +.console-body .strip .gain-view-body:has(.gain-dial input:disabled) .gain-readout{ + font-size:10px;letter-spacing:0; +} +/* The section rail uses real caption text: legacy chrome owns ::after + with !important (its collapse glyph), so never fight that pseudo-element. */ +.console-body .section-rail .rail-cell.fx .rail-gain-caption{display:none} +.console-body.gain-view-active .section-rail .rail-cell.fx .rail-svg-icon{display:none} +.console-body.gain-view-active .section-rail .rail-cell.fx .rail-gain-caption{ + display:block;writing-mode:vertical-rl;transform:rotate(180deg); + font:600 11px/1 'Segoe UI',Arial,sans-serif;letter-spacing:.16em; + color:#b7f2d1;text-shadow:0 0 4px #38ca8a33; +} +@media(max-height:680px){ + .console-body .strip .gain-view-body{gap:6px;padding:5px 2px 7px} + .console-body .strip .gain-dial{width:min(59px,calc(100% - 20px))} + .console-body .strip .gain-readout{min-height:26px;font-size:12px} +} +@media(max-height:610px){ + .console-body .strip .gain-dial{width:min(49px,calc(100% - 18px))} + .console-body .strip .gain-view-body{gap:4px;padding:2px 2px 4px} + .console-body .strip .gain-readout{min-height:22px;font-size:11px;line-height:15px} } .console-body .strip .sof-view-body{ flex:1;display:flex;align-items:center;justify-content:space-between; @@ -172,7 +239,5 @@ .command-bar .mix-context{padding:2px 4px} } @media(max-height:610px){ - .console-body .strip .gain-dial{flex-basis:28px;width:28px;height:28px} - .console-body .strip .gain-dial-face::after{height:7px;transform-origin:1px 9px} .console-body .strip .sof-info small{display:none} } diff --git a/site/preview-v2/index.html b/site/preview-v2/index.html index 019006a77..7caa09fdf 100644 --- a/site/preview-v2/index.html +++ b/site/preview-v2/index.html @@ -88,7 +88,7 @@