From c2bccd54fdf70c734510613b3a0d5343eaa2f12e Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Wed, 28 Oct 2026 07:57:00 +0700 Subject: [PATCH] fix(gui): restore folded metal fader recess on all 10 channels + MASTER with offline parity and computed-style regression --- AR-MIX-Live-FX-Host-Standalone-v0.3.html | 29 ++++++++++++++++++++++++ tests/fader_asset_test.py | 18 +++++++++++++++ tests/ui_smoke.py | 19 ++++++++++++++++ web/styles-src/42-mixer-premium.css | 29 ++++++++++++++++++++++++ web/styles.css | 29 ++++++++++++++++++++++++ 5 files changed, 124 insertions(+) diff --git a/AR-MIX-Live-FX-Host-Standalone-v0.3.html b/AR-MIX-Live-FX-Host-Standalone-v0.3.html index 300ad3dc3..4bb963469 100644 --- a/AR-MIX-Live-FX-Host-Standalone-v0.3.html +++ b/AR-MIX-Live-FX-Host-Standalone-v0.3.html @@ -1143,6 +1143,35 @@ } /* LED increments stay fixed and the meter keeps its native dBFS conversion. No hot-path DOM reads, filters, blur or per-frame scale animation. */ + +/* P0 FADER BED RECOVERY, main-aligned from PR #102 (visual CSS ONLY). + Full-height smooth graphite metal folds; zero white rectangular border. + No blur, gradients, interactive filters, animation or pointer listeners. + Recess width is bounded to the actual rail so CH1-10/MASTER VU and rulers + remain unobstructed on narrower displays. 36×77 PNG and 38px detent kept. */ +#app #mixer .fader-zone .fader{ + position:relative;isolation:isolate;min-width:36px; + background:transparent!important;border:0!important;box-shadow:none!important; +} +#app #mixer .fader-zone .fader::before{ + content:"";position:absolute;top:0;bottom:0;left:50%; + width:min(46px,100%);transform:translateX(-50%); + z-index:0;pointer-events:none;box-sizing:border-box; + background:#26343c;border:0;border-radius:6px; + box-shadow: + inset 0 4px 4px -3px #070e13, + inset 0 -4px 4px -3px #070e13, + inset 4px 0 5px -4px #081116, + inset -4px 0 5px -4px #081116; +} +#app #mixer .fader-zone .fader::after{ + content:"";position:absolute;left:50%;top:38px;bottom:39px; + width:5px;transform:translateX(-50%); + z-index:0;pointer-events:none; + background:#05090c;border:0; + box-shadow:inset 1px 0 #34434b,inset -1px 0 #34434b; +} +#app #mixer .fader-zone .fader-travel{z-index:1}
diff --git a/tests/fader_asset_test.py b/tests/fader_asset_test.py index d045ea0c5..1ce23015e 100644 --- a/tests/fader_asset_test.py +++ b/tests/fader_asset_test.py @@ -75,4 +75,22 @@ assert 'fader-tools master-tools' not in js assert 'masterMono' in js assert 'class="btn-180 master-mode' in js + +# P0 physical recess is source-owned, not merely present in a stale screenshot. +# These selectors must be last so the old narrow line can't override the bay. +for marker in ( + "P0 FADER BED RECOVERY", + "width:min(46px,100%)", + "background:#26343c;border:0;border-radius:6px", + "inset 0 4px 4px -3px #070e13", + "inset 0 -4px 4px -3px #070e13", + "inset 4px 0 5px -4px #081116", + "inset -4px 0 5px -4px #081116", + "width:5px;transform:translateX(-50%)", + "#app #mixer .fader-zone .fader-travel{z-index:1}", +): + assert marker in finish, "Latest fader recess lost from source: "+marker +assert "backdrop-filter" not in finish.split("P0 FADER BED RECOVERY",1)[1] +assert "filter:" not in finish.split("P0 FADER BED RECOVERY",1)[1] + print("PASS: rose-gold MASTER, 10 channels, button mode/clip layout, offline parity") diff --git a/tests/ui_smoke.py b/tests/ui_smoke.py index f81e576f4..f09ba9702 100644 --- a/tests/ui_smoke.py +++ b/tests/ui_smoke.py @@ -563,6 +563,25 @@ def same_rect(a,b): assert len(geometry)==11 and all(x['nameTop']>=x['faderBottom']-1 for x in geometry),geometry assert all(not x['hasTools'] for x in geometry if not x['master']),geometry assert not any(x['hasTools'] for x in geometry),geometry + # Fader rail must be an actual smooth bent-metal recess (not old slit-only + # or a bright white rectangular frame); checked for all 10 + MASTER + # in the Browser before approving the Windows distribution. + fader_recess=await page.evaluate("""() => [...document.querySelectorAll('#mixer [data-fader]')].map(f=>{ + const bay=getComputedStyle(f,'::before'),slit=getComputedStyle(f,'::after'); + const rail=f.getBoundingClientRect(),cap=f.querySelector('.cap'); + return {id:f.dataset.fader,rail:rail.width,bay:parseFloat(bay.width), + fill:bay.backgroundColor,edge:bay.boxShadow,border:bay.borderTopWidth, + top:bay.top,bottom:bay.bottom,slit:parseFloat(slit.width), + slitColor:slit.backgroundColor,capWidth:cap.getBoundingClientRect().width}; + })""") + assert len(fader_recess)==11,fader_recess + assert all(x['bay']>=30 and x['bay']<=46.1 and x['bay']<=x['rail']+.1 + and x['fill']=='rgb(38, 52, 60)' and x['border']=='0px' + and 'inset' in x['edge'] and x['top']=='0px' + and x['bottom']=='0px' and x['slit']==5 + and x['slitColor']=='rgb(5, 9, 12)' and x['capWidth']==36 + for x in fader_recess),fader_recess + # Both resting states share depth; while pointer is down only, cap sinks 1px # with a stronger inner shadow and unchanged width/height/layout slot. btn=page.locator('[data-mute="0"]') diff --git a/web/styles-src/42-mixer-premium.css b/web/styles-src/42-mixer-premium.css index 9e4ed9ebe..cda857c5f 100644 --- a/web/styles-src/42-mixer-premium.css +++ b/web/styles-src/42-mixer-premium.css @@ -183,3 +183,32 @@ html:not([data-mixperf="baseline"]):not([data-mixperf="layers-off"]):not([data-m } /* LED increments stay fixed and the meter keeps its native dBFS conversion. No hot-path DOM reads, filters, blur or per-frame scale animation. */ + +/* P0 FADER BED RECOVERY, main-aligned from PR #102 (visual CSS ONLY). + Full-height smooth graphite metal folds; zero white rectangular border. + No blur, gradients, interactive filters, animation or pointer listeners. + Recess width is bounded to the actual rail so CH1-10/MASTER VU and rulers + remain unobstructed on narrower displays. 36×77 PNG and 38px detent kept. */ +#app #mixer .fader-zone .fader{ + position:relative;isolation:isolate;min-width:36px; + background:transparent!important;border:0!important;box-shadow:none!important; +} +#app #mixer .fader-zone .fader::before{ + content:"";position:absolute;top:0;bottom:0;left:50%; + width:min(46px,100%);transform:translateX(-50%); + z-index:0;pointer-events:none;box-sizing:border-box; + background:#26343c;border:0;border-radius:6px; + box-shadow: + inset 0 4px 4px -3px #070e13, + inset 0 -4px 4px -3px #070e13, + inset 4px 0 5px -4px #081116, + inset -4px 0 5px -4px #081116; +} +#app #mixer .fader-zone .fader::after{ + content:"";position:absolute;left:50%;top:38px;bottom:39px; + width:5px;transform:translateX(-50%); + z-index:0;pointer-events:none; + background:#05090c;border:0; + box-shadow:inset 1px 0 #34434b,inset -1px 0 #34434b; +} +#app #mixer .fader-zone .fader-travel{z-index:1} diff --git a/web/styles.css b/web/styles.css index c8a91e769..85f332a2e 100644 --- a/web/styles.css +++ b/web/styles.css @@ -1142,3 +1142,32 @@ html:not([data-mixperf="baseline"]):not([data-mixperf="layers-off"]):not([data-m } /* LED increments stay fixed and the meter keeps its native dBFS conversion. No hot-path DOM reads, filters, blur or per-frame scale animation. */ + +/* P0 FADER BED RECOVERY, main-aligned from PR #102 (visual CSS ONLY). + Full-height smooth graphite metal folds; zero white rectangular border. + No blur, gradients, interactive filters, animation or pointer listeners. + Recess width is bounded to the actual rail so CH1-10/MASTER VU and rulers + remain unobstructed on narrower displays. 36×77 PNG and 38px detent kept. */ +#app #mixer .fader-zone .fader{ + position:relative;isolation:isolate;min-width:36px; + background:transparent!important;border:0!important;box-shadow:none!important; +} +#app #mixer .fader-zone .fader::before{ + content:"";position:absolute;top:0;bottom:0;left:50%; + width:min(46px,100%);transform:translateX(-50%); + z-index:0;pointer-events:none;box-sizing:border-box; + background:#26343c;border:0;border-radius:6px; + box-shadow: + inset 0 4px 4px -3px #070e13, + inset 0 -4px 4px -3px #070e13, + inset 4px 0 5px -4px #081116, + inset -4px 0 5px -4px #081116; +} +#app #mixer .fader-zone .fader::after{ + content:"";position:absolute;left:50%;top:38px;bottom:39px; + width:5px;transform:translateX(-50%); + z-index:0;pointer-events:none; + background:#05090c;border:0; + box-shadow:inset 1px 0 #34434b,inset -1px 0 #34434b; +} +#app #mixer .fader-zone .fader-travel{z-index:1}