Skip to content

P0 integrated SonKu: reconciled native SPACE DSP + GUI + musical A/B release qualification #196

P0 integrated SonKu: reconciled native SPACE DSP + GUI + musical A/B release qualification

P0 integrated SonKu: reconciled native SPACE DSP + GUI + musical A/B release qualification #196

name: Native Built-in FX User Presets (targeted Windows CTest)
on:
pull_request:
types: [opened, reopened, synchronize, ready_for_review]
paths:
- 'src/BuiltInFxUserPresetStore.h'
- 'tests/builtin_fx_user_preset_store_test.cpp'
- 'src/BuiltInFxAcceptedSnapshot.h'
- 'tests/builtin_fx_accepted_snapshot_test.cpp'
- 'engine/builtin_fx/ChannelEq.h'
- 'engine/builtin_fx/ChannelEqProcessor.h'
- 'engine/builtin_fx/ChannelCompressorProcessor.h'
- 'engine/builtin_fx/ChannelHarmonyProcessor.h'
- 'engine/builtin_fx/VocalThrowProcessor.h'
- '.github/workflows/builtin-fx-preset-native.yml'
- 'CMakeLists.txt'
permissions:
contents: read
concurrency:
group: preset-store-ctest-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
jobs:
scope:
name: Verify tip commit actually changed native preset sources
runs-on: ubuntu-latest
outputs:
build: ${{ steps.diff.outputs.build }}
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 2
- name: Check current tip delta, not entire historical PR
id: diff
shell: bash
env:
PR_ACTION: ${{ github.event.action }}
run: |
if [[ "$PR_ACTION" != "synchronize" ]] || ! git rev-parse --verify HEAD^ >/dev/null 2>&1; then
echo 'build=true' >> "$GITHUB_OUTPUT"
elif git diff --name-only HEAD^ HEAD -- \
CMakeLists.txt src/BuiltInFxUserPresetStore.h \
src/BuiltInFxAcceptedSnapshot.h \
tests/builtin_fx_user_preset_store_test.cpp \
tests/builtin_fx_accepted_snapshot_test.cpp \
engine/builtin_fx/ChannelEq.h \
engine/builtin_fx/ChannelEqProcessor.h \
engine/builtin_fx/ChannelCompressorProcessor.h \
engine/builtin_fx/ChannelHarmonyProcessor.h \
engine/builtin_fx/VocalThrowProcessor.h \
.github/workflows/builtin-fx-preset-native.yml | grep -q .; then
echo 'build=true' >> "$GITHUB_OUTPUT"
else
echo 'build=false' >> "$GITHUB_OUTPUT"
echo 'No native preset target changes at HEAD; Windows CTest already qualified earlier'
fi
native-preset:
name: Windows MSVC two-target disk + accepted DSP CTest (Release)
needs: scope
if: ${{ needs.scope.outputs.build == 'true' }}
runs-on: windows-2022
timeout-minutes: 22
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Verify exact candidate source
shell: pwsh
env:
EXPECTED_SHA: ${{ github.event.pull_request.head.sha }}
run: |
$actual = (& git rev-parse HEAD).Trim()
if ($LASTEXITCODE -ne 0 -or $actual -ne $env:EXPECTED_SHA) {
throw "PRESET_SOURCE_SHA_MISMATCH expected=$env:EXPECTED_SHA actual=$actual"
}
Write-Host "PRESET_CTEST_SOURCE_SHA=$actual"
- name: Checkout pinned JUCE 8
uses: actions/checkout@v4
with:
repository: juce-framework/JUCE
ref: 8.0.15
path: third_party/JUCE
- name: Install WebView2 SDK needed by common CMake app configure
shell: pwsh
run: |
nuget install Microsoft.Web.WebView2 -Version 1.0.3485.44 -OutputDirectory .deps -NonInteractive
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
- name: Configure and validate CTest catalog
shell: pwsh
run: |
cmake -S . -B build -G "Visual Studio 17 2022" -A x64 `
-DJUCE_ROOT="${{ github.workspace }}/third_party/JUCE" `
-DBUILD_TESTING=ON `
-DJUCE_WEBVIEW2_PACKAGE_LOCATION="${{ github.workspace }}/.deps"
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
$catalogText = & ctest --test-dir build -C Release --show-only=json-v1
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
$catalog = ($catalogText | Out-String | ConvertFrom-Json)
$names = @($catalog.tests | ForEach-Object { $_.name })
foreach ($required in @('BuiltInFxUserPresetNativePortableSaveAndRecovery',
'BuiltInFxUserPresetFourRealJuceAdaptersAndColdReopen')) {
if ($required -notin $names) { throw "PRESET_CTEST_MISSING:$required" }
}
- name: Compile only two native preset targets (not the mixer)
shell: pwsh
run: |
cmake --build build --config Release --parallel 2 --target ARMixBuiltInFxPresetStoreTests ARMixBuiltInFxAcceptedSnapshotTests
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
- name: Run immutable-source Release CTest (assertions always enabled)
shell: pwsh
run: |
ctest --test-dir build -C Release --output-on-failure `
-R '^BuiltInFxUserPreset(NativePortableSaveAndRecovery|FourRealJuceAdaptersAndColdReopen)$'
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
Write-Host 'PRESET_NATIVE_TWO_TARGETS_STORE_AND_ACCEPTED_PCM_SNAPSHOT=PASS'