From 84efa9ac56cdab61c4166654b60c66237345222e Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 06:44:41 +0700 Subject: [PATCH 01/17] M6.1: replace fader thumb with dark brushed-metal asset and fix clipped knob arcs --- CMakeLists.txt | 2 +- assets/dark_brushed_slider_thumb.png | Bin 0 -> 1206 bytes docs/M61-GUI-POLISH.md | 25 ++++++++++++++++++ plugin/Editor.cpp | 38 ++++++++------------------- plugin/HeaderLayout.h | 2 +- plugin/KnobGeometry.h | 30 +++++++++++++++++++++ tests/PluginSmoke.cpp | 36 ++++++++++++++++++++++--- 7 files changed, 101 insertions(+), 32 deletions(-) create mode 100644 assets/dark_brushed_slider_thumb.png create mode 100644 docs/M61-GUI-POLISH.md create mode 100644 plugin/KnobGeometry.h diff --git a/CMakeLists.txt b/CMakeLists.txt index 1dcfd84..8060759 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -55,7 +55,7 @@ if(ARSON_BUILD_PLUGIN) juce_add_binary_data(ArSonCompKnobAssets SOURCES assets/black_brushed_knob.jpg assets/gunmetal_slider_track.png - assets/gunmetal_slider_thumb_red.png + assets/dark_brushed_slider_thumb.png assets/toggle/arson_toggle_on.png assets/toggle/arson_toggle_off.png assets/arsoncomp_header_logo.png) diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png new file mode 100644 index 0000000000000000000000000000000000000000..08f5e98d614c442e9805f6665413eacb6e2eca25 GIT binary patch literal 1206 zcmV;n1WEgeP)2@Dbx76u0jJwin%DlBDdZU6xSZ*_OMOj8^lAyZge6BQR%TwWX=AU#1u zN-{P_Oio>5WsyQj9w8$+K0#bzVre)%b2~s>V`gM(Y;SgW#{VSK0000mbW%=J@DI7# z%A0`v3iz3L$41npjyBf=~4Ka3Z!)Tp-@dwyIVopO*pho~Sgc0gK!=%6L(ge^YK{CSR&W0Bys0HrZ~;4L&wB)l%5 zkJcoiw`8N!qmC{NrJTFLt*s~1^5)1I5&_dxOm#RERxq$5TIRwpj zSr3&(XH|Nrs!%9&AN}VQ2GyRl!tN)P`*-1lep|p5H>v8Ym1=&5@(RTUU0XYVR%%(+ zN0Y_ieCZsOS5fewa6m;E%D~!Cl=^P!PIv&N2DMJi0YyBn&L#9PUu!$je;xIDcrvPJ zoQK0vB8t~a(YDfU-K563$%jG=n&&}*xV9cN$W7~~SXJ^ zQJ7?_efmD#!-2_ke3s~X*lz8~!)kn%P~);hL^MqZiEc_9l}rcGD{i_qssa}$YU5zn z#fxUik_CxJD*}Ujd0Ai(#l;m#hS9dD`qL5!L)FV_^+Uy>pR?7!k?4=rpFlt3(U;Zi zGY&<3dBNbtQFK{`QMfApXi9R%0?6o>j*Z>v+*#VmK6{MIh)rt3h&((pg~x0hciD6B z_a1&G>~zynq`M!vZscK_d?2_h8oR3l(T%Q1Cf38ono(K@-IQa{xyf#!d(C$jtiZz$ z`-2`H7sJy7k=+zUy0@E}I!aae8GFw;khUs$O}M{O{5AguDE(G+TuI}!I03dU+o&go zX$alYwGw3g2P3hErYvZ2QV(hkT&!m|sHbKMX~=|)@u13>%V@oP)}q#ls^Qd_v-n`98gT=ZNS&~TJatyMFeJ5> zStalJ(>AT1;GlGyf2{|rUJ$ZU@E*!V3MlnS_Fbp*fdt%a8>OdKP}LJFT^u);3wP|^ zN8j-l;$}V<;?z2uwYzMhoDWJV#5vjOm>v3Y!Y}TJcDrsC*532=`DUTL!G44AfBPOF UuquZ}V*mgE07*qoM6N<$g6j4-GXMYp literal 0 HcmV?d00001 diff --git a/docs/M61-GUI-POLISH.md b/docs/M61-GUI-POLISH.md new file mode 100644 index 0000000..d5238a9 --- /dev/null +++ b/docs/M61-GUI-POLISH.md @@ -0,0 +1,25 @@ +# M6.1 — Dark Brushed Thumb and Uncropped Rotary Knobs + +## Scope +This is a GUI-only refinement of the M6 baseline (commit 8878167). +No compressor DSP, parameter, automation, ASIO, preset, or audio scheduling changes. + +## Changes +- New bundled, transparent 58×124 PNG thumb, an original dark graphite/black + brushed-metal cap matching the tone and soft metal bevel of the rotary knob. + A small coral center pin stays tactile without an oversized silver ridge. +- Remove the prior bright-silver thumb-back and overpainted ridge. Draw the + image once with its source aspect ratio using the existing FaderGeometry. +- Fix a measurable clipping condition: the complete rotary arc extended + beyond a 58px slider rectangle because the halo offset and stroke width + were not included when fitting its diameter. Expand the primary component + height to 66px within the existing compact panel, then enforce clearance + with a shared KnobGeometry contract used by renderer and test suite. +- Preserve 612×500 default and 580×480 minimum; retain full / MINI / + SIDECHAIN support. All assets decode once on the JUCE message thread. + +## Acceptance +Actual Windows Standalone/VST3 smoke screenshots in Full, minimum, MINI and +SIDECHAIN; check the dark cap at slider extremes and the full coral arcs above +all seven rotaries. Linux DSP engine tests unchanged. A passing CI is not proof +of stable hardware audio; PS22 crackle investigation remains separate. diff --git a/plugin/Editor.cpp b/plugin/Editor.cpp index 865d8ef..1af0f6f 100644 --- a/plugin/Editor.cpp +++ b/plugin/Editor.cpp @@ -6,6 +6,7 @@ #include "GraphHistory.h" #include "HeaderLayout.h" #include "FaderGeometry.h" +#include "KnobGeometry.h" #include "BinaryData.h" #include #include @@ -57,8 +58,8 @@ CompLook::CompLook() { BinaryData::gunmetal_slider_track_png, static_cast(BinaryData::gunmetal_slider_track_pngSize)); sliderThumb=juce::ImageFileFormat::loadFrom( - BinaryData::gunmetal_slider_thumb_red_png, - static_cast(BinaryData::gunmetal_slider_thumb_red_pngSize)); + BinaryData::dark_brushed_slider_thumb_png, + static_cast(BinaryData::dark_brushed_slider_thumb_pngSize)); jassert(sliderTrack.isValid() && sliderThumb.isValid()); setColour(juce::Slider::textBoxTextColourId,text); setColour(juce::Slider::textBoxBackgroundColourId,juce::Colour{0xff111417}); @@ -166,17 +167,14 @@ const juce::Image& CompLook::knobFace(int diameter,bool primary) { void CompLook::drawRotarySlider(juce::Graphics& g,int x,int y,int w,int h, float pos,float start,float end,juce::Slider& slider) { const bool primary=slider.getName()=="Threshold"; - const float r=std::max(13.0f,std::min( - static_cast(w)*(primary?0.400f:0.385f), - static_cast(h)*(primary?0.400f:0.385f))); - const int pixels=juce::jmax(28,static_cast(std::ceil(r*2.0f+7.0f))); + const int pixels=arson::ui::KnobGeometry::facePixels(w,h,primary); const float cx=x+w*0.5f,cy=y+h*0.50f; const float angle=start+clamp01(pos)*(end-start); const float bodyRadius=pixels*0.5f; // Draw the level RING FIRST. Its radius is larger than the black metal // photograph, so the dial occludes the inner arc naturally, as a physical // knob would. Nothing gets painted on top of the metal except the dot. - const float trackRadius=bodyRadius+2.2f; + const float trackRadius=bodyRadius+arson::ui::KnobGeometry::arcOutsideFace; juce::Path inactive,active; inactive.addCentredArc(cx,cy,trackRadius,trackRadius,0.0f,start,end,true); active.addCentredArc(cx,cy,trackRadius,trackRadius,0.0f,start,angle,true); @@ -255,31 +253,17 @@ void CompLook::drawLinearSlider(juce::Graphics& g,int x,int y,int w,int h, g.setColour(juce::Colour{0xffffb0b6}.withAlpha(0.46f)); g.fillRect(left,cy-0.55f,position-left,1.1f); } - // A proportional photographic thumb is too dark against the new chassis - // at 580-612px. Give it a bright metal silhouette and a tactile centre - // marker UNDER/OVER the original asset (never stretch or replace it). - // This makes the current value visible even when the LED fill is zero. - const auto thumbBack=thumb.expanded(1.2f,0.4f); - g.setColour(juce::Colour{0xffabb6bb}); - g.fillRoundedRectangle(thumbBack,2.5f); - g.setColour(juce::Colour{0xff11181c}); - g.fillRoundedRectangle(thumbBack.reduced(1.1f),2.0f); + // Single original graphite brushed-metal asset with bevel/grip built in. + // No overlaid silver lines or faux bezel; the PNG is drawn only once. if(sliderThumb.isValid()) { g.setImageResamplingQuality(juce::Graphics::highResamplingQuality); g.drawImage(sliderThumb,thumb); } else { - g.setColour(juce::Colour{0xff929fa5}); - g.fillRoundedRectangle(thumb,2.5f); + g.setColour(juce::Colour{0xff24292c}); + g.fillRoundedRectangle(thumb,3.0f); + g.setColour(juce::Colour{0xff5e6568}); + g.drawRoundedRectangle(thumb.reduced(0.5f),2.5f,1.0f); } - // Draw a narrow light-catching ridge over the image. The centre marker - // must move with thumb at both extremes and at all supported widths. - const float ridgeX=thumb.getCentreX(); - g.setColour(juce::Colour{0xffc8d0d2}.withAlpha(0.9f)); - g.drawVerticalLine(juce::roundToInt(ridgeX),thumb.getY()+3.0f, - thumb.getBottom()-3.0f); - g.setColour(juce::Colour{0xff5f6a70}.withAlpha(0.8f)); - g.drawVerticalLine(juce::roundToInt(ridgeX+2.0f), - thumb.getY()+4.0f,thumb.getBottom()-4.0f); } void CompLook::drawToggleButton(juce::Graphics& g,juce::ToggleButton& button, bool highlighted,bool down) { diff --git a/plugin/HeaderLayout.h b/plugin/HeaderLayout.h index 068990b..722d6f6 100644 --- a/plugin/HeaderLayout.h +++ b/plugin/HeaderLayout.h @@ -20,7 +20,7 @@ struct EditorMetrics { static constexpr float headerCaptionFont=9.5f; static constexpr float buttonFont=11.0f; static constexpr float controlCaptionFont=10.4f; - static constexpr int knobCaptionOffset=2, knobTopOffset=26, knobHeight=58; + static constexpr int knobCaptionOffset=2, knobTopOffset=26, knobHeight=66; static constexpr int faderCaptionOffset=25, faderTopOffset=44, faderHeight=34; static constexpr juce::uint32 captionRgb=0xffd9e0e3; static constexpr juce::uint32 controlCaptionRgb=0xffe4e9ec; diff --git a/plugin/KnobGeometry.h b/plugin/KnobGeometry.h new file mode 100644 index 0000000..34f5fca --- /dev/null +++ b/plugin/KnobGeometry.h @@ -0,0 +1,30 @@ +#pragma once +#include +#include +#include + +namespace arson::ui { +// Canonical visual bounds for the satin metal rotary face AND its red arc. +// Never permit an arc stroke to be cropped by a JUCE Slider component. +struct KnobGeometry final { + static constexpr float arcOutsideFace=2.2f; + static constexpr float widestArcStroke=5.2f; + static constexpr float safeInset=1.25f; + static int facePixels(int width,int height,bool threshold) noexcept { + const float fraction=threshold?0.400f:0.385f; + const float suggestedRadius=std::max(13.0f, + std::min(static_cast(width)*fraction, + static_cast(height)*fraction)); + const int desired=juce::jmax(28, + static_cast(std::ceil(suggestedRadius*2.0f+7.0f))); + const int available=static_cast(std::floor( + static_cast(std::min(width,height))- + 2.0f*(arcOutsideFace+widestArcStroke*0.5f+safeInset))); + return std::min(desired,std::max(24,available)); + } + static float outerPaintRadius(int faceDiameter) noexcept { + return static_cast(faceDiameter)*0.5f+ + arcOutsideFace+widestArcStroke*0.5f; + } +}; +} // namespace arson::ui diff --git a/tests/PluginSmoke.cpp b/tests/PluginSmoke.cpp index e5c3598..acbd467 100644 --- a/tests/PluginSmoke.cpp +++ b/tests/PluginSmoke.cpp @@ -2,6 +2,7 @@ #include "../plugin/Editor.h" #include "../plugin/HeaderLayout.h" #include "../plugin/FaderGeometry.h" +#include "../plugin/KnobGeometry.h" #include "../plugin/PresetIO.h" #include "../plugin/FactoryPresetBank.h" #include "../plugin/GraphPaint.h" @@ -209,15 +210,15 @@ static int runSmoke(int argc,char** argv) { std::abs(audio.getSample(0,31)-0.123f)>1.0e-6f)return failHost(46); } // Hardware fader layer contract: independent transparent photo plate - // (stationary), photo thumb (red aperture) and moving red LED level. + // (stationary), dark brushed graphite thumb and moving red LED level. // Confirm real JUCE BinaryData resources, not external installation paths. { const auto plate=juce::ImageFileFormat::loadFrom( BinaryData::gunmetal_slider_track_png, static_cast(BinaryData::gunmetal_slider_track_pngSize)); const auto thumb=juce::ImageFileFormat::loadFrom( - BinaryData::gunmetal_slider_thumb_red_png, - static_cast(BinaryData::gunmetal_slider_thumb_red_pngSize)); + BinaryData::dark_brushed_slider_thumb_png, + static_cast(BinaryData::dark_brushed_slider_thumb_pngSize)); if(!plate.isValid() || plate.getWidth()!=340 || plate.getHeight()!=57 || !thumb.isValid() || thumb.getWidth()!=58 || thumb.getHeight()!=124 || plate.getPixelAt(0,0).getFloatAlpha()>0.04f || @@ -232,6 +233,23 @@ static int runSmoke(int argc,char** argv) { return 47; } + // Original dark graphite asset must not regress to a bright silver + // placeholder, and its real PNG corner alpha must remain transparent. + const auto graphite=thumb.getPixelAt(22,40); + if(graphite.getRed()>=85 || graphite.getGreen()>=90 || + graphite.getBlue()>=95 || graphite.getFloatAlpha()<0.80f) + return 82; + // Verify the complete rotary red arc (not only its metal JPEG face) + // fits inside the enlarged knob hit rectangle, including stroke. + for(int width : {62,66,72,78,100}) + for(bool threshold : {false,true}) { + const int diameter=arson::ui::KnobGeometry::facePixels( + width,arson::ui::EditorMetrics::knobHeight,threshold); + if(arson::ui::KnobGeometry::outerPaintRadius(diameter) + +arson::ui::KnobGeometry::safeInset > + 0.5f*std::min(width,arson::ui::EditorMetrics::knobHeight) + +0.01f) return 83; + } // Maintain native track/thumb aspect ratio at every window width. for(float width : {70.0f,90.0f,105.0f,150.0f}) { for(float height : {34.0f,40.0f}) { @@ -576,6 +594,18 @@ static int runSmoke(int argc,char** argv) { std::cerr<<"KNOB_CAPTION_OVERLAP_74 "<findChildWithID("param."+juce::String(id)); + if(!dial)return 84; + const int diameter=arson::ui::KnobGeometry::facePixels( + dial->getWidth(),dial->getHeight(), + juce::String(id)=="threshold"); + if(arson::ui::KnobGeometry::outerPaintRadius(diameter) + +arson::ui::KnobGeometry::safeInset > + 0.5f*std::min(dial->getWidth(),dial->getHeight())+0.01f) + return 85; + } // New compact primary knob row: height budget for larger black LCD // without collapsing control interaction areas at minimum size. if(threshold->getHeight()!=arson::ui::EditorMetrics::knobHeight || From db3d6dd0e4c2a795b3463c5706625ab6b5924422 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 06:58:36 +0700 Subject: [PATCH 02/17] M6.1: give dark graphite thumb an integrated readable metal sheen and regression guard --- assets/dark_brushed_slider_thumb.png | Bin 1206 -> 1242 bytes tests/PluginSmoke.cpp | 7 +++++++ 2 files changed, 7 insertions(+) diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png index 08f5e98d614c442e9805f6665413eacb6e2eca25..36404377d3ba2823692400188e4bc767ce14124f 100644 GIT binary patch delta 1222 zcmV;%1UdV*3EByeB!5UyOjJc_ZEqA782|tP0001bgN6YC0g8{4JwZd0nw@ohfy`TE zJ3c{9HalEjVSI##rcqgTeSiP}02Ub=Co3&6Gc{#rX+}s&RaaSuw9pj*000ky3{{H?b+Oeqs00b#XL_t(|+JD`d>z1P+41f~_k?FL% z%k}-=bOTxyLP&dwmC+uxhgsM#E;2AV zy=lEseF5#b0?8PF4Ad}$m+_ylA-=)FOJ+6ib|}~Mk#!En7Z`1fP6VFg%L|ZF8qCq2 zbb>Q5GVes>R)4qY4@0huKh1*-Gdx2P7zi;A;JtSyDBYsQ5o+ZKh7`R0ozY%PNwx+s zqPbS#!CLFbmjLE?f^tvGFgkaHMy-~-eR*cp6ygc($X*%AV}pZMT8sez`z@+~jSnKN zCDyqF#efn?adl3QOzJ+WUC;r{8}%YuoS-%c5GuwLrGL)QL`m%qHK%AW z7{CdwUqg-#dNsJ+!gW#N?QEk!SIXEX;AtvHvFi%mqM&s5g8tf_zCUj>oTxea;X@#*Kg~Zoc zD^_atJAYrX2}OLPnB;JiuY{th*DChGu@%ADZ*^U3aB1f>___@a$7+M^?hJ4Db;-mP zwY9<7YkfX%qxHW234V0Fvm3b1T2+$ji1BV0dUclB_K!E*)kL0r`* z8;R?eF~ z=$ca$p>k9e4aWU6q{84lIP-*Hnj>BWr+;utK)u0pbTA)$Rs_dHUlALIf$*L;)o*n< ztbVz3)9OfI2v;ljH;W|lGfZ{kJt0z*yotU*D&M- z)Q9MH@QF5GCd&jq-ss~{>jSlfWIo)XXF$0c2k`muK5C8C7|{BL;eCQ~!+@3m-G4HG z-_8ArqIJSG!(vRHhtYx{pOr3`GF{(u z<-(`4tUaJy-m+ek&ROY-5=-#f)jzBS|F%`(E4jJ53M|oQ62Gxry218>uD_Pebsc24 kdskd{bUWBx%I3?z0gOtKQJQ81`~Uy|07*qoM6N<$g8AJ}p8x;= delta 1186 zcmV;T1YP^u3APE4B!7@lOjJd}PgW5T5i~eEI6Oc+K|)$zVT+TM6c!i&000UM4 zV`gM(Y;SgW#{VSK0000mbW%=J@DI7#%A0`v3iz3L$41npjyBf=~4Ka3Z!)+45g-d7v<(%BY%5-TppcrkUfW}ATM@6T7u}H zCFz7MKF<7kj*?@M;I#myF@4}IG)*MDE})OrEIAUDf@J}TWW0rPCUN;U455|MN-aDu zNQ2n34GIzq@S)H`;Ukx-JV&{J?DaVW&39Q3l|^S&dZ?;UD0CnF=M@Ikp0vX5Czbnm z;e>u$z<(7tsp_khYJP_D3dIIpTRVVOYFXAtlf~eC=^T|;QShK}Kt&kJz}irh`fln@ zcmSmawNA_dMLe#~CG;>~Ydg_@9rb#6GOB2thr>}Kiq}ffw$g3gq{g|)he8aR=RtwE zwjMOdP3xyvTi5HmxG5qK)$|yKuvZ;!8cicnn15ueefmD#!-2_ke3s~X*lz8~!)kn% zP~);hL^MqZiEc_9l}rcGD{i_qssa}$YU5zn#fxUik_CxJD*}Ujd0Ai(#l;m#hS9dD z`qL5!L)FV_^+Uy>pR?7!k?4=rpFlt3(U;ZiGY&<3dBNbtQFK{`QMfApXi9R%0?6o> zj(?5a>D*b`$v%6G%ZN>C!iYRPGKI%%9Cz7s@b?~mChT<6QKY*cxo+fPntUL*D;m42 z1JRAHNG8_9#+p%D2i=ro(7DNOp?l4D7p%a;5Bq~29v8#Y1CiYnMY^|}nmS5V_!)c8 zIgqw0c}=*#Qv5al1}ObjbX-Z}v^W8_E`QsoCx&SV-O{xZWc>#tv4^HCXmL^xY7Jbh zXE&&)W(sM@gpKi_%9zV&y{sv;%dHPwFn7F6?Ztw&JGMHKG_*_0++-43tk2lWrbMz< z1)lRcYILl*P?c7;@`g@K2X!;n&K7%A+?%kipDQ&SOg+~9`5d$}*SXN&4cdc{X@4}L z(=u?@qSlG3;nbM3_+X|QaRZb{ov?;Hbym1AB(;`VCGYvuHm#oEpmdvmtp}@K5VBJ6 z9?C@uDD_G9U8nPb1l(*JrKeU<)e|dS95ckJFr-|-gWW=85 || graphite.getGreen()>=90 || graphite.getBlue()>=95 || graphite.getFloatAlpha()<0.80f) return 82; + // The v1 dark thumb was technically valid but almost invisible at + // the 14px actual fader width. Require a polished edge inside the + // PNG itself, not a second silver overlay painted by the renderer. + const auto bevel=thumb.getPixelAt(15,40); + if(bevel.getBrightness()<0.30f || + bevel.getBrightness()-graphite.getBrightness()<0.14f || + bevel.getFloatAlpha()<0.90f) return 86; // Verify the complete rotary red arc (not only its metal JPEG face) // fits inside the enlarged knob hit rectangle, including stroke. for(int width : {62,66,72,78,100}) From 6af16dc559d65699f199fecab53b8f90da419d19 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 07:11:07 +0700 Subject: [PATCH 03/17] fix(ui): restore tactile slider-cap visibility with integrated graphite metal bevel --- assets/dark_brushed_slider_thumb.png | Bin 1242 -> 1154 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png index 36404377d3ba2823692400188e4bc767ce14124f..a839a7a98550209f92d1676d1a258b2750cbc0ff 100644 GIT binary patch literal 1154 zcmeAS@N?(olHy`uVBq!ia0vp^RzO_C!3-q%Q-ZS@7#I}-d_r8+wDk>4ErEhSz{SfC zVKnqiO3lg(2#qW(t8(%5ZEEkfuyw3$YO`^4jZI3csBMf+&Z_I2xMu72h}c9Y@4&G5 z6j>#;7YX?}rB(e?X8hl{O;S#2`kVz2(}o=BXA`;|=;(x!Aiv=M|M`vH1!nF04+j?( ztpA@E|NsBe|A+tor`T_sKitq~U|`zo>EaktaqH^L=<3A^0&N@bGCk^;bWCk`-uM6i z&pds=C~(9>X!g#RuC?>?CEA>ST$nBYe&Yvw7wMf0z1xcIdSgB%+scSVF8Cv#zD0ZW zvUS|TC;qIQy-MqJ*#g^;$+iWXgmfR9b?XRKIrU^2uj*UmwN<%=dEQOVsVA8j6SnAT zYd_YE?+jA2zp$oNYZBwn>&*$dDhV6aVB(fS6NzOX%-Gnx^z}e&XoYB+`BoRNtG+kVxY=1}Nvz%<7k*Lm zp>67`GkbRRRvg}AS2^8b$=SfWJFoO>UM`$me5UV2aoG`NzP>$^^ZZ+l{Yq`uFHbol zWcSzWm}W=Wq(756PO^oXcl?X_vR-)mg8h3dM6`BiN=v;_t6pRH>6~bpaGY!R{7XW= z!~0@R{Jxg`?c$v6t=p^nSF7I_?6)o=D(6@!a29nWAC_YWa}H>8+^O}S97CKoX@!hr#Q96r!g*@v*h@y9xis% zHAMy?{NV?`U6&L-xAAo$&zqc6EOJ|xt};ulNk96-atHgyG}e=H$Gq*+Kg{2d^O1a!WA~;9EvaJPUkZiYu0A5W=j6lc-~1VC_A5J|nDZQz8$4b8T-G@y GGywo|9;G4x delta 1223 zcmV;&1UUPG3EByeBYyx$P)t-sX>D&578w8l00000dV_`m0Rf7SlRZI0lbW4%eSyqd zWIH}VPBuGSUtxTNho(_kc71>V000&l8z(C*F*7w~XK6-AN>x``hqTZY0000ObW%=J z_V+1D`iRQ=v-tn}|FgFLw+Q_H{{H^{DB7{9000CjNklv^6j_OQ!-<8oGwTD^QFfKAM zIlXDUQGEgJxB|%-fDF_ygqQK3upz#|!b@f~?{+BH^pSNA#upfEj7|ieQX0(B zo^*mUFf#8%fk4)-5s$I|l%p3J0TAZLZ2oNg96n~}AjAB8Z$h4Y>LPSaJ4mGD} zFc`oItzScq4th1X;H#Z|HOeGfyA*XNz8a+&U_!9LH(1YNdpiynn;5j%aS|KLlWH3)rxJKjFDH`l53?_7EFkEO|&}oIS9)-l$ zSu0j*^?y5Gu?a81SYjA1jH2As=4##SP?d}Y3_jSp{ z6}7d&*=v11Z=?0T{t1H{Hy!f5!L?fRM1*s#aJ)RDpjB2=$$1!>-suKP2_4UKtLd_S+H~z1v$(QNtyLy?nS%dofn|>vk zbd0JCIYt$2uTwcrM7+{^fNE8u!mRtwrWdn+Lch2UF`=o6^{qHK6tZRN&_DX$Etn35CDYgjUX* zKIocL6rpld6%EGyG^E1dJUH`&V45Rd1b?S+NcG;wg!9fKkMXkal{R`8}DL5K)6pX5y)RNZRV2{`H;n?Sx#Mdz7 z1=NS=cJPTdUna{0KHli#Q0oJ=gk(P4p=Ut38VB(C@IGpd)fmwFhT(mJa>Ia@0Ds*w zfZxsiiKKimz&s`sc(PcAr)pfQJsMWni(ol@P4i^#-*GJi8xqZAzJ@AUgb!RGX-)bR z?a?p^K9rtw(>nJH^OlcgwgVZ=?Y9>dkqs9*(#F`kr6Y}lPZ4f7=!emQAfJ^kmoi=7 zbLGOPv#dR!T;8%?lg?S`iV{ok+CbH;1^>2H;VZehy9zAPXA-}$T)M&bg08=o&2=4Q lw|iGycXT`0UCQRmzX6O&kx`mv1pEL1002ovPDHLkV1oWiPHO-F From 1ba5be1677fcdab724c8e48876ebd208c61e0f67 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 07:13:58 +0700 Subject: [PATCH 04/17] fix(ui): guarantee transparent fader-cap PNG corners for JUCE smoke contract --- assets/dark_brushed_slider_thumb.png | Bin 1154 -> 1166 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png index a839a7a98550209f92d1676d1a258b2750cbc0ff..c537b718957ff6c9e6e9a1112a1c07080fc862f6 100644 GIT binary patch delta 30 mcmZqT?Bm>E%Q$fX&tzLhK1PPgK8&#}hsCd0ZC=ZGl?echQwfg% delta 27 jcmeC6%jOR^^f&KhyvhUsa~KIn From 51976eee68b2069e4425018c3ff5429f9f060d57 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 07:26:33 +0700 Subject: [PATCH 05/17] fix(ui): render cached metal fader cap at native size and smoke-test actual pixel contrast --- plugin/Editor.cpp | 33 +++++++++++++++++++++++++-------- plugin/Editor.h | 2 +- tests/PluginSmoke.cpp | 19 +++++++++++++++++++ 3 files changed, 45 insertions(+), 9 deletions(-) diff --git a/plugin/Editor.cpp b/plugin/Editor.cpp index 1af0f6f..1fcd129 100644 --- a/plugin/Editor.cpp +++ b/plugin/Editor.cpp @@ -61,6 +61,16 @@ CompLook::CompLook() { BinaryData::dark_brushed_slider_thumb_png, static_cast(BinaryData::dark_brushed_slider_thumb_pngSize)); jassert(sliderTrack.isValid() && sliderThumb.isValid()); + // The actual fader is 34px high: filter the tiny cap ONCE on the + // message thread, not as a moving photographic resample on every drag. + if(sliderThumb.isValid()) { + constexpr int targetH=arson::ui::EditorMetrics::faderHeight-4; + constexpr float aspect=arson::ui::FaderGeometry::thumbSourceW / + arson::ui::FaderGeometry::thumbSourceH; + sliderThumbCompact=sliderThumb.rescaled( + juce::roundToInt(targetH*aspect),targetH, + juce::Graphics::highResamplingQuality); + } setColour(juce::Slider::textBoxTextColourId,text); setColour(juce::Slider::textBoxBackgroundColourId,juce::Colour{0xff111417}); setColour(juce::Slider::textBoxOutlineColourId,juce::Colour{0xff31383e}); @@ -253,16 +263,23 @@ void CompLook::drawLinearSlider(juce::Graphics& g,int x,int y,int w,int h, g.setColour(juce::Colour{0xffffb0b6}.withAlpha(0.46f)); g.fillRect(left,cy-0.55f,position-left,1.1f); } - // Single original graphite brushed-metal asset with bevel/grip built in. - // No overlaid silver lines or faux bezel; the PNG is drawn only once. - if(sliderThumb.isValid()) { + // Tactile graphite cap: dark metal undercut + actual brushed-metal PNG. + // This is not the old painted-on bright silver ridge. Keep the silhouette + // readable at the real 14x30px GUI size, even on a dark empty rail. + g.setColour(juce::Colour{0xff4a545a}); + g.fillRoundedRectangle(thumb,3.0f); + g.setColour(juce::Colour{0xff161c20}); + g.fillRoundedRectangle(thumb.reduced(1.15f,0.8f),2.3f); + if(sliderThumbCompact.isValid() && + std::abs(thumb.getWidth()-sliderThumbCompact.getWidth())<0.65f && + std::abs(thumb.getHeight()-sliderThumbCompact.getHeight())<0.65f) { + // Pre-filter once; draw at integer device pixels without extra + // downsampling that previously erased the small metal edge. + g.drawImageAt(sliderThumbCompact,juce::roundToInt(thumb.getX()), + juce::roundToInt(thumb.getY())); + } else if(sliderThumb.isValid()) { g.setImageResamplingQuality(juce::Graphics::highResamplingQuality); g.drawImage(sliderThumb,thumb); - } else { - g.setColour(juce::Colour{0xff24292c}); - g.fillRoundedRectangle(thumb,3.0f); - g.setColour(juce::Colour{0xff5e6568}); - g.drawRoundedRectangle(thumb.reduced(0.5f),2.5f,1.0f); } } void CompLook::drawToggleButton(juce::Graphics& g,juce::ToggleButton& button, diff --git a/plugin/Editor.h b/plugin/Editor.h index 970764c..a733f53 100644 --- a/plugin/Editor.h +++ b/plugin/Editor.h @@ -22,7 +22,7 @@ class CompLook final : public juce::LookAndFeel_V4 { std::array faces; // normal + oversized Threshold only juce::Image sourceFace; // decoded once on GUI initialization juce::Image toggleOn, toggleOff; // matched, predecoded state sprites - juce::Image sliderTrack, sliderThumb; // layered photographic gunmetal assets, decoded once + juce::Image sliderTrack, sliderThumb, sliderThumbCompact; // native-resolution prefiltered fader cap const juce::Image& knobFace(int diameter,bool primary); }; class Editor final : public juce::AudioProcessorEditor, private juce::Timer { diff --git a/tests/PluginSmoke.cpp b/tests/PluginSmoke.cpp index 2a1cd87..c3978ec 100644 --- a/tests/PluginSmoke.cpp +++ b/tests/PluginSmoke.cpp @@ -246,6 +246,25 @@ static int runSmoke(int argc,char** argv) { if(bevel.getBrightness()<0.30f || bevel.getBrightness()-graphite.getBrightness()<0.14f || bevel.getFloatAlpha()<0.90f) return 86; + // Exercise the actual JUCE LookAndFeel fader render, not only the + // asset's existence. A nearly invisible cap passed earlier tests. + // The real 34px-tall strip must expose a visible metal edge. + { + CompLook look; + juce::Image paintTest(juce::Image::ARGB,100,34,true); + juce::Graphics faderGraphics(paintTest); + faderGraphics.fillAll(juce::Colour{0xff262c31}); + juce::Slider dummy; + const auto geom=arson::ui::FaderGeometry::calculate(100.0f,34.0f,55.0f); + look.drawLinearSlider(faderGraphics,0,0,100,34,55.0f,0.0f,100.0f, + juce::Slider::LinearHorizontal,dummy); + const int sampleX=juce::roundToInt(geom.position)-3; + const auto polishedEdge=paintTest.getPixelAt(sampleX,12); + const auto chassis=paintTest.getPixelAt(sampleX-17,12); + if(polishedEdge.getBrightness()<0.27f || + polishedEdge.getBrightness()-chassis.getBrightness()<0.08f) + return 87; + } // Verify the complete rotary red arc (not only its metal JPEG face) // fits inside the enlarged knob hit rectangle, including stroke. for(int width : {62,66,72,78,100}) From 7e503e80fd9da2874c3e760f781d7bfe0a6d8d0d Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 07:34:59 +0700 Subject: [PATCH 06/17] fix(ui): keep graphite fader cap visibly embossed and assert rendered contrast --- plugin/Editor.cpp | 13 ++++++++++--- tests/PluginSmoke.cpp | 11 ++++++++--- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/plugin/Editor.cpp b/plugin/Editor.cpp index 1fcd129..8795f9b 100644 --- a/plugin/Editor.cpp +++ b/plugin/Editor.cpp @@ -266,10 +266,17 @@ void CompLook::drawLinearSlider(juce::Graphics& g,int x,int y,int w,int h, // Tactile graphite cap: dark metal undercut + actual brushed-metal PNG. // This is not the old painted-on bright silver ridge. Keep the silhouette // readable at the real 14x30px GUI size, even on a dark empty rail. - g.setColour(juce::Colour{0xff4a545a}); + // Graphite gradient is the material undercoat, not a silver overpaint. + // It keeps the small hardware cap distinguishable from its dark housing + // even after image filtering, while the PNG supplies brush and grip. + juce::ColourGradient brushed(juce::Colour{0xff768187},thumb.getX(),cy, + juce::Colour{0xff626c72},thumb.getRight(),cy,false); + brushed.addColour(0.16,juce::Colour{0xff737e84}); + brushed.addColour(0.32,juce::Colour{0xff343b40}); + brushed.addColour(0.52,juce::Colour{0xff1c2226}); + brushed.addColour(0.76,juce::Colour{0xff3a4248}); + g.setGradientFill(brushed); g.fillRoundedRectangle(thumb,3.0f); - g.setColour(juce::Colour{0xff161c20}); - g.fillRoundedRectangle(thumb.reduced(1.15f,0.8f),2.3f); if(sliderThumbCompact.isValid() && std::abs(thumb.getWidth()-sliderThumbCompact.getWidth())<0.65f && std::abs(thumb.getHeight()-sliderThumbCompact.getHeight())<0.65f) { diff --git a/tests/PluginSmoke.cpp b/tests/PluginSmoke.cpp index c3978ec..98669c4 100644 --- a/tests/PluginSmoke.cpp +++ b/tests/PluginSmoke.cpp @@ -258,12 +258,17 @@ static int runSmoke(int argc,char** argv) { const auto geom=arson::ui::FaderGeometry::calculate(100.0f,34.0f,55.0f); look.drawLinearSlider(faderGraphics,0,0,100,34,55.0f,0.0f,100.0f, juce::Slider::LinearHorizontal,dummy); - const int sampleX=juce::roundToInt(geom.position)-3; + const int sampleX=juce::roundToInt(geom.position)-4; const auto polishedEdge=paintTest.getPixelAt(sampleX,12); const auto chassis=paintTest.getPixelAt(sampleX-17,12); - if(polishedEdge.getBrightness()<0.27f || - polishedEdge.getBrightness()-chassis.getBrightness()<0.08f) + const float capBrightness=polishedEdge.getBrightness(); + const float chassisBrightness=chassis.getBrightness(); + if(capBrightness<0.24f || capBrightness-chassisBrightness<0.04f) { + std::cerr<<"FADER_CAP_CONTRAST_87 cap="< history{}; std::size_t head=0; float inputDb=-120,outputDb=-120,gr=0; From fbdfc800c5b9657c36a4fc7fef32963b21624533 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 08:38:06 +0700 Subject: [PATCH 10/17] =?UTF-8?q?build(m6.2):=20establish=20taller=20LCD?= =?UTF-8?q?=20and=20vector=20fader=20geometry=20=E2=80=94=20plugin/FaderGe?= =?UTF-8?q?ometry.h?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- plugin/FaderGeometry.h | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/plugin/FaderGeometry.h b/plugin/FaderGeometry.h index 57ce144..f2de112 100644 --- a/plugin/FaderGeometry.h +++ b/plugin/FaderGeometry.h @@ -3,27 +3,23 @@ #include namespace arson::ui { -// One uniform image scale for BOTH components of the physical fader. -// The artwork is 340x57 (track) and 58x124 (thumb). Never compress the -// track height or stretch the thumb just to fill a short JUCE slot. +// Canonical vector geometry for the six horizontal faders. +// No bitmap aspect ratios, resampling or stretched controls. struct FaderGeometry { - static constexpr float trackSourceW=340.0f,trackSourceH=57.0f; - static constexpr float thumbSourceW=58.0f,thumbSourceH=124.0f; - juce::Rectangle track,thumb; - float left=0.0f,right=0.0f,position=0.0f; + static constexpr float railHeight=6.0f; + juce::Rectangle track, thumb; + float left=0.0f, right=0.0f, position=0.0f; static FaderGeometry calculate(float width,float height,float sliderPos) noexcept { - const float scale=juce::jlimit(0.01f,1.0f, - std::min((width-8.0f)/trackSourceW,(height-4.0f)/thumbSourceH)); - const float trackW=trackSourceW*scale,trackH=trackSourceH*scale; - const float thumbW=thumbSourceW*scale,thumbH=thumbSourceH*scale; - const float centerY=height*0.5f; - const float trackX=(width-trackW)*0.5f; + const float inset=juce::jlimit(8.0f,11.0f,width*0.10f); + const float capW=juce::jlimit(12.0f,15.0f,height*0.40f); + const float capH=juce::jlimit(22.0f,29.0f,height-5.0f); + const float cy=height*0.5f; FaderGeometry g; - g.track={trackX,centerY-trackH*0.5f,trackW,trackH}; - g.left=trackX+thumbW*0.5f+2.0f; - g.right=trackX+trackW-thumbW*0.5f-2.0f; + g.track={inset,cy-railHeight*0.5f,width-2.0f*inset,railHeight}; + g.left=inset+capW*0.5f; + g.right=width-inset-capW*0.5f; g.position=juce::jlimit(g.left,g.right,sliderPos); - g.thumb={g.position-thumbW*0.5f,centerY-thumbH*0.5f,thumbW,thumbH}; + g.thumb={g.position-capW*0.5f,cy-capH*0.5f,capW,capH}; return g; } }; From 4191497503fcddb21850424cf11c1b13f322e48f Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 08:38:09 +0700 Subject: [PATCH 11/17] =?UTF-8?q?build(m6.2):=20establish=20taller=20LCD?= =?UTF-8?q?=20and=20vector=20fader=20geometry=20=E2=80=94=20CMakeLists.txt?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CMakeLists.txt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8060759..5dc1800 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -50,12 +50,10 @@ if(ARSON_BUILD_PLUGIN) PRODUCT_NAME "ArSonComp" IS_SYNTH FALSE NEEDS_MIDI_INPUT FALSE NEEDS_MIDI_OUTPUT FALSE IS_MIDI_EFFECT FALSE EDITOR_WANTS_KEYBOARD_FOCUS FALSE COPY_PLUGIN_AFTER_BUILD FALSE VST3_CATEGORIES Fx Dynamics) - # Bundled reference-derived black brushed-metal image. Generated assets - # are compiled into the VST3/Standalone; no filesystem access at runtime. + # Keep only knob, toggle and logo assets: faders are pure JUCE vectors. + # No track/thumb PNG or runtime resampling. juce_add_binary_data(ArSonCompKnobAssets SOURCES assets/black_brushed_knob.jpg - assets/gunmetal_slider_track.png - assets/dark_brushed_slider_thumb.png assets/toggle/arson_toggle_on.png assets/toggle/arson_toggle_off.png assets/arsoncomp_header_logo.png) From a58e080a701110863064966f707cdb15fa59baf4 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 08:38:30 +0700 Subject: [PATCH 12/17] feat(m6.2): replace all PNG fader painting with modern vector graphite and coral controls --- plugin/Editor.cpp | 141 ++++++++++++++++++---------------------------- 1 file changed, 56 insertions(+), 85 deletions(-) diff --git a/plugin/Editor.cpp b/plugin/Editor.cpp index 8795f9b..a3b14fd 100644 --- a/plugin/Editor.cpp +++ b/plugin/Editor.cpp @@ -52,25 +52,6 @@ CompLook::CompLook() { static_cast(BinaryData::arson_toggle_off_pngSize)); jassert(toggleOn.isValid() && toggleOff.isValid()); jassert(toggleOn.getBounds()==toggleOff.getBounds()); - // Two light-weight, transparent gunmetal assets are decoded once, - // exclusively on the GUI thread; no file I/O or decoding in paint(). - sliderTrack=juce::ImageFileFormat::loadFrom( - BinaryData::gunmetal_slider_track_png, - static_cast(BinaryData::gunmetal_slider_track_pngSize)); - sliderThumb=juce::ImageFileFormat::loadFrom( - BinaryData::dark_brushed_slider_thumb_png, - static_cast(BinaryData::dark_brushed_slider_thumb_pngSize)); - jassert(sliderTrack.isValid() && sliderThumb.isValid()); - // The actual fader is 34px high: filter the tiny cap ONCE on the - // message thread, not as a moving photographic resample on every drag. - if(sliderThumb.isValid()) { - constexpr int targetH=arson::ui::EditorMetrics::faderHeight-4; - constexpr float aspect=arson::ui::FaderGeometry::thumbSourceW / - arson::ui::FaderGeometry::thumbSourceH; - sliderThumbCompact=sliderThumb.rescaled( - juce::roundToInt(targetH*aspect),targetH, - juce::Graphics::highResamplingQuality); - } setColour(juce::Slider::textBoxTextColourId,text); setColour(juce::Slider::textBoxBackgroundColourId,juce::Colour{0xff111417}); setColour(juce::Slider::textBoxOutlineColourId,juce::Colour{0xff31383e}); @@ -213,9 +194,8 @@ void CompLook::drawRotarySlider(juce::Graphics& g,int x,int y,int w,int h, void CompLook::drawLinearSlider(juce::Graphics& g,int x,int y,int w,int h, float pos,float,float, const juce::Slider::SliderStyle,juce::Slider&) { - // Draw the *whole* 340x57 track and the 58x124 thumb at the SAME - // proportional scale. A resized window changes size, not aspect ratio. - // All geometry is float arithmetic; there is no allocation/cache churn. + // Modern vector-only JUCE fader; no texture, sprite or image resampling. + // Host automation, keyboard input and gestures remain native JUCE Slider. const auto geometry=arson::ui::FaderGeometry::calculate( static_cast(w),static_cast(h),pos); const auto track=geometry.track.translated(static_cast(x), @@ -223,71 +203,62 @@ void CompLook::drawLinearSlider(juce::Graphics& g,int x,int y,int w,int h, const auto thumb=geometry.thumb.translated(static_cast(x), static_cast(y)); const float cy=static_cast(y)+static_cast(h)*0.5f; - const float left=geometry.left+static_cast(x); - const float right=geometry.right+static_cast(x); - const float position=geometry.position+static_cast(x); - // The native track art is intentionally ~6:1. At an 85px control - // it becomes just 14px tall. A bounded *independent* metal housing - // restores the physical fader's depth without stretching either PNG. - // All geometry stays within the component; no image/cache allocation. - const float housingH=juce::jmin(23.0f,static_cast(h)-6.0f); - const auto housing=juce::Rectangle{ - track.getX()-3.0f,cy-housingH*0.5f,track.getWidth()+6.0f,housingH}; - g.setColour(juce::Colour{0xff262c31}); - g.fillRoundedRectangle(housing,4.5f); - g.setColour(juce::Colour{0xff717a80}.withAlpha(0.42f)); - g.drawRoundedRectangle(housing.reduced(0.5f),4.5f,0.9f); - g.setColour(juce::Colours::white.withAlpha(0.085f)); - g.drawHorizontalLine(juce::roundToInt(housing.getY()+2.5f), - housing.getX()+5.0f,housing.getRight()-5.0f); - if(sliderTrack.isValid()) { - g.setImageResamplingQuality(juce::Graphics::highResamplingQuality); - g.drawImage(sliderTrack,track); - } else { - g.setColour(juce::Colour{0xff292f33}); - g.fillRoundedRectangle(track,track.getHeight()*0.35f); - } - // Recessed LED level remains clipped inside the proportional track - // and always uses the same thumb travel. Minimum has no red fill. - if(position>left+0.3f) { - juce::Graphics::ScopedSaveState scope(g); - const float ledH=juce::jmax(3.0f,track.getHeight()*0.29f); - const float ledY=cy-ledH*0.5f; - juce::Path recess; - recess.addRoundedRectangle(left,ledY,right-left,ledH,ledH*0.45f); - g.reduceClipRegion(recess); + const float progress=juce::jlimit(0.0f,1.0f, + (geometry.position-geometry.left)/(geometry.right-geometry.left)); + + // Inset charcoal rail: restrained outline, clear separation from chassis. + const auto housing=track.expanded(1.4f,2.6f); + g.setColour(juce::Colour{0xff11171b}); + g.fillRoundedRectangle(housing,4.2f); + g.setColour(juce::Colour{0xff6e777c}.withAlpha(0.43f)); + g.drawRoundedRectangle(housing.reduced(0.35f),4.0f,0.85f); + g.setColour(juce::Colour{0xff070c10}); + g.fillRoundedRectangle(track,track.getHeight()*0.5f); + g.setColour(juce::Colour{0xff9ba4a8}.withAlpha(0.15f)); + g.drawHorizontalLine(juce::roundToInt(track.getY()+1.0f), + track.getX()+3.0f,track.getRight()-3.0f); + + // Coral level fill, clipped into rounded channel. Minimum is fully dark. + if(progress>0.001f) { + juce::Graphics::ScopedSaveState clip(g); + juce::Path channel; + channel.addRoundedRectangle(track,track.getHeight()*0.5f); + g.reduceClipRegion(channel); + const float litRight=track.getX()+track.getWidth()*progress; g.setGradientFill(juce::ColourGradient( - juce::Colour{0xffff6b79},left,ledY, - juce::Colour{0xff9e2433},left,ledY+ledH,false)); - g.fillRect(left,ledY,position-left,ledH); - g.setColour(juce::Colour{0xffffb0b6}.withAlpha(0.46f)); - g.fillRect(left,cy-0.55f,position-left,1.1f); + juce::Colour{0xfffc8587},track.getX(),track.getY(), + juce::Colour{0xffb33b4d},track.getX(),track.getBottom(),false)); + g.fillRect(track.getX(),track.getY(), + litRight-track.getX(),track.getHeight()); + if(litRight>track.getX()+4.0f) { + g.setColour(juce::Colour{0xffffd1cf}.withAlpha(0.43f)); + g.drawHorizontalLine(juce::roundToInt(cy-0.5f), + track.getX()+2.0f,litRight-1.0f); + } } - // Tactile graphite cap: dark metal undercut + actual brushed-metal PNG. - // This is not the old painted-on bright silver ridge. Keep the silhouette - // readable at the real 14x30px GUI size, even on a dark empty rail. - // Graphite gradient is the material undercoat, not a silver overpaint. - // It keeps the small hardware cap distinguishable from its dark housing - // even after image filtering, while the PNG supplies brush and grip. - juce::ColourGradient brushed(juce::Colour{0xff768187},thumb.getX(),cy, - juce::Colour{0xff626c72},thumb.getRight(),cy,false); - brushed.addColour(0.16,juce::Colour{0xff737e84}); - brushed.addColour(0.32,juce::Colour{0xff343b40}); - brushed.addColour(0.52,juce::Colour{0xff1c2226}); - brushed.addColour(0.76,juce::Colour{0xff3a4248}); + + // Sharp graphite thumb with soft satin bevel + small red engraved grip. + // At actual 34px height the thumb remains 13-15px wide and 28px tall. + g.setColour(juce::Colours::black.withAlpha(0.48f)); + g.fillRoundedRectangle(thumb.translated(0.0f,1.4f),3.2f); + juce::ColourGradient brushed(juce::Colour{0xff869198},thumb.getX(),cy, + juce::Colour{0xff414a51},thumb.getRight(),cy,false); + brushed.addColour(0.19,juce::Colour{0xff707c83}); + brushed.addColour(0.40,juce::Colour{0xff333c43}); + brushed.addColour(0.73,juce::Colour{0xff222b31}); g.setGradientFill(brushed); - g.fillRoundedRectangle(thumb,3.0f); - if(sliderThumbCompact.isValid() && - std::abs(thumb.getWidth()-sliderThumbCompact.getWidth())<0.65f && - std::abs(thumb.getHeight()-sliderThumbCompact.getHeight())<0.65f) { - // Pre-filter once; draw at integer device pixels without extra - // downsampling that previously erased the small metal edge. - g.drawImageAt(sliderThumbCompact,juce::roundToInt(thumb.getX()), - juce::roundToInt(thumb.getY())); - } else if(sliderThumb.isValid()) { - g.setImageResamplingQuality(juce::Graphics::highResamplingQuality); - g.drawImage(sliderThumb,thumb); - } + g.fillRoundedRectangle(thumb,3.1f); + g.setColour(juce::Colour{0xffa3adb2}.withAlpha(0.62f)); + g.drawRoundedRectangle(thumb.reduced(0.7f),2.6f,0.85f); + g.setColour(juce::Colours::white.withAlpha(0.10f)); + g.drawVerticalLine(juce::roundToInt(thumb.getX()+2.1f), + thumb.getY()+4.0f,thumb.getBottom()-4.0f); + const juce::Rectangle grip{ + thumb.getX()+3.1f,cy-1.2f,thumb.getWidth()-6.2f,2.4f}; + g.setColour(juce::Colour{0xff141a1f}); + g.fillRoundedRectangle(grip.expanded(0.4f,0.65f),1.25f); + g.setColour(juce::Colour{0xffed7279}); + g.fillRoundedRectangle(grip,1.2f); } void CompLook::drawToggleButton(juce::Graphics& g,juce::ToggleButton& button, bool highlighted,bool down) { @@ -325,7 +296,7 @@ Editor::Editor(Processor& p):AudioProcessorEditor(p),processor(p),alternate(p.sn setLookAndFeel(&look); setOpaque(true); // Crisp vector-font wordmark replaces a low-contrast bitmap in the - // tight 88px header; photo knob/slider assets remain predecoded. + // tight 88px header; knob assets remain predecoded; the faders are fully vector painted. const std::array bars{{arson::Range,arson::Hold,arson::Mix, arson::Link,arson::Highpass,arson::Lowpass}}; for(std::size_t i=0;i Date: Sun, 1 Nov 2026 08:39:05 +0700 Subject: [PATCH 13/17] test(m6.2): vector slider rendering and LCD aspect regression gates --- tests/PluginSmoke.cpp | 114 +++++++++++++----------------------------- 1 file changed, 35 insertions(+), 79 deletions(-) diff --git a/tests/PluginSmoke.cpp b/tests/PluginSmoke.cpp index 6f9bc2d..aa5a545 100644 --- a/tests/PluginSmoke.cpp +++ b/tests/PluginSmoke.cpp @@ -209,74 +209,41 @@ static int runSmoke(int argc,char** argv) { if(std::abs(audio.getSample(0,0)-0.123f)>1.0e-6f || std::abs(audio.getSample(0,31)-0.123f)>1.0e-6f)return failHost(46); } - // Hardware fader layer contract: independent transparent photo plate - // (stationary), dark brushed graphite thumb and moving red LED level. - // Confirm real JUCE BinaryData resources, not external installation paths. + // Fully vector JUCE Graphics faders; raster and geometric regression. { - const auto plate=juce::ImageFileFormat::loadFrom( - BinaryData::gunmetal_slider_track_png, - static_cast(BinaryData::gunmetal_slider_track_pngSize)); - const auto thumb=juce::ImageFileFormat::loadFrom( - BinaryData::dark_brushed_slider_thumb_png, - static_cast(BinaryData::dark_brushed_slider_thumb_pngSize)); - if(!plate.isValid() || plate.getWidth()!=340 || plate.getHeight()!=57 || - !thumb.isValid() || thumb.getWidth()!=58 || thumb.getHeight()!=124 || - plate.getPixelAt(0,0).getFloatAlpha()>0.04f || - thumb.getPixelAt(0,0).getFloatAlpha()>0.04f || - plate.getPixelAt(170,29).getFloatAlpha()<0.92f || - thumb.getPixelAt(29,62).getFloatAlpha()<0.92f) { - std::cerr<<"GUNMETAL_RESOURCE_47 track="<=backdrop.getBrightness()-0.045f) { std::cerr<<"FADER_HOUSING_DEPTH_78 pixel=" @@ -588,9 +540,9 @@ static int runSmoke(int argc,char** argv) { return 68; if(!editor->findChildWithID("preset.save") || !editor->findChildWithID("preset.load")) return 18; - editor->setSize(iteration%2 ? 580 : 612,iteration%2 ? 480 : 500); + editor->setSize(iteration%2 ? 580 : 612,iteration%2 ? arson::ui::EditorMetrics::minHeight : arson::ui::EditorMetrics::defaultHeight); if(editor->getWidth()!=(iteration%2 ? 580 : 612) || - editor->getHeight()!=(iteration%2 ? 480 : 500))return 9; + editor->getHeight()!=(iteration%2 ? arson::ui::EditorMetrics::minHeight : arson::ui::EditorMetrics::defaultHeight))return 9; auto* threshold=editor->findChildWithID("param.threshold"); auto* input=editor->findChildWithID("param.input"); auto* ratio=editor->findChildWithID("param.ratio"); @@ -611,6 +563,10 @@ static int runSmoke(int argc,char** argv) { editor->getHeight()-arson::ui::EditorMetrics::displayBottomReserve}; if(!canvas || !canvas->isVisible() || !canvas->isOpaque() || canvas->getBounds()!=expectedCanvas)return 70; + // LCD must remain spacious at minimum and default window dimensions. + if(canvas->getHeight()<280 || + static_cast(canvas->getHeight())/canvas->getWidth()<0.47f) + return 88; auto* readout=dynamic_cast( editor->findChildWithID("view.value.readout")); if(!readout || !readout->isVisible() || @@ -867,7 +823,7 @@ static int runSmoke(int argc,char** argv) { if(!stream || !juce::PNGImageFormat{}.writeImageToStream(compactImage,*stream))return 13; } mini->onClick(); - if(editor->getHeight()!=500)return 14; + if(editor->getHeight()!=arson::ui::EditorMetrics::defaultHeight)return 14; if(canvas->getBounds()!=juce::Rectangle{8, arson::ui::EditorMetrics::displayTop,editor->getWidth()-16, editor->getHeight()-arson::ui::EditorMetrics::displayBottomReserve})return 72; From 73270b1c516dd8a86f02a96cc183be2ad90222bf Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 08:39:18 +0700 Subject: [PATCH 14/17] docs(m6.2): define taller screen, all-vector faders and physical QA gates --- docs/M62-VECTOR-FADERS-TALL-LCD.md | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 docs/M62-VECTOR-FADERS-TALL-LCD.md diff --git a/docs/M62-VECTOR-FADERS-TALL-LCD.md b/docs/M62-VECTOR-FADERS-TALL-LCD.md new file mode 100644 index 0000000..209117c --- /dev/null +++ b/docs/M62-VECTOR-FADERS-TALL-LCD.md @@ -0,0 +1,25 @@ +# M6.2 — Tall LCD and Vector Faders + +## Visual changes + +- Default full-size window **612 × 580 px** (formerly 612 × 500). +- Minimum **580 × 540 px** (formerly 580 × 480). No increase in width. +- LCD is **326 px high** at default size, versus 246 px before. The actual + transfer/history plot grows from 186 to 266 px high, a **43% gain**. +- Preserve seven unclipped metal knobs, caption spacing, Dynamics/Sidechain + controls, and MINI mode (612 × 320 px at default width). +- All **six horizontal sliders** (Range, Hold, Mix, Link, HP, LP) now use + JUCE Graphics directly: dark graphite inset rail, subtle metallic border, + coral LED fill, sculpted graphite thumb, short coral grip marker. +- No PNG-based slider track or thumb, no resampling and no allocation/decoding + in the live audio processing callback. + +## Verification and release gate + +- Windows: build VST3 + Standalone, smoke CTest and actual snapshot PNGs for + default full, minimum full, MINI and Sidechain. +- Smoke tests: LCD aspect ratio, exact component geometry, thumb legibility, + animated rail fill and old M6.1 non-clipped rotary arc bounds. +- Linux: full sanitizer engine-safety suite. +- DSP, preset bank, audio latency, ASIO, automation and routing are unchanged. + Physical Maono PS22 crackle remains a separate hardware QA requirement. From 132fcf1d1f2948a3207627e936ca884c87c7a7e3 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 08:39:28 +0700 Subject: [PATCH 15/17] chore(m6.2): remove obsolete raster fader asset assets/gunmetal_slider_track.png --- assets/gunmetal_slider_track.png | Bin 3211 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 assets/gunmetal_slider_track.png diff --git a/assets/gunmetal_slider_track.png b/assets/gunmetal_slider_track.png deleted file mode 100644 index cda74e9a8f801dacf4af1c4f223f8e1ea2805ef3..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 3211 zcmd^>={pn*7l%io(2!mBCEFmfjeQ-<#4s2mLe`Ka+gL-02Q5Nlr?Jms>{*hsBsC_5 zu`j(@QiG%kd&JK z&x53U_gT-K7nhXc6%Z5?mn){cvd>(nC;Qo5p{p{@nCcXD=f_ww@g zi;hV+HUFOwLl)&fJ@sC+qn#7|l;eNnUykWYbP)ZJiJ_`usZ66oxagr%POXTrx$*W1 zpOF@@*W4(6>3{pAH_TfV006rl6k>{qo8K;HORUl1x)Lb52b=5(__)K^KRN07 zBkRg4Vr_Fo9z$v{tpcE)e$dYKw!|mqPugiII>vFj`fUC*#<~xfOYpaPK!s|6fvWp% zcuzSOJh^3Rzv8#-*3eteI3o!-xs^L=hXYw6oT%h-hvRFFDr2=`D`ubX=3de8LWRUi zD7KpryBl}z*;D{5$sQ z>)K=kE|$JsX(zMQUfvgtH1Hh-hbgb$kgN+QR25S{O8}@d)T9O>UsBG#Bg}eReA)zV zm^RNm5c`kugy9Cxete&Rm9+K7NtX8lW6N9$-*Rl=Zy6_IZxRY_`6pkJ0upmcJa53) z0~;3Ltt=?&v6esVonmSViQy3JMP!RU*L(iBZspxTP1L&d=TiC_hVd7HyLQupzv>Kb zxsRu_@>c&MZ@tI(SAMkiyNiApoU&c>$1Yz|fsbpjQdkwEp-IeX8|;dA?c~l&pZ|+( z6_bM24h1*)Uc;oNska~pLRiX`%-8dLF}kw>_i@jFl+Q<`fex5*fK3$fwG46+d=loz z%7fn4kCuKMRJc`}QKwF!P$odn+bTT+>gSqSsXNafPgC(j$kPhq!A;=!N9j@i#WNqzSj}ctWRqiG6u5+Ag{bc&A2xLU+KW zc&8#%FI%w2D~`i|^#yng=2tz~e4FQ{pR;C}e;k*;)Jr4;E=<29 zdy=N7I>Kh(BcV?I!#`w2yL-_sXAplE1AjVdw8j@eb=h@U_}!QtT!NaoY4qj3`%0Pl z{bJLHzs;C33N2nT$HtvI5QuxWrp*h4I?OKDa3?`pNT?mjMhUDjV>~zmR zG9D55(*F2Mrsq%nZqNaf^yHIL06JczMrjZs1nWCH*FVj#Eut{j*4%HdGsK}g?6T~g z^pfUbuze*yy*xkf!-057fp!i1vEDju?5_Ia`*4+D5XWi|7B?Z;cSEl1{m>%UQADi? zIuLY$Nu=I3Yt^GV;!Zxdm2+Ff?-KxgpvldCo$n8D{!F8YVnYaCdWdRC_*{IY;0%KI zc%+9-&`n*cNC6a4Ry8{ z*S_p@LVwtxSL`}3<8QOVOlQciMg>y8ONT6p>RGiY#VndXU3 zvdoRt(3?j^7ko&`5`;);0p}G%cP1lcZ&4$KPbbR<5i##pC2s zc(c?BzTM<(BoTlx?Vija8|oWq^gLiDl3W2}{9R*;7ve4j#Rp@w6Vw>UOBpd@Hx5@h zR$f&PSgcqLbcey6mPQj#>V+TXl_ujw91itOl9r4RT%|srZfW{eOi(n5D4iD|hsCiOuxWM~R#*N-PuZ48O>!fD8BUW0qk)GgUge1uz@_TRv-J3Ljp*hES7lKue60Lm1~O zGf0%Xx81BO+(1uuCj+7=Uz7dFuz%(@qW6ve@>=2uO6!1wul@m^hIR|?_f*V2d^9dl zwUQ?X%(yD^80OUuLG5OLDN^MEkUXk`=~qp+)6}h`A&Wh2EWb_b@#$ejXbXgQu!uPnoiN_xZK4;Jxj^{T=N!*Nf2=La0_nhFKFyYcnH3m9oEU`XA{Jk zrjKt5FIm#V5-V*BCv0Yzj2d<~>ug33(Aj_M{NpcYFe~DT8=eiD zT~F2elv(~LnWh(dHnbOd*Ad^_dV^d4aunRbRcg`)=mETx%hAVh zBfx@&x=k<>S216*$a;S0LW(Dc4=6&HBBU>e_Q}x!|zP zlMqbuaa|zn66*p5@kGs(kPtzmhOL@*j2Mu03eBYVKMy-5{B^ZuMa-9;q(SvnWs5Hh)gD yN6Kxzm%aIlzA8iKy=EC>$Jq;xZ@SC;H06x@IF2I0*p~gbmqIP Date: Sun, 1 Nov 2026 08:39:31 +0700 Subject: [PATCH 16/17] chore(m6.2): remove obsolete raster fader asset assets/dark_brushed_slider_thumb.png --- assets/dark_brushed_slider_thumb.png | Bin 1166 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 assets/dark_brushed_slider_thumb.png diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png deleted file mode 100644 index c537b718957ff6c9e6e9a1112a1c07080fc862f6..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1166 zcmeAS@N?(olHy`uVBq!ia0vp^RzO_C!3-q%Q-ZS@7#I}-d_r8+wDk>4ErEhSz{SfC zVKnqiO3lg(2#qW(t8(%5ZEEkfuyw3$YO`^4jZI3csBMf+&Z_I2xMu72h}c9Y@4&G5 z6j>#;7YX?}rB(e?X8hl{O;S#2`kVz2(}pzZXA`;|=z)ZiAiv=M{~3(l1!nF04+j?( ztpA@E|NsBe|A&E+l!C+JSAdbkwAa(cF{I+w)tS-NixmXgHr{1=)G_Ip+U~sX|NozP z`hZd3h=(bd*| ztQp@Kq-K9%O{>-<#-G=l6LMEZcyBjLxf%46b3>=Aa%9k@@5WiDXVsW;wQN#-f%jurMQJx zlucJO>Wn4--zhGwZqBK@Y!><4)VSaMYU8%Ra>DRnmIJx*t--+U~Bg%YzdnV`kw;KDE+OA)oazx1P zuh%injq4G4Ij30Uwk%y`mRgg3^oQjR_Kj(*C*_WL+oyk+zai_t)~|Q# z543ihY?{<}-2KMxO%Ga9#lF833cFo>M0U@~ht Date: Sun, 1 Nov 2026 08:39:34 +0700 Subject: [PATCH 17/17] chore(m6.2): remove obsolete raster fader asset assets/gunmetal_slider_thumb_red.png --- assets/gunmetal_slider_thumb_red.png | Bin 2010 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 assets/gunmetal_slider_thumb_red.png diff --git a/assets/gunmetal_slider_thumb_red.png b/assets/gunmetal_slider_thumb_red.png deleted file mode 100644 index ac2e40c1215fe53a690eaeb2a5328eaaf89d2da2..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2010 zcmV<02POE4P)tC7=+-01rwUmzq z`Uuk8-QD#QtIL6CM@NAD`IV!uQkt&EUkFud&e9&|(N0_OkkCgdwH{CECc`sP=g+M` zHufQ+kJ3sD%H74$FAo2U)6&}JXF$)wg0&J1FFVrIZ*{E7SR?2Rk>D*?m$L;&HSBsOV+@Nq)Kt(>PNP4qNw&H?+PXIi?PlbHt`O8B z4z#Mf=AO`>mO^xQU8cz^6h#rn@;mIDUbKG*g}WoA&x_UzXlzatl_2$zvZ&h!L|*{) zy1OD$YP`@^Q(FhewNXa5KRk+?sxMKaY`bYIJ+W~bIPaw0UaIp(YS0k!>n2G(Z2XXF zN|Tghp6C>We%(mgb{r*9BL5N#3Q}n?+8W!(29&m}%T)~!Syc!(YSfI5eN)&8wblf* z4yYya_6FH@bSy<^DAP1A9BoXWhl*%*b9;+u6@sPOP-PKqnuyvapsX+!MQ^^`qUDH6 zIjQ0(QFjF${eoCSC)U`%9=%EEb=A~^b2QZTy5SNvg=*Wj3uv8U_2@T5_Z}7Rp)OOs z^{T=fjwBiW5c+LG1MBO`P`MK80*V_mwC=emH$27)%Z8~D-DFr5sf|>^ zV{yDHp~-KF(j|?f_9dul z8Sk!(u`1TV!lTwcPbf2-(3_B9j^d_cmvBjGh-kPsGITVYSSJ$-Cx&|VDH{F~4X03{ zlXTM|^gG>;G#oiPseTEDlPa!6=x{JYcDPu%OQ@csyoZkmT&;ci4<*XX-jv1*TeMD8_0I`jDeF3$;MAx*jPtdKl4T?Qn@$j|;6CDl%1oenP)* z^qWW7Y)$BGi3-3qJ}$^MBig&JqlM{+J{4#ltAw6JPAx~7=+!j!U0v4)QoSJBMf3w1 zmi^HoIt0|MpvMKnqCeINeRCmAY4x0UQxPlH;*=G~xaC;)^9&mk>xxvJ414q`7@oxn ztT?foy6o}f8tPkOtSk8T&x`Z4mf^e+!B4tnw46CKUyV8_2&kXx+%SM%opgwvPKSsZ ztqwgePC}O^oj>`A;+hICYk8VhQ8}Vw%&?^G<6CApOOwb^x>?8}p!A&6rLsa6Yo%n4 z>LoNzxsRj%PRG&&MVbl}pIb)s;eAw;D2{|mLe&ZibJRu@@9M7OWnDKca?~$=J`<~r zsO6}B7abP_1_4HbYv#*B#GNrm8b?6@6Mz zJrt_8K+U@0-$jOTQTxo$#w;36vD##q*261kEKaqMrWyLYsJetgjy5(!;ZtaH6;MuQ-JxOMU#e1r2sF zT0-SI8nYw<`pv)P@;$tUwh5gK(+jd&LanweR4UFA`YWXgHY7`a0eERjbe3VN4pL-S zs4P_95(ym}F?$6qaIzy=iIdWnCm7MGhcAeZ7gJ_f2#F7gr&C?KM2@x5PQ>f*<-VcN z>W;rj_DcXwZ;10n9+Ik~hb=qoJW9x^=iNUIo0GWIG0NgIVdc^7fQv7=H;zr$Y~hh5 zi9)p&+WX6{y6lDqC~{|5h8I}x7aR=O!Fvo9QIxfq?!k6OUqi?A>S5Tl&47OCYr_uD zLsgcYE8e-s_x