From 84efa9ac56cdab61c4166654b60c66237345222e Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 06:44:41 +0700 Subject: [PATCH 1/7] M6.1: replace fader thumb with dark brushed-metal asset and fix clipped knob arcs --- CMakeLists.txt | 2 +- assets/dark_brushed_slider_thumb.png | Bin 0 -> 1206 bytes docs/M61-GUI-POLISH.md | 25 ++++++++++++++++++ plugin/Editor.cpp | 38 ++++++++------------------- plugin/HeaderLayout.h | 2 +- plugin/KnobGeometry.h | 30 +++++++++++++++++++++ tests/PluginSmoke.cpp | 36 ++++++++++++++++++++++--- 7 files changed, 101 insertions(+), 32 deletions(-) create mode 100644 assets/dark_brushed_slider_thumb.png create mode 100644 docs/M61-GUI-POLISH.md create mode 100644 plugin/KnobGeometry.h diff --git a/CMakeLists.txt b/CMakeLists.txt index 1dcfd84..8060759 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -55,7 +55,7 @@ if(ARSON_BUILD_PLUGIN) juce_add_binary_data(ArSonCompKnobAssets SOURCES assets/black_brushed_knob.jpg assets/gunmetal_slider_track.png - assets/gunmetal_slider_thumb_red.png + assets/dark_brushed_slider_thumb.png assets/toggle/arson_toggle_on.png assets/toggle/arson_toggle_off.png assets/arsoncomp_header_logo.png) diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png new file mode 100644 index 0000000000000000000000000000000000000000..08f5e98d614c442e9805f6665413eacb6e2eca25 GIT binary patch literal 1206 zcmV;n1WEgeP)2@Dbx76u0jJwin%DlBDdZU6xSZ*_OMOj8^lAyZge6BQR%TwWX=AU#1u zN-{P_Oio>5WsyQj9w8$+K0#bzVre)%b2~s>V`gM(Y;SgW#{VSK0000mbW%=J@DI7# z%A0`v3iz3L$41npjyBf=~4Ka3Z!)Tp-@dwyIVopO*pho~Sgc0gK!=%6L(ge^YK{CSR&W0Bys0HrZ~;4L&wB)l%5 zkJcoiw`8N!qmC{NrJTFLt*s~1^5)1I5&_dxOm#RERxq$5TIRwpj zSr3&(XH|Nrs!%9&AN}VQ2GyRl!tN)P`*-1lep|p5H>v8Ym1=&5@(RTUU0XYVR%%(+ zN0Y_ieCZsOS5fewa6m;E%D~!Cl=^P!PIv&N2DMJi0YyBn&L#9PUu!$je;xIDcrvPJ zoQK0vB8t~a(YDfU-K563$%jG=n&&}*xV9cN$W7~~SXJ^ zQJ7?_efmD#!-2_ke3s~X*lz8~!)kn%P~);hL^MqZiEc_9l}rcGD{i_qssa}$YU5zn z#fxUik_CxJD*}Ujd0Ai(#l;m#hS9dD`qL5!L)FV_^+Uy>pR?7!k?4=rpFlt3(U;Zi zGY&<3dBNbtQFK{`QMfApXi9R%0?6o>j*Z>v+*#VmK6{MIh)rt3h&((pg~x0hciD6B z_a1&G>~zynq`M!vZscK_d?2_h8oR3l(T%Q1Cf38ono(K@-IQa{xyf#!d(C$jtiZz$ z`-2`H7sJy7k=+zUy0@E}I!aae8GFw;khUs$O}M{O{5AguDE(G+TuI}!I03dU+o&go zX$alYwGw3g2P3hErYvZ2QV(hkT&!m|sHbKMX~=|)@u13>%V@oP)}q#ls^Qd_v-n`98gT=ZNS&~TJatyMFeJ5> zStalJ(>AT1;GlGyf2{|rUJ$ZU@E*!V3MlnS_Fbp*fdt%a8>OdKP}LJFT^u);3wP|^ zN8j-l;$}V<;?z2uwYzMhoDWJV#5vjOm>v3Y!Y}TJcDrsC*532=`DUTL!G44AfBPOF UuquZ}V*mgE07*qoM6N<$g6j4-GXMYp literal 0 HcmV?d00001 diff --git a/docs/M61-GUI-POLISH.md b/docs/M61-GUI-POLISH.md new file mode 100644 index 0000000..d5238a9 --- /dev/null +++ b/docs/M61-GUI-POLISH.md @@ -0,0 +1,25 @@ +# M6.1 — Dark Brushed Thumb and Uncropped Rotary Knobs + +## Scope +This is a GUI-only refinement of the M6 baseline (commit 8878167). +No compressor DSP, parameter, automation, ASIO, preset, or audio scheduling changes. + +## Changes +- New bundled, transparent 58×124 PNG thumb, an original dark graphite/black + brushed-metal cap matching the tone and soft metal bevel of the rotary knob. + A small coral center pin stays tactile without an oversized silver ridge. +- Remove the prior bright-silver thumb-back and overpainted ridge. Draw the + image once with its source aspect ratio using the existing FaderGeometry. +- Fix a measurable clipping condition: the complete rotary arc extended + beyond a 58px slider rectangle because the halo offset and stroke width + were not included when fitting its diameter. Expand the primary component + height to 66px within the existing compact panel, then enforce clearance + with a shared KnobGeometry contract used by renderer and test suite. +- Preserve 612×500 default and 580×480 minimum; retain full / MINI / + SIDECHAIN support. All assets decode once on the JUCE message thread. + +## Acceptance +Actual Windows Standalone/VST3 smoke screenshots in Full, minimum, MINI and +SIDECHAIN; check the dark cap at slider extremes and the full coral arcs above +all seven rotaries. Linux DSP engine tests unchanged. A passing CI is not proof +of stable hardware audio; PS22 crackle investigation remains separate. diff --git a/plugin/Editor.cpp b/plugin/Editor.cpp index 865d8ef..1af0f6f 100644 --- a/plugin/Editor.cpp +++ b/plugin/Editor.cpp @@ -6,6 +6,7 @@ #include "GraphHistory.h" #include "HeaderLayout.h" #include "FaderGeometry.h" +#include "KnobGeometry.h" #include "BinaryData.h" #include #include @@ -57,8 +58,8 @@ CompLook::CompLook() { BinaryData::gunmetal_slider_track_png, static_cast(BinaryData::gunmetal_slider_track_pngSize)); sliderThumb=juce::ImageFileFormat::loadFrom( - BinaryData::gunmetal_slider_thumb_red_png, - static_cast(BinaryData::gunmetal_slider_thumb_red_pngSize)); + BinaryData::dark_brushed_slider_thumb_png, + static_cast(BinaryData::dark_brushed_slider_thumb_pngSize)); jassert(sliderTrack.isValid() && sliderThumb.isValid()); setColour(juce::Slider::textBoxTextColourId,text); setColour(juce::Slider::textBoxBackgroundColourId,juce::Colour{0xff111417}); @@ -166,17 +167,14 @@ const juce::Image& CompLook::knobFace(int diameter,bool primary) { void CompLook::drawRotarySlider(juce::Graphics& g,int x,int y,int w,int h, float pos,float start,float end,juce::Slider& slider) { const bool primary=slider.getName()=="Threshold"; - const float r=std::max(13.0f,std::min( - static_cast(w)*(primary?0.400f:0.385f), - static_cast(h)*(primary?0.400f:0.385f))); - const int pixels=juce::jmax(28,static_cast(std::ceil(r*2.0f+7.0f))); + const int pixels=arson::ui::KnobGeometry::facePixels(w,h,primary); const float cx=x+w*0.5f,cy=y+h*0.50f; const float angle=start+clamp01(pos)*(end-start); const float bodyRadius=pixels*0.5f; // Draw the level RING FIRST. Its radius is larger than the black metal // photograph, so the dial occludes the inner arc naturally, as a physical // knob would. Nothing gets painted on top of the metal except the dot. - const float trackRadius=bodyRadius+2.2f; + const float trackRadius=bodyRadius+arson::ui::KnobGeometry::arcOutsideFace; juce::Path inactive,active; inactive.addCentredArc(cx,cy,trackRadius,trackRadius,0.0f,start,end,true); active.addCentredArc(cx,cy,trackRadius,trackRadius,0.0f,start,angle,true); @@ -255,31 +253,17 @@ void CompLook::drawLinearSlider(juce::Graphics& g,int x,int y,int w,int h, g.setColour(juce::Colour{0xffffb0b6}.withAlpha(0.46f)); g.fillRect(left,cy-0.55f,position-left,1.1f); } - // A proportional photographic thumb is too dark against the new chassis - // at 580-612px. Give it a bright metal silhouette and a tactile centre - // marker UNDER/OVER the original asset (never stretch or replace it). - // This makes the current value visible even when the LED fill is zero. - const auto thumbBack=thumb.expanded(1.2f,0.4f); - g.setColour(juce::Colour{0xffabb6bb}); - g.fillRoundedRectangle(thumbBack,2.5f); - g.setColour(juce::Colour{0xff11181c}); - g.fillRoundedRectangle(thumbBack.reduced(1.1f),2.0f); + // Single original graphite brushed-metal asset with bevel/grip built in. + // No overlaid silver lines or faux bezel; the PNG is drawn only once. if(sliderThumb.isValid()) { g.setImageResamplingQuality(juce::Graphics::highResamplingQuality); g.drawImage(sliderThumb,thumb); } else { - g.setColour(juce::Colour{0xff929fa5}); - g.fillRoundedRectangle(thumb,2.5f); + g.setColour(juce::Colour{0xff24292c}); + g.fillRoundedRectangle(thumb,3.0f); + g.setColour(juce::Colour{0xff5e6568}); + g.drawRoundedRectangle(thumb.reduced(0.5f),2.5f,1.0f); } - // Draw a narrow light-catching ridge over the image. The centre marker - // must move with thumb at both extremes and at all supported widths. - const float ridgeX=thumb.getCentreX(); - g.setColour(juce::Colour{0xffc8d0d2}.withAlpha(0.9f)); - g.drawVerticalLine(juce::roundToInt(ridgeX),thumb.getY()+3.0f, - thumb.getBottom()-3.0f); - g.setColour(juce::Colour{0xff5f6a70}.withAlpha(0.8f)); - g.drawVerticalLine(juce::roundToInt(ridgeX+2.0f), - thumb.getY()+4.0f,thumb.getBottom()-4.0f); } void CompLook::drawToggleButton(juce::Graphics& g,juce::ToggleButton& button, bool highlighted,bool down) { diff --git a/plugin/HeaderLayout.h b/plugin/HeaderLayout.h index 068990b..722d6f6 100644 --- a/plugin/HeaderLayout.h +++ b/plugin/HeaderLayout.h @@ -20,7 +20,7 @@ struct EditorMetrics { static constexpr float headerCaptionFont=9.5f; static constexpr float buttonFont=11.0f; static constexpr float controlCaptionFont=10.4f; - static constexpr int knobCaptionOffset=2, knobTopOffset=26, knobHeight=58; + static constexpr int knobCaptionOffset=2, knobTopOffset=26, knobHeight=66; static constexpr int faderCaptionOffset=25, faderTopOffset=44, faderHeight=34; static constexpr juce::uint32 captionRgb=0xffd9e0e3; static constexpr juce::uint32 controlCaptionRgb=0xffe4e9ec; diff --git a/plugin/KnobGeometry.h b/plugin/KnobGeometry.h new file mode 100644 index 0000000..34f5fca --- /dev/null +++ b/plugin/KnobGeometry.h @@ -0,0 +1,30 @@ +#pragma once +#include +#include +#include + +namespace arson::ui { +// Canonical visual bounds for the satin metal rotary face AND its red arc. +// Never permit an arc stroke to be cropped by a JUCE Slider component. +struct KnobGeometry final { + static constexpr float arcOutsideFace=2.2f; + static constexpr float widestArcStroke=5.2f; + static constexpr float safeInset=1.25f; + static int facePixels(int width,int height,bool threshold) noexcept { + const float fraction=threshold?0.400f:0.385f; + const float suggestedRadius=std::max(13.0f, + std::min(static_cast(width)*fraction, + static_cast(height)*fraction)); + const int desired=juce::jmax(28, + static_cast(std::ceil(suggestedRadius*2.0f+7.0f))); + const int available=static_cast(std::floor( + static_cast(std::min(width,height))- + 2.0f*(arcOutsideFace+widestArcStroke*0.5f+safeInset))); + return std::min(desired,std::max(24,available)); + } + static float outerPaintRadius(int faceDiameter) noexcept { + return static_cast(faceDiameter)*0.5f+ + arcOutsideFace+widestArcStroke*0.5f; + } +}; +} // namespace arson::ui diff --git a/tests/PluginSmoke.cpp b/tests/PluginSmoke.cpp index e5c3598..acbd467 100644 --- a/tests/PluginSmoke.cpp +++ b/tests/PluginSmoke.cpp @@ -2,6 +2,7 @@ #include "../plugin/Editor.h" #include "../plugin/HeaderLayout.h" #include "../plugin/FaderGeometry.h" +#include "../plugin/KnobGeometry.h" #include "../plugin/PresetIO.h" #include "../plugin/FactoryPresetBank.h" #include "../plugin/GraphPaint.h" @@ -209,15 +210,15 @@ static int runSmoke(int argc,char** argv) { std::abs(audio.getSample(0,31)-0.123f)>1.0e-6f)return failHost(46); } // Hardware fader layer contract: independent transparent photo plate - // (stationary), photo thumb (red aperture) and moving red LED level. + // (stationary), dark brushed graphite thumb and moving red LED level. // Confirm real JUCE BinaryData resources, not external installation paths. { const auto plate=juce::ImageFileFormat::loadFrom( BinaryData::gunmetal_slider_track_png, static_cast(BinaryData::gunmetal_slider_track_pngSize)); const auto thumb=juce::ImageFileFormat::loadFrom( - BinaryData::gunmetal_slider_thumb_red_png, - static_cast(BinaryData::gunmetal_slider_thumb_red_pngSize)); + BinaryData::dark_brushed_slider_thumb_png, + static_cast(BinaryData::dark_brushed_slider_thumb_pngSize)); if(!plate.isValid() || plate.getWidth()!=340 || plate.getHeight()!=57 || !thumb.isValid() || thumb.getWidth()!=58 || thumb.getHeight()!=124 || plate.getPixelAt(0,0).getFloatAlpha()>0.04f || @@ -232,6 +233,23 @@ static int runSmoke(int argc,char** argv) { return 47; } + // Original dark graphite asset must not regress to a bright silver + // placeholder, and its real PNG corner alpha must remain transparent. + const auto graphite=thumb.getPixelAt(22,40); + if(graphite.getRed()>=85 || graphite.getGreen()>=90 || + graphite.getBlue()>=95 || graphite.getFloatAlpha()<0.80f) + return 82; + // Verify the complete rotary red arc (not only its metal JPEG face) + // fits inside the enlarged knob hit rectangle, including stroke. + for(int width : {62,66,72,78,100}) + for(bool threshold : {false,true}) { + const int diameter=arson::ui::KnobGeometry::facePixels( + width,arson::ui::EditorMetrics::knobHeight,threshold); + if(arson::ui::KnobGeometry::outerPaintRadius(diameter) + +arson::ui::KnobGeometry::safeInset > + 0.5f*std::min(width,arson::ui::EditorMetrics::knobHeight) + +0.01f) return 83; + } // Maintain native track/thumb aspect ratio at every window width. for(float width : {70.0f,90.0f,105.0f,150.0f}) { for(float height : {34.0f,40.0f}) { @@ -576,6 +594,18 @@ static int runSmoke(int argc,char** argv) { std::cerr<<"KNOB_CAPTION_OVERLAP_74 "<findChildWithID("param."+juce::String(id)); + if(!dial)return 84; + const int diameter=arson::ui::KnobGeometry::facePixels( + dial->getWidth(),dial->getHeight(), + juce::String(id)=="threshold"); + if(arson::ui::KnobGeometry::outerPaintRadius(diameter) + +arson::ui::KnobGeometry::safeInset > + 0.5f*std::min(dial->getWidth(),dial->getHeight())+0.01f) + return 85; + } // New compact primary knob row: height budget for larger black LCD // without collapsing control interaction areas at minimum size. if(threshold->getHeight()!=arson::ui::EditorMetrics::knobHeight || From db3d6dd0e4c2a795b3463c5706625ab6b5924422 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 06:58:36 +0700 Subject: [PATCH 2/7] M6.1: give dark graphite thumb an integrated readable metal sheen and regression guard --- assets/dark_brushed_slider_thumb.png | Bin 1206 -> 1242 bytes tests/PluginSmoke.cpp | 7 +++++++ 2 files changed, 7 insertions(+) diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png index 08f5e98d614c442e9805f6665413eacb6e2eca25..36404377d3ba2823692400188e4bc767ce14124f 100644 GIT binary patch delta 1222 zcmV;%1UdV*3EByeB!5UyOjJc_ZEqA782|tP0001bgN6YC0g8{4JwZd0nw@ohfy`TE zJ3c{9HalEjVSI##rcqgTeSiP}02Ub=Co3&6Gc{#rX+}s&RaaSuw9pj*000ky3{{H?b+Oeqs00b#XL_t(|+JD`d>z1P+41f~_k?FL% z%k}-=bOTxyLP&dwmC+uxhgsM#E;2AV zy=lEseF5#b0?8PF4Ad}$m+_ylA-=)FOJ+6ib|}~Mk#!En7Z`1fP6VFg%L|ZF8qCq2 zbb>Q5GVes>R)4qY4@0huKh1*-Gdx2P7zi;A;JtSyDBYsQ5o+ZKh7`R0ozY%PNwx+s zqPbS#!CLFbmjLE?f^tvGFgkaHMy-~-eR*cp6ygc($X*%AV}pZMT8sez`z@+~jSnKN zCDyqF#efn?adl3QOzJ+WUC;r{8}%YuoS-%c5GuwLrGL)QL`m%qHK%AW z7{CdwUqg-#dNsJ+!gW#N?QEk!SIXEX;AtvHvFi%mqM&s5g8tf_zCUj>oTxea;X@#*Kg~Zoc zD^_atJAYrX2}OLPnB;JiuY{th*DChGu@%ADZ*^U3aB1f>___@a$7+M^?hJ4Db;-mP zwY9<7YkfX%qxHW234V0Fvm3b1T2+$ji1BV0dUclB_K!E*)kL0r`* z8;R?eF~ z=$ca$p>k9e4aWU6q{84lIP-*Hnj>BWr+;utK)u0pbTA)$Rs_dHUlALIf$*L;)o*n< ztbVz3)9OfI2v;ljH;W|lGfZ{kJt0z*yotU*D&M- z)Q9MH@QF5GCd&jq-ss~{>jSlfWIo)XXF$0c2k`muK5C8C7|{BL;eCQ~!+@3m-G4HG z-_8ArqIJSG!(vRHhtYx{pOr3`GF{(u z<-(`4tUaJy-m+ek&ROY-5=-#f)jzBS|F%`(E4jJ53M|oQ62Gxry218>uD_Pebsc24 kdskd{bUWBx%I3?z0gOtKQJQ81`~Uy|07*qoM6N<$g8AJ}p8x;= delta 1186 zcmV;T1YP^u3APE4B!7@lOjJd}PgW5T5i~eEI6Oc+K|)$zVT+TM6c!i&000UM4 zV`gM(Y;SgW#{VSK0000mbW%=J@DI7#%A0`v3iz3L$41npjyBf=~4Ka3Z!)+45g-d7v<(%BY%5-TppcrkUfW}ATM@6T7u}H zCFz7MKF<7kj*?@M;I#myF@4}IG)*MDE})OrEIAUDf@J}TWW0rPCUN;U455|MN-aDu zNQ2n34GIzq@S)H`;Ukx-JV&{J?DaVW&39Q3l|^S&dZ?;UD0CnF=M@Ikp0vX5Czbnm z;e>u$z<(7tsp_khYJP_D3dIIpTRVVOYFXAtlf~eC=^T|;QShK}Kt&kJz}irh`fln@ zcmSmawNA_dMLe#~CG;>~Ydg_@9rb#6GOB2thr>}Kiq}ffw$g3gq{g|)he8aR=RtwE zwjMOdP3xyvTi5HmxG5qK)$|yKuvZ;!8cicnn15ueefmD#!-2_ke3s~X*lz8~!)kn% zP~);hL^MqZiEc_9l}rcGD{i_qssa}$YU5zn#fxUik_CxJD*}Ujd0Ai(#l;m#hS9dD z`qL5!L)FV_^+Uy>pR?7!k?4=rpFlt3(U;ZiGY&<3dBNbtQFK{`QMfApXi9R%0?6o> zj(?5a>D*b`$v%6G%ZN>C!iYRPGKI%%9Cz7s@b?~mChT<6QKY*cxo+fPntUL*D;m42 z1JRAHNG8_9#+p%D2i=ro(7DNOp?l4D7p%a;5Bq~29v8#Y1CiYnMY^|}nmS5V_!)c8 zIgqw0c}=*#Qv5al1}ObjbX-Z}v^W8_E`QsoCx&SV-O{xZWc>#tv4^HCXmL^xY7Jbh zXE&&)W(sM@gpKi_%9zV&y{sv;%dHPwFn7F6?Ztw&JGMHKG_*_0++-43tk2lWrbMz< z1)lRcYILl*P?c7;@`g@K2X!;n&K7%A+?%kipDQ&SOg+~9`5d$}*SXN&4cdc{X@4}L z(=u?@qSlG3;nbM3_+X|QaRZb{ov?;Hbym1AB(;`VCGYvuHm#oEpmdvmtp}@K5VBJ6 z9?C@uDD_G9U8nPb1l(*JrKeU<)e|dS95ckJFr-|-gWW=85 || graphite.getGreen()>=90 || graphite.getBlue()>=95 || graphite.getFloatAlpha()<0.80f) return 82; + // The v1 dark thumb was technically valid but almost invisible at + // the 14px actual fader width. Require a polished edge inside the + // PNG itself, not a second silver overlay painted by the renderer. + const auto bevel=thumb.getPixelAt(15,40); + if(bevel.getBrightness()<0.30f || + bevel.getBrightness()-graphite.getBrightness()<0.14f || + bevel.getFloatAlpha()<0.90f) return 86; // Verify the complete rotary red arc (not only its metal JPEG face) // fits inside the enlarged knob hit rectangle, including stroke. for(int width : {62,66,72,78,100}) From 6af16dc559d65699f199fecab53b8f90da419d19 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 07:11:07 +0700 Subject: [PATCH 3/7] fix(ui): restore tactile slider-cap visibility with integrated graphite metal bevel --- assets/dark_brushed_slider_thumb.png | Bin 1242 -> 1154 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png index 36404377d3ba2823692400188e4bc767ce14124f..a839a7a98550209f92d1676d1a258b2750cbc0ff 100644 GIT binary patch literal 1154 zcmeAS@N?(olHy`uVBq!ia0vp^RzO_C!3-q%Q-ZS@7#I}-d_r8+wDk>4ErEhSz{SfC zVKnqiO3lg(2#qW(t8(%5ZEEkfuyw3$YO`^4jZI3csBMf+&Z_I2xMu72h}c9Y@4&G5 z6j>#;7YX?}rB(e?X8hl{O;S#2`kVz2(}o=BXA`;|=;(x!Aiv=M|M`vH1!nF04+j?( ztpA@E|NsBe|A+tor`T_sKitq~U|`zo>EaktaqH^L=<3A^0&N@bGCk^;bWCk`-uM6i z&pds=C~(9>X!g#RuC?>?CEA>ST$nBYe&Yvw7wMf0z1xcIdSgB%+scSVF8Cv#zD0ZW zvUS|TC;qIQy-MqJ*#g^;$+iWXgmfR9b?XRKIrU^2uj*UmwN<%=dEQOVsVA8j6SnAT zYd_YE?+jA2zp$oNYZBwn>&*$dDhV6aVB(fS6NzOX%-Gnx^z}e&XoYB+`BoRNtG+kVxY=1}Nvz%<7k*Lm zp>67`GkbRRRvg}AS2^8b$=SfWJFoO>UM`$me5UV2aoG`NzP>$^^ZZ+l{Yq`uFHbol zWcSzWm}W=Wq(756PO^oXcl?X_vR-)mg8h3dM6`BiN=v;_t6pRH>6~bpaGY!R{7XW= z!~0@R{Jxg`?c$v6t=p^nSF7I_?6)o=D(6@!a29nWAC_YWa}H>8+^O}S97CKoX@!hr#Q96r!g*@v*h@y9xis% zHAMy?{NV?`U6&L-xAAo$&zqc6EOJ|xt};ulNk96-atHgyG}e=H$Gq*+Kg{2d^O1a!WA~;9EvaJPUkZiYu0A5W=j6lc-~1VC_A5J|nDZQz8$4b8T-G@y GGywo|9;G4x delta 1223 zcmV;&1UUPG3EByeBYyx$P)t-sX>D&578w8l00000dV_`m0Rf7SlRZI0lbW4%eSyqd zWIH}VPBuGSUtxTNho(_kc71>V000&l8z(C*F*7w~XK6-AN>x``hqTZY0000ObW%=J z_V+1D`iRQ=v-tn}|FgFLw+Q_H{{H^{DB7{9000CjNklv^6j_OQ!-<8oGwTD^QFfKAM zIlXDUQGEgJxB|%-fDF_ygqQK3upz#|!b@f~?{+BH^pSNA#upfEj7|ieQX0(B zo^*mUFf#8%fk4)-5s$I|l%p3J0TAZLZ2oNg96n~}AjAB8Z$h4Y>LPSaJ4mGD} zFc`oItzScq4th1X;H#Z|HOeGfyA*XNz8a+&U_!9LH(1YNdpiynn;5j%aS|KLlWH3)rxJKjFDH`l53?_7EFkEO|&}oIS9)-l$ zSu0j*^?y5Gu?a81SYjA1jH2As=4##SP?d}Y3_jSp{ z6}7d&*=v11Z=?0T{t1H{Hy!f5!L?fRM1*s#aJ)RDpjB2=$$1!>-suKP2_4UKtLd_S+H~z1v$(QNtyLy?nS%dofn|>vk zbd0JCIYt$2uTwcrM7+{^fNE8u!mRtwrWdn+Lch2UF`=o6^{qHK6tZRN&_DX$Etn35CDYgjUX* zKIocL6rpld6%EGyG^E1dJUH`&V45Rd1b?S+NcG;wg!9fKkMXkal{R`8}DL5K)6pX5y)RNZRV2{`H;n?Sx#Mdz7 z1=NS=cJPTdUna{0KHli#Q0oJ=gk(P4p=Ut38VB(C@IGpd)fmwFhT(mJa>Ia@0Ds*w zfZxsiiKKimz&s`sc(PcAr)pfQJsMWni(ol@P4i^#-*GJi8xqZAzJ@AUgb!RGX-)bR z?a?p^K9rtw(>nJH^OlcgwgVZ=?Y9>dkqs9*(#F`kr6Y}lPZ4f7=!emQAfJ^kmoi=7 zbLGOPv#dR!T;8%?lg?S`iV{ok+CbH;1^>2H;VZehy9zAPXA-}$T)M&bg08=o&2=4Q lw|iGycXT`0UCQRmzX6O&kx`mv1pEL1002ovPDHLkV1oWiPHO-F From 1ba5be1677fcdab724c8e48876ebd208c61e0f67 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 07:13:58 +0700 Subject: [PATCH 4/7] fix(ui): guarantee transparent fader-cap PNG corners for JUCE smoke contract --- assets/dark_brushed_slider_thumb.png | Bin 1154 -> 1166 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/assets/dark_brushed_slider_thumb.png b/assets/dark_brushed_slider_thumb.png index a839a7a98550209f92d1676d1a258b2750cbc0ff..c537b718957ff6c9e6e9a1112a1c07080fc862f6 100644 GIT binary patch delta 30 mcmZqT?Bm>E%Q$fX&tzLhK1PPgK8&#}hsCd0ZC=ZGl?echQwfg% delta 27 jcmeC6%jOR^^f&KhyvhUsa~KIn From 51976eee68b2069e4425018c3ff5429f9f060d57 Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 07:26:33 +0700 Subject: [PATCH 5/7] fix(ui): render cached metal fader cap at native size and smoke-test actual pixel contrast --- plugin/Editor.cpp | 33 +++++++++++++++++++++++++-------- plugin/Editor.h | 2 +- tests/PluginSmoke.cpp | 19 +++++++++++++++++++ 3 files changed, 45 insertions(+), 9 deletions(-) diff --git a/plugin/Editor.cpp b/plugin/Editor.cpp index 1af0f6f..1fcd129 100644 --- a/plugin/Editor.cpp +++ b/plugin/Editor.cpp @@ -61,6 +61,16 @@ CompLook::CompLook() { BinaryData::dark_brushed_slider_thumb_png, static_cast(BinaryData::dark_brushed_slider_thumb_pngSize)); jassert(sliderTrack.isValid() && sliderThumb.isValid()); + // The actual fader is 34px high: filter the tiny cap ONCE on the + // message thread, not as a moving photographic resample on every drag. + if(sliderThumb.isValid()) { + constexpr int targetH=arson::ui::EditorMetrics::faderHeight-4; + constexpr float aspect=arson::ui::FaderGeometry::thumbSourceW / + arson::ui::FaderGeometry::thumbSourceH; + sliderThumbCompact=sliderThumb.rescaled( + juce::roundToInt(targetH*aspect),targetH, + juce::Graphics::highResamplingQuality); + } setColour(juce::Slider::textBoxTextColourId,text); setColour(juce::Slider::textBoxBackgroundColourId,juce::Colour{0xff111417}); setColour(juce::Slider::textBoxOutlineColourId,juce::Colour{0xff31383e}); @@ -253,16 +263,23 @@ void CompLook::drawLinearSlider(juce::Graphics& g,int x,int y,int w,int h, g.setColour(juce::Colour{0xffffb0b6}.withAlpha(0.46f)); g.fillRect(left,cy-0.55f,position-left,1.1f); } - // Single original graphite brushed-metal asset with bevel/grip built in. - // No overlaid silver lines or faux bezel; the PNG is drawn only once. - if(sliderThumb.isValid()) { + // Tactile graphite cap: dark metal undercut + actual brushed-metal PNG. + // This is not the old painted-on bright silver ridge. Keep the silhouette + // readable at the real 14x30px GUI size, even on a dark empty rail. + g.setColour(juce::Colour{0xff4a545a}); + g.fillRoundedRectangle(thumb,3.0f); + g.setColour(juce::Colour{0xff161c20}); + g.fillRoundedRectangle(thumb.reduced(1.15f,0.8f),2.3f); + if(sliderThumbCompact.isValid() && + std::abs(thumb.getWidth()-sliderThumbCompact.getWidth())<0.65f && + std::abs(thumb.getHeight()-sliderThumbCompact.getHeight())<0.65f) { + // Pre-filter once; draw at integer device pixels without extra + // downsampling that previously erased the small metal edge. + g.drawImageAt(sliderThumbCompact,juce::roundToInt(thumb.getX()), + juce::roundToInt(thumb.getY())); + } else if(sliderThumb.isValid()) { g.setImageResamplingQuality(juce::Graphics::highResamplingQuality); g.drawImage(sliderThumb,thumb); - } else { - g.setColour(juce::Colour{0xff24292c}); - g.fillRoundedRectangle(thumb,3.0f); - g.setColour(juce::Colour{0xff5e6568}); - g.drawRoundedRectangle(thumb.reduced(0.5f),2.5f,1.0f); } } void CompLook::drawToggleButton(juce::Graphics& g,juce::ToggleButton& button, diff --git a/plugin/Editor.h b/plugin/Editor.h index 970764c..a733f53 100644 --- a/plugin/Editor.h +++ b/plugin/Editor.h @@ -22,7 +22,7 @@ class CompLook final : public juce::LookAndFeel_V4 { std::array faces; // normal + oversized Threshold only juce::Image sourceFace; // decoded once on GUI initialization juce::Image toggleOn, toggleOff; // matched, predecoded state sprites - juce::Image sliderTrack, sliderThumb; // layered photographic gunmetal assets, decoded once + juce::Image sliderTrack, sliderThumb, sliderThumbCompact; // native-resolution prefiltered fader cap const juce::Image& knobFace(int diameter,bool primary); }; class Editor final : public juce::AudioProcessorEditor, private juce::Timer { diff --git a/tests/PluginSmoke.cpp b/tests/PluginSmoke.cpp index 2a1cd87..c3978ec 100644 --- a/tests/PluginSmoke.cpp +++ b/tests/PluginSmoke.cpp @@ -246,6 +246,25 @@ static int runSmoke(int argc,char** argv) { if(bevel.getBrightness()<0.30f || bevel.getBrightness()-graphite.getBrightness()<0.14f || bevel.getFloatAlpha()<0.90f) return 86; + // Exercise the actual JUCE LookAndFeel fader render, not only the + // asset's existence. A nearly invisible cap passed earlier tests. + // The real 34px-tall strip must expose a visible metal edge. + { + CompLook look; + juce::Image paintTest(juce::Image::ARGB,100,34,true); + juce::Graphics faderGraphics(paintTest); + faderGraphics.fillAll(juce::Colour{0xff262c31}); + juce::Slider dummy; + const auto geom=arson::ui::FaderGeometry::calculate(100.0f,34.0f,55.0f); + look.drawLinearSlider(faderGraphics,0,0,100,34,55.0f,0.0f,100.0f, + juce::Slider::LinearHorizontal,dummy); + const int sampleX=juce::roundToInt(geom.position)-3; + const auto polishedEdge=paintTest.getPixelAt(sampleX,12); + const auto chassis=paintTest.getPixelAt(sampleX-17,12); + if(polishedEdge.getBrightness()<0.27f || + polishedEdge.getBrightness()-chassis.getBrightness()<0.08f) + return 87; + } // Verify the complete rotary red arc (not only its metal JPEG face) // fits inside the enlarged knob hit rectangle, including stroke. for(int width : {62,66,72,78,100}) From 7e503e80fd9da2874c3e760f781d7bfe0a6d8d0d Mon Sep 17 00:00:00 2001 From: Ari Sulistiono Date: Sun, 1 Nov 2026 07:34:59 +0700 Subject: [PATCH 6/7] fix(ui): keep graphite fader cap visibly embossed and assert rendered contrast --- plugin/Editor.cpp | 13 ++++++++++--- tests/PluginSmoke.cpp | 11 ++++++++--- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/plugin/Editor.cpp b/plugin/Editor.cpp index 1fcd129..8795f9b 100644 --- a/plugin/Editor.cpp +++ b/plugin/Editor.cpp @@ -266,10 +266,17 @@ void CompLook::drawLinearSlider(juce::Graphics& g,int x,int y,int w,int h, // Tactile graphite cap: dark metal undercut + actual brushed-metal PNG. // This is not the old painted-on bright silver ridge. Keep the silhouette // readable at the real 14x30px GUI size, even on a dark empty rail. - g.setColour(juce::Colour{0xff4a545a}); + // Graphite gradient is the material undercoat, not a silver overpaint. + // It keeps the small hardware cap distinguishable from its dark housing + // even after image filtering, while the PNG supplies brush and grip. + juce::ColourGradient brushed(juce::Colour{0xff768187},thumb.getX(),cy, + juce::Colour{0xff626c72},thumb.getRight(),cy,false); + brushed.addColour(0.16,juce::Colour{0xff737e84}); + brushed.addColour(0.32,juce::Colour{0xff343b40}); + brushed.addColour(0.52,juce::Colour{0xff1c2226}); + brushed.addColour(0.76,juce::Colour{0xff3a4248}); + g.setGradientFill(brushed); g.fillRoundedRectangle(thumb,3.0f); - g.setColour(juce::Colour{0xff161c20}); - g.fillRoundedRectangle(thumb.reduced(1.15f,0.8f),2.3f); if(sliderThumbCompact.isValid() && std::abs(thumb.getWidth()-sliderThumbCompact.getWidth())<0.65f && std::abs(thumb.getHeight()-sliderThumbCompact.getHeight())<0.65f) { diff --git a/tests/PluginSmoke.cpp b/tests/PluginSmoke.cpp index c3978ec..98669c4 100644 --- a/tests/PluginSmoke.cpp +++ b/tests/PluginSmoke.cpp @@ -258,12 +258,17 @@ static int runSmoke(int argc,char** argv) { const auto geom=arson::ui::FaderGeometry::calculate(100.0f,34.0f,55.0f); look.drawLinearSlider(faderGraphics,0,0,100,34,55.0f,0.0f,100.0f, juce::Slider::LinearHorizontal,dummy); - const int sampleX=juce::roundToInt(geom.position)-3; + const int sampleX=juce::roundToInt(geom.position)-4; const auto polishedEdge=paintTest.getPixelAt(sampleX,12); const auto chassis=paintTest.getPixelAt(sampleX-17,12); - if(polishedEdge.getBrightness()<0.27f || - polishedEdge.getBrightness()-chassis.getBrightness()<0.08f) + const float capBrightness=polishedEdge.getBrightness(); + const float chassisBrightness=chassis.getBrightness(); + if(capBrightness<0.24f || capBrightness-chassisBrightness<0.04f) { + std::cerr<<"FADER_CAP_CONTRAST_87 cap="<