Skip to content

Commit 7b1cabe

Browse files
authored
Merge M3 ArSonComp live performance baseline (Windows verified)
Combine compact premium header/toggles and optimized compressor engine with immediate dry host bypass, Windows VST3/Standalone smoke and reproducible stress testing. GitHub Actions 41209432109: Windows and Linux PASS; CRC and executable SHA256 verified; four Windows screenshots inspected. Hardware XRUN and sonic parity remain physical test gates.
2 parents 5493e4b + 83a22d2 commit 7b1cabe

9 files changed

Lines changed: 242 additions & 26 deletions

File tree

‎AGENTS.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,8 @@
99
- Use RAII and bounded containers. Avoid fast-math, speculative approximation or SIMD unless profiling and numerical tests support it.
1010
- Run meaningful DSP/host tests, inspect GUI renders at minimum/default size, and document unverified hardware behavior. Never claim proprietary Pro-C parity without matched-input audio comparisons.
1111
- Group meaningful changes before CI. Do not dispatch repetitive builds or commit generated binaries/build directories.
12+
13+
## M3 integration release gate
14+
- Always reconcile the GUI development branch and M2 realtime-performance branch before producing a Windows test binary. An artifact from one branch alone is not a combined release.
15+
- Host bypass must pass the first block bit-exactly and must not latch the parameter bypass state. User bypass remains a smoothed, separately attached parameter.
16+
- Build M3 in one PR with both Windows JUCE editor smoke and Linux sanitizer, inspect four actual Windows screenshots and benchmark/stress files before declaring ready-to-test. Do not call CI throughput a hardware xrun proof.

‎CMakeLists.txt‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ if(ARSON_BUILD_PLUGIN)
5353
assets/gunmetal_slider_track.png
5454
assets/gunmetal_slider_thumb_red.png
5555
assets/toggle/arson_toggle_on.png
56-
assets/toggle/arson_toggle_off.png)
56+
assets/toggle/arson_toggle_off.png
57+
assets/arsoncomp_header_logo.png)
5758
target_sources(ArSonComp PRIVATE plugin/Processor.cpp plugin/Editor.cpp)
5859
if(MSVC)
5960
target_compile_options(ArSonComp PRIVATE /utf-8)

‎assets/arsoncomp_header_logo.png‎

2.98 KB
Loading

‎docs/M3-HARDWARE-TEST.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# M3 — Integrated Windows VST3/Standalone hardware test gate
2+
3+
This milestone integrates the finished brushed-metal compact header/toggles with the M2 sparse-ramp real-time compressor optimizations, and makes **host bypass bit-transparent immediately**. The normal *user* bypass toggle remains a smoothed APVTS control; zero algorithmic samples are added.
4+
5+
## Scope and quality status
6+
7+
The plugin ships three independent control models (Clean, Feedback, Smooth), dual detector modes, internal/external sidechain, monitoring, wet/dry, stereo link, and program-dependent release. These are proprietary ArSon algorithms, not FabFilter emulations. [FabFilter Pro-C 3](https://www.fabfilter.com/help/pro-c/using/overview) provides an industry-level comparison target; sonic parity is **not** verified. For live use, keep any future lookahead/oversampling separate and opt-in because they can add latency.
8+
9+
## Install & validate — Windows 64-bit
10+
11+
1. Download the latest **ArSonComp-Windows-x64-ReadyToTest** ZIP from the matching M3 pull-request GitHub Actions run. Extract it. Check `BUILD-INFO.txt` commit SHA and `SHA256SUMS.txt`; do not use an old ZIP from M2.
12+
2. For Standalone, open `Standalone/ArSonComp.exe`. For a DAW/VST3 host, copy the **entire** `Plugin/ArSonComp.vst3` directory into the host's VST3 scan folder (normally `C:\Program Files\Common Files\VST3\`); do not copy only the .vst3 inner DLL.
13+
3. Inspect `Screenshots/` (full, minimum, MINI, sidechain) and the real GUI: embossed brand readable, premium compact header, preset dropdown capped at 176px, switches correct and never overlapped, no tooltip bubble.
14+
4. Start at 48 kHz / 128 sample buffer, then 64, then 32 if stable. Record host, interface/driver version, CPU load, DPC spikes, **actual** host XRUN/dropout counter, and reported plugin latency. Repeat with 1, 8, 16 active plugin instances.
15+
5. Listen on vocals, drums, bass and program bus at matched output loudness; adjust threshold for similar reduction when comparing with a commercial compressor. Assess attacks, recovery, pumping, breath/sibilance, aliasing and dry/wet coherence. Never equate same settings to same tone.
16+
6. Verify host bypass on the **first** processing block with non-unity input/makeup; it should be exactly dry. Toggle the built-in Active/Bypass control separately to assess its intentional short fade; check restart, mono/stereo and external sidechain routing and Listen SC. Test preset save/load and host project restore.
17+
7. Run a 60-minute session; open/close GUI repeatedly, automate threshold/knee, toggle modes and log private-byte trend plus latency/XRUN evidence. Stable memory use and no XRUN on your machine must be observed, not assumed from CI.
18+
19+
## Build evidence
20+
21+
GitHub PR checks gate Linux address/undefined sanitizers and engine contract tests, Windows VST3/Standalone build plus JUCE plugin/editor smoke and screenshot capture, 48kHz engine benchmark, and 32/64/128 × 1/8/24 engine-only realtime stress statistics (mean, P99, P99.9, max). Those stress numbers include hosted CI scheduler noise, **not** a physical audio dropout test.
22+
23+
No worker, mutex, allocation, filesystem access, GUI rendering or telemetry consumer on the audio callback; synchronous DSP state stays audio-thread-owned.

‎plugin/Editor.cpp‎

Lines changed: 92 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include "GraphPaint.h"
44
#include "SurfacePaint.h"
55
#include "GraphHistory.h"
6+
#include "HeaderLayout.h"
67
#include "BinaryData.h"
78
#include <cmath>
89
#include <algorithm>
@@ -70,6 +71,7 @@ CompLook::CompLook() {
7071
setColour(juce::ComboBox::backgroundColourId,juce::Colour{0xff181d22});
7172
setColour(juce::ComboBox::textColourId,text);
7273
setColour(juce::ComboBox::outlineColourId,juce::Colour{0xff374047});
74+
setColour(juce::ComboBox::arrowColourId,juce::Colour{0xffb0b8bb});
7375
setColour(juce::PopupMenu::backgroundColourId,juce::Colour{0xff161b20});
7476
setColour(juce::PopupMenu::textColourId,text);
7577
setColour(juce::PopupMenu::highlightedBackgroundColourId,juce::Colour{0xff602b32});
@@ -79,6 +81,54 @@ CompLook::CompLook() {
7981
setColour(juce::ToggleButton::tickColourId,accent);
8082
setColour(juce::Label::textColourId,muted);
8183
}
84+
// Satin-finished combo surfaces: recessed but legible on a brushed chassis.
85+
void CompLook::drawComboBox(juce::Graphics& g,int width,int height,bool down,
86+
int buttonX,int buttonY,int buttonW,int buttonH,
87+
juce::ComboBox& box) {
88+
juce::ignoreUnused(buttonX,buttonY,buttonW,buttonH);
89+
auto r=box.getLocalBounds().toFloat().reduced(0.5f);
90+
const bool hovered=box.isMouseOverOrDragging();
91+
g.setGradientFill(juce::ColourGradient(
92+
juce::Colour{0xff262e32},0.0f,0.0f,
93+
juce::Colour{0xff151a1e},0.0f,static_cast<float>(height),false));
94+
g.fillRoundedRectangle(r,4.5f);
95+
g.setColour(down?juce::Colour{0xffa95b60}:
96+
hovered?juce::Colour{0xff78858a}:juce::Colour{0xff3c474c});
97+
g.drawRoundedRectangle(r,4.5f,1.0f);
98+
g.setColour(juce::Colours::white.withAlpha(0.06f));
99+
g.drawHorizontalLine(2,5.0f,static_cast<float>(width-5));
100+
// One discreet chevron; long preset titles receive the remaining width.
101+
juce::Path caret;
102+
const float cx=static_cast<float>(width)-15.0f;
103+
const float cy=static_cast<float>(height)*0.50f;
104+
caret.startNewSubPath(cx-3.5f,cy-1.5f);
105+
caret.lineTo(cx,cy+2.0f);
106+
caret.lineTo(cx+3.5f,cy-1.5f);
107+
g.setColour(hovered?juce::Colour{0xffe0e5e5}:juce::Colour{0xffa2afb1});
108+
g.strokePath(caret,juce::PathStrokeType(1.5f));
109+
}
110+
void CompLook::positionComboBoxText(juce::ComboBox& box,juce::Label& label) {
111+
label.setBounds(11,1,juce::jmax(0,box.getWidth()-36),box.getHeight()-2);
112+
label.setFont(juce::FontOptions(11.5f));
113+
label.setJustificationType(juce::Justification::centredLeft);
114+
}
115+
void CompLook::drawButtonBackground(juce::Graphics& g,juce::Button& button,
116+
const juce::Colour& background,
117+
bool hovered,bool down) {
118+
const auto id=button.getComponentID();
119+
if(id!="view.compact" && id!="view.compare" && id!="view.file") {
120+
juce::LookAndFeel_V4::drawButtonBackground(g,button,background,hovered,down);
121+
return;
122+
}
123+
auto r=button.getLocalBounds().toFloat().reduced(0.5f);
124+
g.setGradientFill(juce::ColourGradient(
125+
down?juce::Colour{0xff30373b}:juce::Colour{0xff293035},0.0f,0.0f,
126+
juce::Colour{0xff151b1e},0.0f,r.getHeight(),false));
127+
g.fillRoundedRectangle(r,4.5f);
128+
g.setColour(down?juce::Colour{0xffa95b60}:
129+
hovered?juce::Colour{0xff7b8588}:juce::Colour{0xff485156});
130+
g.drawRoundedRectangle(r,4.5f,1.0f);
131+
}
82132
juce::Label* CompLook::createSliderTextBox(juce::Slider& s) {
83133
auto* label=juce::LookAndFeel_V4::createSliderTextBox(s);
84134
label->setFont(juce::FontOptions(12.0f));
@@ -245,6 +295,12 @@ void CompLook::drawToggleButton(juce::Graphics& g,juce::ToggleButton& button,
245295
Editor::Editor(Processor& p):AudioProcessorEditor(p),processor(p),alternate(p.snapshot()) {
246296
setLookAndFeel(&look);
247297
setOpaque(true);
298+
// One-time UI-thread decode of the high-contrast brushed embossed wordmark.
299+
// Embedded via BinaryData: no runtime file I/O or audio impact.
300+
headerLogo=juce::ImageFileFormat::loadFrom(
301+
BinaryData::arsoncomp_header_logo_png,
302+
static_cast<std::size_t>(BinaryData::arsoncomp_header_logo_pngSize));
303+
jassert(headerLogo.isValid());
248304
const std::array<std::size_t,6> bars{{arson::Range,arson::Hold,arson::Mix,
249305
arson::Link,arson::Highpass,arson::Lowpass}};
250306
for(std::size_t i=0;i<knobs.size();++i) {
@@ -490,14 +546,15 @@ void Editor::syncPanelVisibility() {
490546
}
491547
void Editor::resized() {
492548
const int w=getWidth(),h=getHeight();
493-
// The utility menu replaces two permanent buttons. Presets and model
494-
// have measurable reserved space at both 860 and 900 pixel layouts.
495-
compact.setBounds(147,21,45,28);
496-
style.setBounds(198,20,125,30);
497-
presets.setBounds(333,20,w-580,30);
498-
compare.setBounds(w-237,20,49,30);
499-
fileMenu.setBounds(w-180,20,57,30);
500-
bypass.setBounds(w-115,21,105,28);
549+
// A shared compact header grid: every control has the same baseline.
550+
// Preset is constrained to 144..176px rather than consuming all free space.
551+
const auto header=arson::ui::HeaderLayout::calculate(w);
552+
compact.setBounds(header.mini);
553+
style.setBounds(header.model);
554+
presets.setBounds(header.preset);
555+
compare.setBounds(header.compare);
556+
fileMenu.setBounds(header.file);
557+
bypass.setBounds(header.bypass);
501558
// Compact responsive hardware chassis; LCD still has its own display.
502559
display=compactMode?juce::Rectangle<int>{}:
503560
juce::Rectangle<int>{8,70,w-16,h-268};
@@ -726,16 +783,33 @@ void Editor::paint(juce::Graphics& g) {
726783
g.drawHorizontalLine(1,0.0f,static_cast<float>(getWidth()));
727784
g.setColour(juce::Colours::black.withAlpha(0.58f));
728785
g.drawHorizontalLine(67,0.0f,static_cast<float>(getWidth()));
729-
g.setFont(juce::FontOptions(17.5f));
730-
g.setColour(text);
731-
g.drawText("ArSon",16,11,73,28,juce::Justification::centredLeft);
732-
g.setColour(accent);
733-
g.drawText("Comp",84,11,61,28,juce::Justification::centredLeft);
734-
g.fillRoundedRectangle(17.0f,49.0f,37.0f,2.0f,1.0f);
735-
g.setColour(text.withAlpha(0.73f));
736-
g.setFont(juce::FontOptions(9.0f));
737-
g.drawText("MODEL",198,5,84,13,juce::Justification::left);
738-
g.drawText("PRESET",333,5,88,13,juce::Justification::left);
786+
// Single-line embossed brand and a quiet, consistent overline hierarchy.
787+
const auto header=arson::ui::HeaderLayout::calculate(getWidth());
788+
if(headerLogo.isValid()) {
789+
g.setImageResamplingQuality(juce::Graphics::highResamplingQuality);
790+
g.drawImageWithin(headerLogo,header.logo.getX(),header.logo.getY(),
791+
header.logo.getWidth(),header.logo.getHeight(),
792+
juce::RectanglePlacement::centred);
793+
} else {
794+
g.setColour(text);
795+
g.setFont(juce::FontOptions(17.0f));
796+
g.drawText("ArSonComp",header.logo,juce::Justification::centredLeft);
797+
}
798+
// Subtle division between branding and functional toolbar; no visual noise.
799+
g.setColour(juce::Colours::white.withAlpha(0.10f));
800+
g.drawVerticalLine(header.logo.getRight()+5,18.0f,52.0f);
801+
g.setColour(muted.withAlpha(0.85f));
802+
g.setFont(juce::FontOptions(8.7f));
803+
const auto caption=[&g](const char* title,const juce::Rectangle<int>& r) {
804+
g.drawText(title,r.getX()+1,9,r.getWidth()-2,12,
805+
juce::Justification::centredLeft,false);
806+
};
807+
caption("VIEW",header.mini);
808+
caption("MODEL",header.model);
809+
caption("PRESET",header.preset);
810+
caption("COMPARE",header.compare);
811+
caption("FILES",header.file);
812+
caption("ENGINE",header.bypass);
739813

740814
const int mainY=compactMode?68:display.getBottom()+5;
741815
const int bottomY=compactMode?166:getHeight()-92;

‎plugin/Editor.h‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
class CompLook final : public juce::LookAndFeel_V4 {
66
public:
77
CompLook();
8+
void drawComboBox(juce::Graphics&,int,int,bool,int,int,int,int,juce::ComboBox&) override;
9+
void positionComboBoxText(juce::ComboBox&,juce::Label&) override;
10+
void drawButtonBackground(juce::Graphics&,juce::Button&,
11+
const juce::Colour&,bool,bool) override;
812
juce::Label* createSliderTextBox(juce::Slider&) override;
913
void drawRotarySlider(juce::Graphics&,int,int,int,int,float,float,float,juce::Slider&) override;
1014
void drawLinearSlider(juce::Graphics&,int,int,int,int,float,float,float,
@@ -73,6 +77,7 @@ class Editor final : public juce::AudioProcessorEditor, private juce::Timer {
7377
int currentChannels=2;
7478
juce::Rectangle<int> display;
7579
juce::Image grid,metalSurface; // cached full chassis and black glass LCD
80+
juce::Image headerLogo; // cropped transparent metal/LED brand mark, decoded once
7681
juce::Path transferCurve,transferShade;
7782
juce::Path inputHistory,outputHistory,reductionHistory,reductionArea;
7883
// Six cached horizontal gradient brushes: input, output, GR, transfer,

‎plugin/HeaderLayout.h‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
#pragma once
2+
#include <juce_gui_basics/juce_gui_basics.h>
3+
4+
namespace arson::ui {
5+
6+
// Single geometry source for JUCE resized(), brand painting and smoke tests.
7+
// Compact presets never displace the model, A/B, file menu or main bypass.
8+
struct HeaderLayout {
9+
juce::Rectangle<int> logo,mini,model,preset,compare,file,bypass;
10+
11+
static HeaderLayout calculate(int width) noexcept {
12+
constexpr int inset=14,gap=10;
13+
constexpr int logoW=137,miniW=46,modelW=112,compareW=48,fileW=50,bypassW=114;
14+
constexpr int fixed=logoW+miniW+modelW+compareW+fileW+bypassW;
15+
const int presetW=juce::jlimit(144,176,width-2*inset-6*gap-fixed);
16+
constexpr int top=24,height=28;
17+
HeaderLayout h;
18+
int x=inset;
19+
h.logo={x,17,logoW,32};x+=logoW+gap;
20+
h.mini={x,top,miniW,height};x+=miniW+gap;
21+
h.model={x,top,modelW,height};x+=modelW+gap;
22+
h.preset={x,top,presetW,height};
23+
24+
// The right-side actions remain right-aligned when the editor grows.
25+
// Any additional width becomes intentional whitespace, not a huge preset.
26+
h.bypass={width-inset-bypassW,top,bypassW,height};
27+
h.file={h.bypass.getX()-gap-fileW,top,fileW,height};
28+
h.compare={h.file.getX()-gap-compareW,top,compareW,height};
29+
return h;
30+
}
31+
};
32+
} // namespace arson::ui

‎plugin/Processor.cpp‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,13 @@ void Processor::run(juce::AudioBuffer<float>& buffer,bool hostBypass) {
4949
side.getArrayOfReadPointers(),side.getNumChannels(),&meters);
5050
}
5151
void Processor::processBlock(juce::AudioBuffer<float>& b,juce::MidiBuffer&) { run(b,false); }
52-
void Processor::processBlockBypassed(juce::AudioBuffer<float>& b,juce::MidiBuffer&) { run(b,true); }
52+
void Processor::processBlockBypassed(juce::AudioBuffer<float>& b,juce::MidiBuffer&) {
53+
// Host-level bypass is an immediate bit-transparent passthrough, including
54+
// the FIRST block: no 5ms ramp, gain, detector math or queue writes.
55+
// Main input/output are in-place in JUCE; do not touch extra SC channels.
56+
// APVTS "bypass" remains independently smoothed during ordinary processing.
57+
juce::ignoreUnused(b);
58+
}
5359
juce::AudioProcessorParameter* Processor::getBypassParameter() const { return state.getParameter("bypass"); }
5460
juce::AudioProcessorEditor* Processor::createEditor() { return new Editor(*this); }
5561
void Processor::getStateInformation(juce::MemoryBlock& dest) {

0 commit comments

Comments
 (0)