From d61cd60d324ab73c9d4c0e3a47b509621edaabe2 Mon Sep 17 00:00:00 2001 From: raymondrewalker Date: Thu, 30 Apr 2020 16:40:23 -0700 Subject: [PATCH] Update to version checks in plexupdate.sh I suggest using dpkg --compare-versions for better semantic versioning checks (don't run into issues where you're installing an older version over a newer one, etc). --- plexupdate.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plexupdate.sh b/plexupdate.sh index 9c907ef..125b333 100644 --- a/plexupdate.sh +++ b/plexupdate.sh @@ -15,7 +15,8 @@ newversion=$(echo $jq | jq -r .nas.Synology.version) echo New Ver: $newversion curversion=$(synopkg version "Plex Media Server") echo Cur Ver: $curversion -if [ "$newversion" != "$curversion" ] +dpkg --compare-versions "$newversion" "gt" "$curversion" +if [ $? -eq "0" ] then echo New Vers Available /usr/syno/bin/synonotify PKGHasUpgrade '{"[%HOSTNAME%]": $(hostname), "[%OSNAME%]": "Synology", "[%PKG_HAS_UPDATE%]": "Plex", "[%COMPANY_NAME%]": "Synology"}'