From 7e0f7d8e80e601600bb34f84a955acdfd4349fc0 Mon Sep 17 00:00:00 2001 From: Maciej Laskowski <19705838+malaskowski@users.noreply.github.com> Date: Thu, 3 Feb 2022 10:01:45 +0100 Subject: [PATCH 1/3] Update Browsermob to the version without log4jshell --- browsermob/Dockerfile | 45 ++++++++++++++++++++++++++++++++++--------- 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/browsermob/Dockerfile b/browsermob/Dockerfile index d386b1c..e0f7b8a 100644 --- a/browsermob/Dockerfile +++ b/browsermob/Dockerfile @@ -16,13 +16,32 @@ # limitations under the License. # -FROM openjdk:8-alpine +FROM maven:3.8.4-jdk-8 as builder +RUN apt-get update \ + && apt-get install git unzip tzdata \ + && update-ca-certificates + +# Clone BMP Proxy fork with log4j fix, see https://github.com/lightbody/browsermob-proxy/pull/891 +RUN mkdir -p ~/.ssh/ && ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts \ + && git clone git://github.com/cyberstormdotmu/browsermob-proxy.git \ + && cd browsermob-proxy \ + && git reset --hard 6e4afc39c7904f361a712dccff739fa9845cebdc \ + && git status + +WORKDIR /browsermob-proxy +RUN mvn clean install -DskipTests + +################################################################################# + +FROM openjdk:8-alpine as final LABEL maintainer="Maciej Laskowski " -# Set the build params -ARG BMP_VERSION="2.1.4" -ARG BMP_DOWNLOAD_SHA256="27c4080411adff919586e909c664c73bebb8ba8bfcaea259ce58327222e5e8fb" -ARG DOWNLOAD_URL="https://github.com/lightbody/browsermob-proxy/releases/download/browsermob-proxy-${BMP_VERSION}/browsermob-proxy-${BMP_VERSION}-bin.zip" +# Until https://github.com/lightbody/browsermob-proxy/pull/891 is not merged and new BMP released +# Clone the repo with log4j update and build +# # Set the build params +# ARG BMP_VERSION="2.1.4" +# ARG BMP_DOWNLOAD_SHA256="27c4080411adff919586e909c664c73bebb8ba8bfcaea259ce58327222e5e8fb" +# ARG DOWNLOAD_URL="https://github.com/lightbody/browsermob-proxy/releases/download/browsermob-proxy-${BMP_VERSION}/browsermob-proxy-${BMP_VERSION}-bin.zip" # make sure system is up-to-date RUN apk update \ @@ -30,10 +49,18 @@ RUN apk update \ && update-ca-certificates # download and install BMP -RUN curl -fSL -o /tmp/browsermob-proxy.zip ${DOWNLOAD_URL} \ - && echo "${BMP_DOWNLOAD_SHA256} /tmp/browsermob-proxy.zip" | sha256sum -c - \ - && unzip /tmp/browsermob-proxy.zip -d / \ - && mv /browsermob-proxy-${BMP_VERSION} /browsermob-proxy \ +# RUN curl -fSL -o /tmp/browsermob-proxy.zip ${DOWNLOAD_URL} \ +# && echo "${BMP_DOWNLOAD_SHA256} /tmp/browsermob-proxy.zip" | sha256sum -c - \ +# && unzip /tmp/browsermob-proxy.zip -d / \ +# && mv /browsermob-proxy-${BMP_VERSION} /browsermob-proxy \ +# && rm -f /tmp/browsermob-proxy.zip \ +# && rm -rf /var/cache/apk/* + +COPY --from=builder /browsermob-proxy/browsermob-dist/target/browsermob-proxy-2.1.6-SNAPSHOT-bin.zip /home/karaf/.m2/repository /tmp/ + +# unzip and install BMP +RUN unzip /tmp/browsermob-proxy-2.1.6-SNAPSHOT-bin.zip -d / \ + && mv /browsermob-proxy-2.1.6-SNAPSHOT /browsermob-proxy \ && rm -f /tmp/browsermob-proxy.zip \ && rm -rf /var/cache/apk/* From 1af533dafd4b26288bbc2b115164ee3bac1961ce Mon Sep 17 00:00:00 2001 From: Maciej Laskowski <19705838+malaskowski@users.noreply.github.com> Date: Thu, 3 Feb 2022 17:10:38 +0100 Subject: [PATCH 2/3] Update Dockerfile --- browsermob/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browsermob/Dockerfile b/browsermob/Dockerfile index e0f7b8a..84b25e5 100644 --- a/browsermob/Dockerfile +++ b/browsermob/Dockerfile @@ -56,7 +56,7 @@ RUN apk update \ # && rm -f /tmp/browsermob-proxy.zip \ # && rm -rf /var/cache/apk/* -COPY --from=builder /browsermob-proxy/browsermob-dist/target/browsermob-proxy-2.1.6-SNAPSHOT-bin.zip /home/karaf/.m2/repository /tmp/ +COPY --from=builder /browsermob-proxy/browsermob-dist/target/browsermob-proxy-2.1.6-SNAPSHOT-bin.zip /tmp/ # unzip and install BMP RUN unzip /tmp/browsermob-proxy-2.1.6-SNAPSHOT-bin.zip -d / \ From 8f6bf0ae805c4d8205637b68e2a510542374eea6 Mon Sep 17 00:00:00 2001 From: Maciej Laskowski <19705838+malaskowski@users.noreply.github.com> Date: Thu, 10 Feb 2022 09:28:41 +0100 Subject: [PATCH 3/3] update changlog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index abc8d37..b71b9d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,5 @@ # Not released yet -Nothing new... +- [PR-33](https://github.com/malaskowski/aet-docker/pull/33) - Update BrowserMob Proxy image to the version without log4jshell vulnerability. # 1.0.0 ### Images moved to my new Docker Hub space: https://hub.docker.com/u/malaskowski