Skip to content

techdebt: revisit failing escrow test and fix issue causing it to fail #1016

@thlorenz

Description

@thlorenz

In this PR (and a very similar PR before) we saw the following escrow test failing sporadically:

  • inside test_cloning_unescrowed_payer_that_is_escrowed_later test-integration/test-cloning/tests/06_escrows.rs
  • the test was removed in this commit
  • to re-enable just revert that commit and try to make it pass again

I double checked that the test is correct and it may point to an underlying race condition.

It is impossible for me to reproduce this locally though, so until we understand this problem better the offending test in the PR will be disabled.

As part of the analysis I investigated a possible unsub/sub race condition (documented here: #1015), but since we never unsubscribe from the escrow (unless it is removed from the LRU cache) that cannot be the issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P4techdebtIssues outlining shortcuts we took that need to be fixed when we have time

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions