fix: Resolve the Images in the icon folder correctly

Author: gravemalte

plugins/de.ovgu.featureide.fm.ui/META-INF/MANIFEST.MF

@@ -79,3 +79,4 @@ Export-Package: de.ovgu.featureide.fm.ui,
 Bundle-ClassPath: .,
  lib/org.abego.treelayout.core-1.0.3.jar
 Automatic-Module-Name: de.ovgu.featureide.fm.ui
+Import-Package: org.eclipse.core.runtime

plugins/de.ovgu.featureide.fm.ui/src/de/ovgu/featureide/fm/ui/FMUIPlugin.java

@@ -23,6 +23,7 @@
 
 import static de.ovgu.featureide.fm.core.localization.StringTable.SELECT_THE_FEATURE_MODEL_FOR_THE_CURRENT_PROJECT;
 
+import java.net.URL;
 import java.util.Arrays;
 import java.util.Optional;
 
@@ -31,7 +32,10 @@
 import org.eclipse.core.resources.IResource;
 import org.eclipse.core.resources.IResourceChangeListener;
 import org.eclipse.core.resources.ResourcesPlugin;
+import org.eclipse.core.runtime.FileLocator;
 import org.eclipse.core.runtime.IStatus;
+import org.eclipse.core.runtime.Path;
+import org.eclipse.core.runtime.Platform;
 import org.eclipse.core.runtime.Status;
 import org.eclipse.jface.resource.ImageDescriptor;
 import org.eclipse.swt.graphics.Image;
@@ -87,12 +91,11 @@ public static FMUIPlugin getDefault() {
 	}
 
 	public static Image getImage(String name) {
-		final ImageDescriptor descriptor = getDefault().getImageDescriptor("icons/" + name);
-		if (descriptor != null) {
-			return descriptor.createImage();
+		final URL url = FileLocator.find(Platform.getBundle(PLUGIN_ID), new Path("icons/" + name), null);
+		if (url != null) {
+			return ImageDescriptor.createFromURL(url).createImage();
 		} else {
-			final IStatus status = new Status(IStatus.WARNING, PLUGIN_ID, "[FeatureIDE] Image not found: icons/" + name);
-			getDefault().getLog().log(status);
+			getDefault().getLog().log(new Status(IStatus.ERROR, PLUGIN_ID, "Image not found: " + name));
 			return null;
 		}
 	}