From 65ee644c335ba0751b2886e8d30e6bae07b002ef Mon Sep 17 00:00:00 2001 From: Lukasz Gryglicki Date: Wed, 3 Jun 2026 15:23:50 +0200 Subject: [PATCH] Fix CI lint test failures Signed-off-by: Lukasz Gryglicki Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot) Assisted by [Claude](https://claude.ai) --- cla-backend-go/company/repository.go | 2 +- cla-backend-go/v2/sign/service.go | 3 ++- cla-backend-go/v2/sign/service_sss_test.go | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/cla-backend-go/company/repository.go b/cla-backend-go/company/repository.go index fadb95dab..fc53a7642 100644 --- a/cla-backend-go/company/repository.go +++ b/cla-backend-go/company/repository.go @@ -1341,7 +1341,7 @@ func (repo repository) ClearCompanySanctionStatusIfSSS(ctx context.Context, comp Key: map[string]*dynamodb.AttributeValue{ "company_id": {S: aws.String(companyID)}, }, - UpdateExpression: aws.String("SET #S = :false, #M = :m REMOVE #O"), + UpdateExpression: aws.String("SET #S = :false, #M = :m REMOVE #O"), ConditionExpression: aws.String("#O = :sss"), ExpressionAttributeNames: map[string]*string{ "#S": aws.String("is_sanctioned"), diff --git a/cla-backend-go/v2/sign/service.go b/cla-backend-go/v2/sign/service.go index 86d673631..8f444e7bd 100644 --- a/cla-backend-go/v2/sign/service.go +++ b/cla-backend-go/v2/sign/service.go @@ -125,7 +125,7 @@ type service struct { sssClient *sss.Client sssRequired bool complianceCache map[string]complianceCacheEntry - complianceCacheMu sync.Mutex + complianceCacheMu *sync.Mutex } type complianceCacheEntry struct { @@ -162,6 +162,7 @@ func NewService(apiURL, v1API string, compRepo company.IRepository, projectRepo sssClient: sssClient, sssRequired: sssRequired, complianceCache: make(map[string]complianceCacheEntry), + complianceCacheMu: &sync.Mutex{}, } } diff --git a/cla-backend-go/v2/sign/service_sss_test.go b/cla-backend-go/v2/sign/service_sss_test.go index 310c6a989..b825d2794 100644 --- a/cla-backend-go/v2/sign/service_sss_test.go +++ b/cla-backend-go/v2/sign/service_sss_test.go @@ -5,6 +5,7 @@ package sign import ( "context" + "sync" "testing" "time" @@ -120,6 +121,7 @@ func TestComplianceCacheExpires(t *testing.T) { expiresAt: time.Now().Add(-time.Second), }, }, + complianceCacheMu: &sync.Mutex{}, } if _, ok := svc.getComplianceCache("company-id"); ok { @@ -128,7 +130,7 @@ func TestComplianceCacheExpires(t *testing.T) { } func TestComplianceCacheSkipsErrors(t *testing.T) { - svc := &service{} + svc := &service{complianceCacheMu: &sync.Mutex{}} // setComplianceCache no longer takes an err param; just verify it stores the entry svc.setComplianceCache("company-id", false)