From 0e9716bb6c8769b64709c01bef3fb1a2a0d78ef6 Mon Sep 17 00:00:00 2001 From: Alec Jacobson Date: Thu, 15 May 2025 14:11:18 -0400 Subject: [PATCH 1/2] fix stable abi build for >3.12 --- .github/workflows/wheels.yml | 3 ++- CMakeLists.txt | 5 ++++- pyproject.toml | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/wheels.yml b/.github/workflows/wheels.yml index 8d61145a..b248ea3e 100644 --- a/.github/workflows/wheels.yml +++ b/.github/workflows/wheels.yml @@ -41,7 +41,8 @@ jobs: arch: arm64 # Exclude arm64 on macOS 13 - os: macos-13 pybuilds: cp38 - + name: > + ${{ matrix.pybuilds }} ${{ matrix.os }} $${{ matrix.arch }} steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v5 diff --git a/CMakeLists.txt b/CMakeLists.txt index e6d863d7..3424780f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -125,7 +125,10 @@ function(pyigl_include prefix name) file(WRITE "${generated_dir}/BINDING_INVOCATIONS.in" "${BINDING_INVOCATIONS}") set(target_name "pyigl${prefix_lc}_${name}") - nanobind_add_module(${target_name} ${sources}) + nanobind_add_module( + ${target_name} + STABLE_ABI + ${sources}) # important for scikit-build install(TARGETS ${target_name} LIBRARY DESTINATION "igl/${subpath}") diff --git a/pyproject.toml b/pyproject.toml index b34f6c20..69561de1 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -14,7 +14,7 @@ build-backend = "scikit_build_core.build" [project] name = "libigl" -version = "2.6.0" +version = "2.6.1" description = "libigl: A simple C++ geometry processing library" readme = "README.md" requires-python = ">=3.8" From 1f76fffc494b9564bddfe9dfd77c3412eea09973 Mon Sep 17 00:00:00 2001 From: Alec Jacobson Date: Thu, 15 May 2025 14:12:53 -0400 Subject: [PATCH 2/2] remove extra $ [skip ci] --- .github/workflows/wheels.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/wheels.yml b/.github/workflows/wheels.yml index b248ea3e..ed2e870b 100644 --- a/.github/workflows/wheels.yml +++ b/.github/workflows/wheels.yml @@ -42,7 +42,7 @@ jobs: - os: macos-13 pybuilds: cp38 name: > - ${{ matrix.pybuilds }} ${{ matrix.os }} $${{ matrix.arch }} + ${{ matrix.pybuilds }} ${{ matrix.os }} ${{ matrix.arch }} steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v5