feat: update permissions.test.ts and session.test.ts

Author: qorzj

packages/core/src/tests/permissions.test.ts

@@ -302,7 +302,7 @@ test("computeToolCallPermissions temporarily upgrades allowed forced scopes to a
 
 test("computeToolCallPermissions allows read tool calls under skill scan paths", () => {
   const projectRoot = createTempDir("deepcode-permissions-skill-read-workspace-");
-  const home = createTempDir("deepcode-permissions-skill-read-home-");
+  const home = createTempDir("deepcode-permissions-skill-read-home-", process.cwd());
   const skillRoot = path.join(home, ".agents", "skills");
   const skillResourcePath = path.join(skillRoot, "pdf", "scripts", "extract.py");
   const outsidePath = path.join(home, "notes.txt");
@@ -342,7 +342,7 @@ test("computeToolCallPermissions allows read tool calls under skill scan paths",
 
 test("UnderstandImage requires network and exempts only configured image directories from read scope", () => {
   const projectRoot = createTempDir("deepcode-permissions-image-workspace-");
-  const home = createTempDir("deepcode-permissions-image-home-");
+  const home = createTempDir("deepcode-permissions-image-home-", process.cwd());
   const sessionImages = path.join(home, ".deepcode", "projects", "project", "images", "session-1");
   const currentImage = path.join(sessionImages, "current.png");
   const projectImage = path.join(projectRoot, "project.png");
@@ -388,7 +388,7 @@ test("UnderstandImage requires network and exempts only configured image directo
 
 test("ReadImage uses filesystem read permissions without network access", () => {
   const projectRoot = createTempDir("deepcode-permissions-read-image-workspace-");
-  const home = createTempDir("deepcode-permissions-read-image-home-");
+  const home = createTempDir("deepcode-permissions-read-image-home-", process.cwd());
   const projectImage = path.join(projectRoot, "project.png");
   const outsideImage = path.join(home, "outside.png");
   const plan = computeToolCallPermissions({
@@ -666,8 +666,8 @@ test("hasUserPermissionReplies detects permission reply payloads", () => {
   assert.equal(hasUserPermissionReplies({ alwaysAllows: ["network"] }), true);
 });
 
-function createTempDir(prefix: string): string {
-  const dir = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
+function createTempDir(prefix: string, parentDir = os.tmpdir()): string {
+  const dir = fs.mkdtempSync(path.join(parentDir, prefix));
   tempDirs.push(dir);
   return dir;
 }

packages/core/src/tests/session.test.ts

@@ -2628,56 +2628,60 @@ test("activateSession temporarily asks before allowed writes in Plan Mode", asyn
   assert.deepEqual(assistant?.meta?.permissions, [{ toolCallId: "call-write", permission: "ask" }]);
 });
 
-test("activateSession does not force allowed temporary writes to ask in Plan Mode", async () => {
-  const workspace = createTempDir("deepcode-plan-tmp-permission-workspace-");
-  const home = createTempDir("deepcode-plan-tmp-permission-home-");
-  const targetPath = path.join("/tmp", `deepcode-plan-${crypto.randomUUID()}.txt`);
-  tempDirs.push(targetPath);
-  setHomeDir(home);
+test(
+  "activateSession does not force allowed temporary writes to ask in Plan Mode",
+  { skip: process.platform === "win32" },
+  async () => {
+    const workspace = createTempDir("deepcode-plan-tmp-permission-workspace-");
+    const home = createTempDir("deepcode-plan-tmp-permission-home-");
+    const targetPath = path.join("/tmp", `deepcode-plan-${crypto.randomUUID()}.txt`);
+    tempDirs.push(targetPath);
+    setHomeDir(home);
 
-  const manager = createPermissionSessionManager(
-    workspace,
-    [
-      {
-        choices: [
-          {
-            message: {
-              content: "",
-              tool_calls: [
-                {
-                  id: "call-write-tmp",
-                  type: "function",
-                  function: {
-                    name: "write",
-                    arguments: JSON.stringify({ file_path: targetPath, content: "planned" }),
+    const manager = createPermissionSessionManager(
+      workspace,
+      [
+        {
+          choices: [
+            {
+              message: {
+                content: "",
+                tool_calls: [
+                  {
+                    id: "call-write-tmp",
+                    type: "function",
+                    function: {
+                      name: "write",
+                      arguments: JSON.stringify({ file_path: targetPath, content: "planned" }),
+                    },
                   },
-                },
-              ],
+                ],
+              },
             },
-          },
-        ],
-        usage: { prompt_tokens: 1, completion_tokens: 1, total_tokens: 2 },
-      },
-      createChatResponse("done", { prompt_tokens: 1, completion_tokens: 1, total_tokens: 2 }),
-    ],
-    {
-      allow: ["write-in-tmp"],
-      deny: [],
-      ask: [],
-      defaultMode: "allowAll",
-    }
-  );
+          ],
+          usage: { prompt_tokens: 1, completion_tokens: 1, total_tokens: 2 },
+        },
+        createChatResponse("done", { prompt_tokens: 1, completion_tokens: 1, total_tokens: 2 }),
+      ],
+      {
+        allow: ["write-in-tmp"],
+        deny: [],
+        ask: [],
+        defaultMode: "allowAll",
+      }
+    );
 
-  const sessionId = await manager.createSession({ text: "Plan this change", planMode: true });
-  const session = manager.getSession(sessionId);
-  const assistant = manager
-    .listSessionMessages(sessionId)
-    .find((message) => message.role === "assistant" && (message.messageParams as any)?.tool_calls);
+    const sessionId = await manager.createSession({ text: "Plan this change", planMode: true });
+    const session = manager.getSession(sessionId);
+    const assistant = manager
+      .listSessionMessages(sessionId)
+      .find((message) => message.role === "assistant" && (message.messageParams as any)?.tool_calls);
 
-  assert.equal(session?.status, "completed");
-  assert.deepEqual(assistant?.meta?.permissions, [{ toolCallId: "call-write-tmp", permission: "allow" }]);
-  assert.equal(fs.readFileSync(targetPath, "utf8"), "planned");
-});
+    assert.equal(session?.status, "completed");
+    assert.deepEqual(assistant?.meta?.permissions, [{ toolCallId: "call-write-tmp", permission: "allow" }]);
+    assert.equal(fs.readFileSync(targetPath, "utf8"), "planned");
+  }
+);
 
 test("SessionManager preserves permission_denied status when sessions are reloaded", async () => {
   const workspace = createTempDir("deepcode-permission-denied-workspace-");