diff --git a/internal/dnsforward/dns64_internal_test.go b/internal/dnsforward/dns64_internal_test.go index 58cb3afe26a..aab81e94ad0 100644 --- a/internal/dnsforward/dns64_internal_test.go +++ b/internal/dnsforward/dns64_internal_test.go @@ -290,23 +290,27 @@ func TestServer_ServeDNS_dns64(t *testing.T) { // reused right after stop, due to a data race in [proxy.Proxy.Init] // method when setting an OOB size. As a temporary workaround, // recreate the whole server for each test case. - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - UseDNS64: true, - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, - UpstreamDNS: []string{upsAddr}, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - UsePrivateRDNS: true, - LocalPTRResolvers: []string{localUpsAddr}, - ServePlainDNS: true, - }) + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + UseDNS64: true, + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + UpstreamDNS: []string{upsAddr}, + }, + UsePrivateRDNS: true, + LocalPTRResolvers: []string{localUpsAddr}, + ServePlainDNS: true, + }, + ) startDeferStop(t, s) @@ -330,23 +334,27 @@ func TestServer_dns64WithDisabledRDNS(t *testing.T) { upsAddr := aghtest.StartLocalhostUpstream(t, panicHdlr).String() localUpsAddr := aghtest.StartLocalhostUpstream(t, panicHdlr).String() - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - UseDNS64: true, - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, - UpstreamDNS: []string{upsAddr}, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - UsePrivateRDNS: false, - LocalPTRResolvers: []string{localUpsAddr}, - ServePlainDNS: true, - }) + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + UseDNS64: true, + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + UpstreamDNS: []string{upsAddr}, + }, + UsePrivateRDNS: false, + LocalPTRResolvers: []string{localUpsAddr}, + ServePlainDNS: true, + }, + ) startDeferStop(t, s) mappedIPv6 := net.ParseIP("64:ff9b::102:304") diff --git a/internal/dnsforward/dnsforward_internal_test.go b/internal/dnsforward/dnsforward_internal_test.go index fd8080d59d6..f48524d5038 100644 --- a/internal/dnsforward/dnsforward_internal_test.go +++ b/internal/dnsforward/dnsforward_internal_test.go @@ -245,19 +245,23 @@ func createTestTLS(tb testing.TB, tlsConf *TLSConfig) (s *Server, certPem []byte tlsConf.Cert = &cert - s = createTestServer(tb, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - TLSConf: tlsConf, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + s = createTestServer( + tb, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - ServePlainDNS: true, - }) + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + TLSConf: tlsConf, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + ServePlainDNS: true, + }, + ) err = s.Prepare(testutil.ContextWithTimeout(tb, testTimeout), &s.conf) require.NoErrorf(tb, err, "failed to prepare server: %s", err) @@ -381,19 +385,23 @@ func sendTestMessages(tb testing.TB, conn *dns.Conn) { } func TestServer(t *testing.T) { - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - ServePlainDNS: true, - }) + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + ServePlainDNS: true, + }, + ) s.conf.UpstreamConfig.Upstreams = []upstream.Upstream{newGoogleUpstream()} startDeferStop(t, s) @@ -497,19 +505,24 @@ func TestServer_Prepare_fallbacks(t *testing.T) { } func TestServerWithProtectionDisabled(t *testing.T) { - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - ServePlainDNS: true, - }) + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + ServePlainDNS: true, + }, + ) + s.conf.UpstreamConfig.Upstreams = []upstream.Upstream{newGoogleUpstream()} startDeferStop(t, s) @@ -727,21 +740,23 @@ func TestSafeSearch(t *testing.T) { } func TestInvalidRequest(t *testing.T) { - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{ - Enabled: false, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, + }, + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, }, - ClientsContainer: EmptyClientsContainer{}, + ServePlainDNS: true, }, - ServePlainDNS: true, - }) + ) startDeferStop(t, s) addr := s.dnsProxy.Addr(proxy.ProtoUDP).String() @@ -774,10 +789,14 @@ func TestBlockedRequest(t *testing.T) { }, ServePlainDNS: true, } - s := createTestServer(t, &filtering.Config{ - ProtectionEnabled: true, - BlockingMode: filtering.BlockingModeDefault, - }, forwardConf) + s := createTestServer( + t, + &filtering.Config{ + ProtectionEnabled: true, + BlockingMode: filtering.BlockingModeDefault, + }, + forwardConf, + ) startDeferStop(t, s) addr := s.dnsProxy.Addr(proxy.ProtoUDP) @@ -814,9 +833,11 @@ func TestServerCustomClientUpstream(t *testing.T) { }, ServePlainDNS: true, } - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, forwardConf) + s := createTestServer( + t, + &filtering.Config{BlockingMode: filtering.BlockingModeDefault}, + forwardConf, + ) ups := aghtest.NewUpstreamMock(func(req *dns.Msg) (resp *dns.Msg, err error) { atomic.AddUint32(&upsCalledCounter, 1) @@ -879,21 +900,23 @@ var testIPv4 = map[string][]net.IP{ } func TestBlockCNAMEProtectionEnabled(t *testing.T) { - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{ - Enabled: false, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, + }, + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, }, - ClientsContainer: EmptyClientsContainer{}, + ServePlainDNS: true, }, - ServePlainDNS: true, - }) + ) testUpstm := &aghtest.Upstream{ CName: testCNAMEs, IPv4: testIPv4, @@ -930,10 +953,11 @@ func TestBlockCNAME(t *testing.T) { }, ServePlainDNS: true, } - s := createTestServer(t, &filtering.Config{ - ProtectionEnabled: true, - BlockingMode: filtering.BlockingModeDefault, - }, forwardConf) + s := createTestServer( + t, + &filtering.Config{ProtectionEnabled: true, BlockingMode: filtering.BlockingModeDefault}, + forwardConf, + ) s.conf.UpstreamConfig.Upstreams = []upstream.Upstream{ &aghtest.Upstream{ CName: testCNAMEs, @@ -1005,9 +1029,11 @@ func TestClientRulesForCNAMEMatching(t *testing.T) { }, ServePlainDNS: true, } - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, forwardConf) + s := createTestServer( + t, + &filtering.Config{BlockingMode: filtering.BlockingModeDefault}, + forwardConf, + ) s.conf.UpstreamConfig.Upstreams = []upstream.Upstream{ &aghtest.Upstream{ CName: testCNAMEs, @@ -1053,10 +1079,11 @@ func TestNullBlockedRequest(t *testing.T) { }, ServePlainDNS: true, } - s := createTestServer(t, &filtering.Config{ - ProtectionEnabled: true, - BlockingMode: filtering.BlockingModeNullIP, - }, forwardConf) + s := createTestServer( + t, + &filtering.Config{ProtectionEnabled: true, BlockingMode: filtering.BlockingModeNullIP}, + forwardConf, + ) startDeferStop(t, s) addr := s.dnsProxy.Addr(proxy.ProtoUDP) @@ -1195,10 +1222,11 @@ func TestBlockedByHosts(t *testing.T) { ServePlainDNS: true, } - s := createTestServer(t, &filtering.Config{ - ProtectionEnabled: true, - BlockingMode: filtering.BlockingModeDefault, - }, forwardConf) + s := createTestServer( + t, + &filtering.Config{ProtectionEnabled: true, BlockingMode: filtering.BlockingModeDefault}, + forwardConf, + ) startDeferStop(t, s) addr := s.dnsProxy.Addr(proxy.ProtoUDP) @@ -1827,20 +1855,24 @@ func TestServer_Exchange(t *testing.T) { localUpsAddr := aghtest.StartLocalhostUpstream(t, tc.locUpstream).String() t.Run(tc.name, func(t *testing.T) { - srv := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamDNS: []string{upsAddr}, - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + srv := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - LocalPTRResolvers: []string{localUpsAddr}, - UsePrivateRDNS: true, - ServePlainDNS: true, - }) + ServerConfig{ + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamDNS: []string{upsAddr}, + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + LocalPTRResolvers: []string{localUpsAddr}, + UsePrivateRDNS: true, + ServePlainDNS: true, + }, + ) ctx := testutil.ContextWithTimeout(t, testTimeout) host, ttl, eerr := srv.Exchange(ctx, tc.req) @@ -1852,19 +1884,23 @@ func TestServer_Exchange(t *testing.T) { } t.Run("resolving_disabled", func(t *testing.T) { - srv := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamDNS: []string{upsAddr}, - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + srv := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - LocalPTRResolvers: []string{}, - ServePlainDNS: true, - }) + ServerConfig{ + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamDNS: []string{upsAddr}, + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + LocalPTRResolvers: []string{}, + ServePlainDNS: true, + }, + ) ctx := testutil.ContextWithTimeout(t, testTimeout) host, _, eerr := srv.Exchange(ctx, localIP) diff --git a/internal/dnsforward/dnsrewrite_internal_test.go b/internal/dnsforward/dnsrewrite_internal_test.go index ed523fb5eea..d6df84cce64 100644 --- a/internal/dnsforward/dnsrewrite_internal_test.go +++ b/internal/dnsforward/dnsrewrite_internal_test.go @@ -35,17 +35,21 @@ func TestServer_FilterDNSRewrite(t *testing.T) { } // Helper functions and entities. - srv := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + srv := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - ServePlainDNS: true, - }) + ServerConfig{ + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + ServePlainDNS: true, + }, + ) makeQ := func(qtype rules.RRType) (req *dns.Msg) { return &dns.Msg{ diff --git a/internal/dnsforward/http_internal_test.go b/internal/dnsforward/http_internal_test.go index dc011ebf828..de5cadcceab 100644 --- a/internal/dnsforward/http_internal_test.go +++ b/internal/dnsforward/http_internal_test.go @@ -387,21 +387,25 @@ func TestServer_HandleTestUpstreamDNS(t *testing.T) { ) require.NoError(t, err) - srv := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - EtcHosts: hc, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - UpstreamTimeout: upsTimeout, - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + srv := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, + EtcHosts: hc, }, - ServePlainDNS: true, - }) + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + UpstreamTimeout: upsTimeout, + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + ServePlainDNS: true, + }, + ) srv.etcHosts = upstream.NewHostsResolver(hc) startDeferStop(t, srv) diff --git a/internal/dnsforward/middleware_internal_test.go b/internal/dnsforward/middleware_internal_test.go index e27f54f50cd..28c8e63a115 100644 --- a/internal/dnsforward/middleware_internal_test.go +++ b/internal/dnsforward/middleware_internal_test.go @@ -216,23 +216,27 @@ func TestServer_middlewareUDP(t *testing.T) { t.Run(tc.name, func(t *testing.T) { t.Parallel() - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - TLSConf: &TLSConfig{}, - Config: Config{ - AllowedClients: tc.allowedClients, - DisallowedClients: tc.disallowedClients, - BlockedHosts: tc.blockedHosts, - UpstreamDNS: []string{localUpsAddr}, - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - ServePlainDNS: true, - }) + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + TLSConf: &TLSConfig{}, + Config: Config{ + AllowedClients: tc.allowedClients, + DisallowedClients: tc.disallowedClients, + BlockedHosts: tc.blockedHosts, + UpstreamDNS: []string{localUpsAddr}, + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + ServePlainDNS: true, + }, + ) startDeferStop(t, s) diff --git a/internal/dnsforward/process_internal_test.go b/internal/dnsforward/process_internal_test.go index 71ffb455f2d..34d13cdb48a 100644 --- a/internal/dnsforward/process_internal_test.go +++ b/internal/dnsforward/process_internal_test.go @@ -86,9 +86,11 @@ func TestServer_ProcessInitial(t *testing.T) { ServePlainDNS: true, } - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, c) + s := createTestServer( + t, + &filtering.Config{BlockingMode: filtering.BlockingModeDefault}, + c, + ) var gotAddr netip.Addr s.addrProc = &aghtest.AddressProcessor{ @@ -187,9 +189,11 @@ func TestServer_ProcessFilteringAfterResponse(t *testing.T) { ServePlainDNS: true, } - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, c) + s := createTestServer( + t, + &filtering.Config{BlockingMode: filtering.BlockingModeDefault}, + c, + ) resp := newResp(dns.RcodeSuccess, tc.req, tc.respAns) dctx := &dnsContext{ @@ -326,24 +330,28 @@ func TestServer_ProcessDDRQuery(t *testing.T) { for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - Config: Config{ - HandleDDR: tc.ddrEnabled, - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - TLSConf: &TLSConfig{ - ServerName: ddrTestDomainName, - Cert: &cert, - TLSListenAddrs: tc.addrsDoT, - HTTPSListenAddrs: tc.addrsDoH, - QUICListenAddrs: tc.addrsDoQ, + ServerConfig{ + Config: Config{ + HandleDDR: tc.ddrEnabled, + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + TLSConf: &TLSConfig{ + ServerName: ddrTestDomainName, + Cert: &cert, + TLSListenAddrs: tc.addrsDoT, + HTTPSListenAddrs: tc.addrsDoH, + QUICListenAddrs: tc.addrsDoQ, + }, + ServePlainDNS: true, }, - ServePlainDNS: true, - }) + ) // TODO(e.burkov): Generate a certificate actually containing the // IP addresses. s.hasIPAddrs = true diff --git a/internal/dnsforward/requesthandler_internal_test.go b/internal/dnsforward/requesthandler_internal_test.go index 28f7daed65a..afb6558312e 100644 --- a/internal/dnsforward/requesthandler_internal_test.go +++ b/internal/dnsforward/requesthandler_internal_test.go @@ -243,24 +243,28 @@ func TestServer_ServeDNS_restrictLocal(t *testing.T) { }) localUpsAddr := aghtest.StartLocalhostUpstream(t, localUpsHdlr).String() - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - UDPListenAddrs: []*net.UDPAddr{{}}, - TCPListenAddrs: []*net.TCPAddr{{}}, - TLSConf: &TLSConfig{}, - // TODO(s.chzhen): Add tests where EDNSClientSubnet.Enabled is true. - // Improve Config declaration for tests. - Config: Config{ - UpstreamDNS: []string{localUpsAddr}, - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - UsePrivateRDNS: true, - LocalPTRResolvers: []string{localUpsAddr}, - ServePlainDNS: true, - }) + ServerConfig{ + UDPListenAddrs: []*net.UDPAddr{{}}, + TCPListenAddrs: []*net.TCPAddr{{}}, + TLSConf: &TLSConfig{}, + // TODO(s.chzhen): Add tests where EDNSClientSubnet.Enabled is true. + // Improve Config declaration for tests. + Config: Config{ + UpstreamDNS: []string{localUpsAddr}, + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + UsePrivateRDNS: true, + LocalPTRResolvers: []string{localUpsAddr}, + ServePlainDNS: true, + }, + ) startDeferStop(t, s) testCases := []struct { diff --git a/internal/dnsforward/svcbmsg_internal_test.go b/internal/dnsforward/svcbmsg_internal_test.go index 9a2e6d933f0..d5a8eca46ae 100644 --- a/internal/dnsforward/svcbmsg_internal_test.go +++ b/internal/dnsforward/svcbmsg_internal_test.go @@ -14,17 +14,21 @@ import ( func TestGenAnswerHTTPS_andSVCB(t *testing.T) { // Preconditions. - s := createTestServer(t, &filtering.Config{ - BlockingMode: filtering.BlockingModeDefault, - }, ServerConfig{ - TLSConf: &TLSConfig{}, - Config: Config{ - UpstreamMode: UpstreamModeLoadBalance, - EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, - ClientsContainer: EmptyClientsContainer{}, + s := createTestServer( + t, + &filtering.Config{ + BlockingMode: filtering.BlockingModeDefault, }, - ServePlainDNS: true, - }) + ServerConfig{ + TLSConf: &TLSConfig{}, + Config: Config{ + UpstreamMode: UpstreamModeLoadBalance, + EDNSClientSubnet: &EDNSClientSubnet{Enabled: false}, + ClientsContainer: EmptyClientsContainer{}, + }, + ServePlainDNS: true, + }, + ) req := &dns.Msg{ Question: []dns.Question{{ diff --git a/internal/home/controlupdate.go b/internal/home/controlupdate.go index d0c080f2eb1..3ea0aaa1df3 100644 --- a/internal/home/controlupdate.go +++ b/internal/home/controlupdate.go @@ -212,7 +212,7 @@ func (vr *versionResponse) setAllowedToAutoUpdate( } // tlsConfUsesPrivilegedPorts returns true if the provided TLS configuration -// indicates that privileged ports are used. c must be valid +// indicates that privileged ports are used. c must be valid. func tlsConfUsesPrivilegedPorts(c *tlsConfigSettings) (ok bool) { return c.Enabled && (c.PortHTTPS < maxPrivilegedPort || c.PortDNSOverTLS < maxPrivilegedPort ||