Skip to content

Fix notify team new comment branch#55

Closed
rparadowski wants to merge 2 commits into
learningequality:mainfrom
rparadowski:fix_notify_team_new_comment_branch
Closed

Fix notify team new comment branch#55
rparadowski wants to merge 2 commits into
learningequality:mainfrom
rparadowski:fix_notify_team_new_comment_branch

Conversation

@rparadowski
Copy link
Copy Markdown
Contributor

Description

Fix repo and branch reference

Changelog

  • Description: Fix repo and branch reference
  • Products impact: none
  • Addresses: -
  • Components: -
  • Breaking: -
  • Impacts a11y: -
  • Guidance: -

Steps to test

Create Pull request similar to #53
Create issue and link it to PR
Change default repo branch to the branch you are changing in PR from (1.) due to https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#issue_comment
Post comment in issue.

(optional) Implementation notes

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@MisRob
Copy link
Copy Markdown
Member

MisRob commented Dec 4, 2024

Thank you, @rparadowski, I will close this because this update is already in main, I pushed it last week so I can test the action as close as possible to production. 251e5ad. I don't know why GitHub PR is showing the diff. In any case, your help with testing process is much appreciated.

@MisRob MisRob closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants