From 7838d260a21e2ae3bcad1c9e26d68d4e8c5dfd57 Mon Sep 17 00:00:00 2001 From: Rafal Paradowski Date: Tue, 3 Dec 2024 12:23:36 +0100 Subject: [PATCH 1/3] Dynamin repo name. --- .github/workflows/notify_team_new_comment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/notify_team_new_comment.yml b/.github/workflows/notify_team_new_comment.yml index a676358..1831ed3 100644 --- a/.github/workflows/notify_team_new_comment.yml +++ b/.github/workflows/notify_team_new_comment.yml @@ -31,5 +31,5 @@ jobs: webhook: ${{ secrets.SLACK_WEBHOOK_URL }} webhook-type: incoming-webhook payload: | - text: "*[Kolibri] New comment on issue: <${{ github.event.issue.html_url }}#issuecomment-${{ github.event.comment.id }}|${{ steps.escape_title.outputs.ISSUE_TITLE }} by ${{ github.event.comment.user.login }}>*" + text: "*[${{ github.event.repository.name }}] New comment on issue: <${{ github.event.issue.html_url }}#issuecomment-${{ github.event.comment.id }}|${{ steps.escape_title.outputs.ISSUE_TITLE }} by ${{ github.event.comment.user.login }}>*" From 0f3f3c2a9c1d306a9e0ec6f82814846518c938f4 Mon Sep 17 00:00:00 2001 From: Rafal Paradowski Date: Tue, 3 Dec 2024 12:31:45 +0100 Subject: [PATCH 2/3] remove author restriction --- .github/workflows/notify_team_new_comment.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/notify_team_new_comment.yml b/.github/workflows/notify_team_new_comment.yml index 1831ed3..2d92402 100644 --- a/.github/workflows/notify_team_new_comment.yml +++ b/.github/workflows/notify_team_new_comment.yml @@ -12,10 +12,13 @@ jobs: if: >- ${{ - !github.event.issue.pull_request && - github.event.comment.author_association != 'MEMBER' && - github.event.comment.author_association != 'OWNER' + !github.event.issue.pull_request }} +# ${{ +# !github.event.issue.pull_request && +# github.event.comment.author_association != 'MEMBER' && +# github.event.comment.author_association != 'OWNER' +# }} runs-on: ubuntu-latest steps: From 23d6e19c2e133260760f15ea2bcfbd7dd15fb125 Mon Sep 17 00:00:00 2001 From: Rafal Paradowski Date: Tue, 3 Dec 2024 12:33:01 +0100 Subject: [PATCH 3/3] Revert "remove author restriction" This reverts commit 0f3f3c2a9c1d306a9e0ec6f82814846518c938f4. --- .github/workflows/notify_team_new_comment.yml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/notify_team_new_comment.yml b/.github/workflows/notify_team_new_comment.yml index 2d92402..1831ed3 100644 --- a/.github/workflows/notify_team_new_comment.yml +++ b/.github/workflows/notify_team_new_comment.yml @@ -12,13 +12,10 @@ jobs: if: >- ${{ - !github.event.issue.pull_request + !github.event.issue.pull_request && + github.event.comment.author_association != 'MEMBER' && + github.event.comment.author_association != 'OWNER' }} -# ${{ -# !github.event.issue.pull_request && -# github.event.comment.author_association != 'MEMBER' && -# github.event.comment.author_association != 'OWNER' -# }} runs-on: ubuntu-latest steps: