Skip to content

Commit e6c2329

Browse files
TomWambsgansCopilot
andcommitted
add TODO comment for a potential opti in compute_eval_eq_base_packed_batched
Co-authored-by: Copilot <copilot@github.com>
1 parent 5d6fe62 commit e6c2329

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

crates/backend/poly/src/eq_mle.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,9 @@ pub fn compute_eval_eq_base_packed_batched<F, EF>(
421421
.enumerate()
422422
.for_each(|(tile_idx, out_tile)| {
423423
for (eq_prefix, middle, eq_suffix) in &per_query {
424+
// Here e could precompute the eq poly, trading some memory for less computation
425+
// (2x faster on M4 max, but 2x slower on machines with smaller caches.
426+
// TODO implement both and choose based on cache size?)
424427
base_eval_eq_packed_with_packed_output::<F, EF, true>(
425428
middle,
426429
out_tile,

0 commit comments

Comments
 (0)