From 0e36daa041c7ccaac9cb0961c4452237eb2a1a7d Mon Sep 17 00:00:00 2001 From: lw41 Date: Tue, 23 Sep 2025 21:52:41 -0500 Subject: [PATCH] Fix test in MagnetUriParserTest.java to not depend on HashSet iteration order Updates based on feedback to convert to HashSet and be compatible with Java 8 --- .../src/test/java/bt/magnet/MagnetUriParserTest.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/bt-tests/src/test/java/bt/magnet/MagnetUriParserTest.java b/bt-tests/src/test/java/bt/magnet/MagnetUriParserTest.java index a3ebe37b4..69a137719 100644 --- a/bt-tests/src/test/java/bt/magnet/MagnetUriParserTest.java +++ b/bt-tests/src/test/java/bt/magnet/MagnetUriParserTest.java @@ -22,7 +22,9 @@ import java.util.Arrays; import java.util.Collection; +import java.util.HashSet; import java.util.Iterator; +import java.util.Set; import static bt.TestUtil.assertExceptionWithMessage; import static org.junit.Assert.assertArrayEquals; @@ -53,10 +55,11 @@ public void testParser_v1_AllParamsPresent() { assertTrue(trackerUrls.contains(trackerUrl2)); Collection peerAddresses = uri.getPeerAddresses(); - assertEquals(2, peerAddresses.size()); - Iterator iter = peerAddresses.iterator(); - assertEquals(new InetPeerAddress("1.1.1.1", 10000), iter.next()); - assertEquals(new InetPeerAddress("2.2.2.2", 10000), iter.next()); + Set expectedPeers = new HashSet<>(Arrays.asList( + new InetPeerAddress("1.1.1.1", 10000), + new InetPeerAddress("2.2.2.2", 10000) + )); + assertEquals(new HashSet<>(expectedPeers), peerAddresses); } @Test