From ccce4a71692116b630db1bb1f24cf405e7daef83 Mon Sep 17 00:00:00 2001 From: Vishal Rana Date: Wed, 23 Sep 2026 13:27:43 -0700 Subject: [PATCH] fix(e2e): count kept volumes by owner label, not by name Volumes no longer carry the application's name, so grepping `docker volume ls` for observer found nothing and "destroy without volumes keeps the data" failed on a destroy that had kept them. Count the volumes labelled onebox.app=observer instead. This failed the v2026.9.14 release's server suite before anything was published. --- e2e/server_probe_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/server_probe_test.go b/e2e/server_probe_test.go index 480e85d9..2f059e09 100644 --- a/e2e/server_probe_test.go +++ b/e2e/server_probe_test.go @@ -227,7 +227,7 @@ func TestServerProbes(t *testing.T) { if err != nil { t.Fatalf("destroy failed: %v\n%s", err, out) } - volumes := strings.TrimSpace(s.run(t, "docker volume ls -q | grep -c observer || true")) + volumes := strings.TrimSpace(s.run(t, "docker volume ls -q --filter label=onebox.app=observer | wc -l")) if volumes == "0" { t.Fatal("destroy without --volumes removed the data volumes") }