Repository navigation
Commit ff342df
authored
fix(ui): align header widgets to one height and baseline (#97)
* fix(ui): align header widgets to one height and baseline
Header tiles took their content's height and the header row centred them,
so a tile with a bar under its value (Memory, Disk) sat higher than the
others and its label and value no longer lined up with the row's.
Every header tile is now 56 px high with its content centred, and the bar
sits on the tile's bottom edge instead of adding height, so labels and
values share one line across the header. Board tiles are unchanged.
* fix(ui): reserve the bar strip in every header tile instead of fixing its height
Address review: a fixed 56 px tile broke the overflow menu's Menu.Item
layout, overflowed the 55 px header row and its focus ring, and clipped
large text. Instead every header tile keeps the same 4 px strip below its
value, holding the bar where a tile has one, so tiles are equal in height
in flow. The header stories now check that labels and values share one
line, and a mixed-tile story covers the case that was misaligned.1 parent 6618a95 commit ff342df
4 files changed
Lines changed: 23 additions & 3 deletions
File tree
- internal/web/app
- assets
- ui/src
- host
- widgets
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
74 | 81 | | |
75 | 82 | | |
76 | 83 | | |
| |||
252 | 259 | | |
253 | 260 | | |
254 | 261 | | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
255 | 273 | | |
256 | 274 | | |
257 | 275 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
108 | 110 | | |
109 | 111 | | |
110 | 112 | | |
| |||
0 commit comments