π Description
main.go lines 85β88:
utilruntime.Must(istiov1beta1.AddToScheme(scheme))
utilruntime.Must(kubeslicev1beta1.AddToScheme(scheme))
utilruntime.Must(istiov1beta1.AddToScheme(scheme)) // duplicate
istiov1beta1.AddToScheme is registered twice. While controller-runtime deduplicates scheme registrations, the duplicate call is dead code that misleads readers and could mask a bug where the intended second registration (e.g., a different API group) was accidentally omitted.
π Reproduction steps
Read main.go lines 83β89.
π Expected behavior
Each scheme is registered exactly once.
π Actual Behavior
istiov1beta1.AddToScheme appears twice; one call is a no-op.
π Relevant log output
Version
No response
π₯οΈ What operating system are you seeing the problem on?
No response
β
Proposed Solution
Remove the second utilruntime.Must(istiov1beta1.AddToScheme(scheme)) call.
π Have you spent some time to check if this issue has been raised before?
Code of Conduct
π Description
main.golines 85β88:istiov1beta1.AddToSchemeis registered twice. Whilecontroller-runtimededuplicates scheme registrations, the duplicate call is dead code that misleads readers and could mask a bug where the intended second registration (e.g., a different API group) was accidentally omitted.π Reproduction steps
Read
main.golines 83β89.π Expected behavior
Each scheme is registered exactly once.
π Actual Behavior
istiov1beta1.AddToSchemeappears twice; one call is a no-op.π Relevant log output
Version
No response
π₯οΈ What operating system are you seeing the problem on?
No response
β Proposed Solution
Remove the second
utilruntime.Must(istiov1beta1.AddToScheme(scheme))call.π Have you spent some time to check if this issue has been raised before?
Code of Conduct