CI action updates, runner updates, CMake 4 fixes#70
Open
ryandesign wants to merge 4 commits into
Open
Conversation
For cmake.yml, remove macos-12 and macos-13 runners because they no longer exist. The macos-14 runner will be deprecated starting next month so skip straight to macos-15. macos-latest, used by cmake-fat.yml, will switch from macOS 15 to 26 by next month. These runners are now arm64 machines instead of x86_64.
Increase minimum required CMake version from 3.1 to 3.5. Fixes error "Compatibility with CMake < 3.5 has been removed from CMake" when using CMake >= 4.
Contributor
Author
|
A few questions as I consider further improvements such as consolidating the two workflows: Previously you had an x86_64 build and a fat build; after this PR, because of changes to the default runners, you will get an arm64 build and a fat build. Would you like a third run to continue having an x86_64 build, either on an Intel runner or cross-compiling on Apple Silicon? Do you want to continue to have the fat binary built by a different macOS than the standard binary? I assume this is just to verify that builds still succeed on an older OS. You are currently uploading artifacts from all builds. Do you need the single-arch artifact or is the universal artifact sufficient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI and CMake improvements continuing from ksherlock/libsane#2: