GitHub and Builds

[jaadams5]

1. Confirm that people who have privileges for kolmafia/kolmafia have the same privileges for kolmafia/multitool. Be prepared for divergence if people wish to opt out or people contribute to multitool but not mafia.
4. Enforce the same review policy for multitool that kolmafia already has.
6. Change Languages on main page so multitool is not 50% Groovy or understand why that is the correct answer.
8. Verify that workflow and triggers are the same for multitool and mafia or that the differences are deliberate.
10. Consider revising the build so that the only artifact built is the jar file and the jar file is only promoted to a release when the build is triggered by updates to main.
12. Find a way to determine the oldest version of Java that can be a target for multitool, build a jar for that version and then verify that multitool runs.
13. Clean up the build by removing things that do not apply such as support for bundling third party jar files.

[heeheehee-kolmafia]

Change Languages on main page so multitool is not 50% Groovy or understand why that is the correct answer.

It's mostly picking up your Gradle configuration files. build.gradle alone is about 300 lines, compared to 262 lines in Multitool.java and 108 lines in ToolData.java.

About 30 of the lines in build.gradle are dependencies that you don't use, 20 are test logic for the tests that don't exist, and 100 are for the binary naming scheme that Mafia depends on for legacy reasons.

That said, you should be able to hide these from the stats view by adding:

*.gradle -linguist-detectable

to .gitattributes.

https://github.com/github-linguist/linguist/blob/main/docs/overrides.md

[heeheehee-kolmafia]

Regarding permissions: cross-reference the multitool settings at https://github.com/kolmafia/multitool/settings/access with the kolmafia repo settings at https://github.com/kolmafia/kolmafia/settings/access.

In particular, you probably want to add the Staff team and grant it either the Maintain or Admin role.

[jaadams5]

I changed the .gitattributes.

Deleting things from the gradle build file is beyond me at the moment but can wait until I either add tests or give up on the idea :-)

I need to get some sense of how to use issues. Right now I seem to want a ToDo list where some things are actually code tasks, some are decisions that should be made (which might trigger tasks) and some are just things I want to know.

[jaadams5]

4. Enforce the same review policy for multitool that kolmafia already has.

See image.

That makes me think I have not done something that I ought to do.

But what?