From e084ebedcf7a4ee981db65b2560afe613f75988e Mon Sep 17 00:00:00 2001 From: Ganesh Kumar Durairaj Date: Fri, 22 Aug 2025 23:17:25 +0100 Subject: [PATCH] [#510]Fix incorrect MAC header size calculation in VLANEncap element. Replace sizeof(vlan) with sizeof(click_ether_vlan) to use proper struct size instead of pointer size. This ensures correct network header offset anno in the packet for VLAN encapsulated packets. --- elements/ethernet/vlanencap.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elements/ethernet/vlanencap.cc b/elements/ethernet/vlanencap.cc index 85a2fc747b..a1020e133c 100644 --- a/elements/ethernet/vlanencap.cc +++ b/elements/ethernet/vlanencap.cc @@ -73,7 +73,7 @@ VLANEncap::simple_action(Packet *p) click_ether_vlan *vlan = reinterpret_cast(q->data()); vlan->ether_vlan_proto = _ethertype; vlan->ether_vlan_tci = tci; - q->set_mac_header(q->data(), sizeof(vlan)); + q->set_mac_header(q->data(), sizeof(click_ether_vlan)); return q; } else return 0;