From c9738785541b90c09d05df841fc5d37a97f2f69a Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Wed, 8 Apr 2026 11:20:48 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=9B=A1=EF=B8=8F=20Sentinel:=20[CRITICAL]?= =?UTF-8?q?=20Fix=20hardcoded=20password=20in=20test=20files?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: kingkillery <200727508+kingkillery@users.noreply.github.com> --- .jules/sentinel.md | 4 ++++ tests/inference_test.py | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 .jules/sentinel.md diff --git a/.jules/sentinel.md b/.jules/sentinel.md new file mode 100644 index 0000000..c983238 --- /dev/null +++ b/.jules/sentinel.md @@ -0,0 +1,4 @@ +## 2025-04-08 - Remove Hardcoded Password in Test Comments +**Vulnerability:** Hardcoded password for an encrypted PDF found in test comments (`tests/inference_test.py`). +**Learning:** Developers often leave credentials in comments for convenience in test files, underestimating the risk of leaking sensitive information or personal passwords. +**Prevention:** Avoid committing sensitive credentials or personal passwords in any code artifacts, including comments and tests. Use environment variables or secure vault integrations instead if testing with protected data is required. \ No newline at end of file diff --git a/tests/inference_test.py b/tests/inference_test.py index 62b9474..debb37b 100644 --- a/tests/inference_test.py +++ b/tests/inference_test.py @@ -44,7 +44,6 @@ def test_mutlinline(tmp_path): def test_encrypted_failure(tmp_path): - # Reminder to future Joe: password for encrypted PDF is "kanbanery" output_path = tmp_path / "output.pdf" with pytest.raises(commonforms.exceptions.EncryptedPdfError):