Skip to content

Commit 75671e2

Browse files
authored
ensure disabled animations when multiple banners are loaded (#209)
* fix(banner.js): use selector to disable animations the animation styles won't apply to banner even if injected to page. * docs(banner.md): fix snippet to use tld with no id * docs(banner.md): add line breaks between examples
1 parent e0b6edd commit 75671e2

2 files changed

Lines changed: 9 additions & 6 deletions

File tree

public/banner.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,8 @@
207207
"}" +
208208
".kao-banner-close:hover{opacity:1;}";
209209

210-
var cssKaoPulse =
211-
".kao-banner { animation:kao-pulse 2s infinite; }" +
210+
var cssKaoPulse =
211+
".kao-banner:not(.no-animation) { animation:kao-pulse 2s infinite; }" +
212212
"@keyframes kao-pulse{" +
213213
"0%{box-shadow:0 0 0 0 rgba(211,47,47,0.7)}" +
214214
"70%{box-shadow:0 0 0 15px rgba(211,47,47,0)}" +
@@ -217,8 +217,8 @@
217217

218218
var style = document.createElement("style");
219219
style.textContent = (size === "mini" ? cssMini : size === "minimal" ? cssMinimal : cssNormal)
220-
+ (params.animation === "off" ? "" : cssKaoPulse)
221-
+ cssCommon;
220+
+ (params.animation === "off" ? "" : cssKaoPulse)
221+
+ cssCommon;
222222
document.head.appendChild(style);
223223

224224
// ── Check if previously dismissed (reappears after dismissDays) ─────
@@ -235,7 +235,7 @@
235235

236236
// ── Create banner DOM ─────────────────────────────────────────────────
237237
var banner = document.createElement("div");
238-
banner.className = "kao-banner";
238+
banner.className = params.animation === "off" ? "kao-banner no-animation" : "kao-banner";
239239

240240
var messageText = messages[locale] || messages.en;
241241

src/content/pages/banner.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ French, mini size, inserted into a specific element:
4040
<div id="my-banner"></div>
4141
<script src="/banner.js?lang=fr&size=mini&id=my-banner"></script>
4242

43+
---
4344

4445
Link to a custom page, no close button:
4546

@@ -50,10 +51,12 @@ Link to a custom page, no close button:
5051
<div id="my-banner-custom"></div>
5152
<script src="/banner.js?link=https://example.com/android&hidebutton=off&size=mini&id=my-banner-custom"></script>
5253

54+
---
55+
5356
Minimal size without animations.
5457

5558
```html
56-
<script src="/banner.js?size=minimal&animation=off&id=my-banner-minimal"></script>
59+
<script src="https://keepandroidopen.org/banner.js?size=minimal&animation=off></script>
5760
```
5861
<div id="my-banner-minimal"></div>
5962
<script src="/banner.js?size=minimal&animation=off&id=my-banner-minimal"></script>

0 commit comments

Comments
 (0)