branches_added initialization location

[SiddharthDey]

I think the branches_added variable initialization should be done before the for loop over detections instead of after as done currently:
openmht/mht.py

for index, detection in enumerate(detections):
    branches_added = 0  # Number of branches added to the track tree at this frame
    detection_id = str(index)

This causes the loop to only count branches added for the last detection. Instead, we should do the initiliazation before the loop:

branches_added = 0  # Number of branches added to the track tree at this frame
for index, detection in enumerate(detections):
    detection_id = str(index)

[SiddharthDey]

I also had a confusion about the application of the branch pruning threshold. Currently in the code, the B_th threshold allows the total number of branches in all the branch trees to be B_th, whereas I think in the paper, it is mentioned that this should be separately for each branch tree.

So if the number of branches/tracks in a branch tree exceeds B_th, we retain the top B_th branches but the total number of branch trees can exceed B_th. But in the code, the total number of branch trees is restricted to B_th. I think both are valid ways of restricting the branch trees from growing exponentially depending on how much flexibility we want