From ed6979eb264d86025bda2c9eea0b5f634f8c26e3 Mon Sep 17 00:00:00 2001 From: Fabian Foerg Date: Tue, 22 Oct 2019 17:51:15 -0400 Subject: [PATCH 1/2] Do not log full request when bad response code is received The request object potentially contains sensitive information. For requests resulting in a bad response code, log only the response code and the request URL. --- src/main/java/com/force/api/http/Http.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/force/api/http/Http.java b/src/main/java/com/force/api/http/Http.java index 7fceb2e..4f2f7c4 100644 --- a/src/main/java/com/force/api/http/Http.java +++ b/src/main/java/com/force/api/http/Http.java @@ -108,7 +108,7 @@ public static final HttpResponse send(HttpRequest req) { // it indicates that SF objects were not changed since the time specified in the "If-Modified-Since" header return new HttpResponse().setResponseCode(code); } else { - logger.info("Bad response code: {} on request: {}", code, req); + logger.info("Bad response code: {} on request: {}", code, req.getUrl()); return new HttpResponse().setString( new String(readResponse(conn.getErrorStream()), "UTF-8")).setResponseCode(code); } From b7258920784f3bbce10fe4167f60b25f5ef11ab8 Mon Sep 17 00:00:00 2001 From: Fabian Foerg Date: Wed, 23 Oct 2019 08:47:52 -0400 Subject: [PATCH 2/2] add request method --- src/main/java/com/force/api/http/Http.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/force/api/http/Http.java b/src/main/java/com/force/api/http/Http.java index 4f2f7c4..01c2229 100644 --- a/src/main/java/com/force/api/http/Http.java +++ b/src/main/java/com/force/api/http/Http.java @@ -108,7 +108,7 @@ public static final HttpResponse send(HttpRequest req) { // it indicates that SF objects were not changed since the time specified in the "If-Modified-Since" header return new HttpResponse().setResponseCode(code); } else { - logger.info("Bad response code: {} on request: {}", code, req.getUrl()); + logger.info("Bad response code: {} on request: {} {}", code, req.getMethod(), req.getUrl()); return new HttpResponse().setString( new String(readResponse(conn.getErrorStream()), "UTF-8")).setResponseCode(code); }