Reactions are great! 👍 But seed jobs are broken.

[efip-ns]

Jenkins and plugins versions report

Environment

Jenkins: 2.492.2
OS: Linux - 5.10.0-33-amd64
Java: 17.0.14 - Eclipse Adoptium (OpenJDK 64-Bit Server VM)
---
analysis-model-api:13.2.0
ansicolor:1.0.6
ant:513.vde9e7b_a_0da_0f
antisamy-markup-formatter:173.v680e3a_b_69ff3
apache-httpcomponents-client-4-api:4.5.14-269.vfa_2321039a_83
apache-httpcomponents-client-5-api:5.4-136.v5a_21779c63f8
artifactory:4.0.8
asm-api:9.7.1-97.v4cc844130d97
authentication-tokens:1.131.v7199556c3004
aws-credentials:245.v8a_1b_7c11a_94d
aws-java-sdk-ec2:1.12.780-480.v4a_0819121a_9e
aws-java-sdk-minimal:1.12.780-480.v4a_0819121a_9e
aws-java-sdk2-core:2.30.28-26.v649b_8df2f988
aws-java-sdk2-ec2:2.30.28-26.v649b_8df2f988
blueocean:1.27.17
blueocean-autofavorite:1.2.5
blueocean-bitbucket-pipeline:1.27.17
blueocean-commons:1.27.17
blueocean-config:1.27.17
blueocean-core-js:1.27.17
blueocean-dashboard:1.27.17
blueocean-display-url:2.4.4
blueocean-events:1.27.17
blueocean-git-pipeline:1.27.17
blueocean-github-pipeline:1.27.17
blueocean-i18n:1.27.17
blueocean-jwt:1.27.17
blueocean-personalization:1.27.17
blueocean-pipeline-api-impl:1.27.17
blueocean-pipeline-editor:1.27.17
blueocean-pipeline-scm-api:1.27.17
blueocean-rest:1.27.17
blueocean-rest-impl:1.27.17
blueocean-web:1.27.17
bootstrap5-api:5.3.3-2
bouncycastle-api:2.30.1.80-256.vf98926042a_9b_
branch-api:2.1214.v3f652804588d
buildtriggerbadge:251.vdf6ef853f3f5
byte-buddy-api:1.17.4-143.v073fb_7026b_3c
caffeine-api:3.2.0-161.v691ef352cee1
checks-api:367.v18b_7f530e54a_
cloudbees-bitbucket-branch-source:935.1.3
cloudbees-disk-usage-simple:239.v6a_f1a_c1c8046
cloudbees-folder:6.991.v1d5f531726d0
command-launcher:118.v72741845c17a_
commons-compress-api:1.27.1-3
commons-lang3-api:3.17.0-84.vb_b_938040b_078
commons-text-api:1.13.0-153.v91dcd89e2a_22
config-file-provider:982.vb_a_e458a_37021
configuration-as-code:1947.v7d33fe23569c
copyartifact:765.v0357cc6e6eb_3
coverage:2.2.0
credentials:1413.va_51c53703df1
credentials-binding:687.v619cb_15e923f
custom-folder-icon:2.19
customizable-header:175.v07c36327359a_
data-tables-api:2.2.2-1
database:274.vea_2e859b_2661
database-postgresql:146.vd1a_f70b_56e0e
display-url-api:2.209.v582ed814ff2f
docker-commons:451.vd12c371eeeb_3
docker-workflow:611.v16e84da_6d3ff
dtkit-api:3.0.3
durable-task:587.v84b_877235b_45
ec2:1881.vc14132ea_f042
echarts-api:5.6.0-2
eddsa-api:0.3.0.1-19.vc432d923e5ee
email-ext:1876.v28d8d38315b_d
emoji-symbols-api:16.0-26.v9818ff7423f0
extensible-choice-parameter:237.v51568f37b_78e
external-monitor-job:223.vb_fddcf42c9b_3
favorite:2.225.v68765b_b_a_1fa_3
flatpickr-api:4.6.13-18.vcf5f6a_5b_8468
font-awesome-api:6.7.2-1
forensics-api:3.1.0
generic-webhook-trigger:2.3.1
git:5.7.0
git-client:6.1.2
github:1.42.0
github-api:1.321-478.vc9ce627ce001
github-branch-source:1810.v913311241fa_9
github-checks:602.v264a_83610da_6
github-pr-comment-build:134.ve7ff0b_719821
github-scm-trait-commit-skip:0.4.0
github-scm-trait-notification-context:45.v8ef831829589
gradle:2.14.1
gson-api:2.12.1-113.v347686d6729f
handy-uri-templates-2-api:2.1.8-36.v85e4cb_234a_13
hashicorp-vault-plugin:371.v884a_4dd60fb_6
htmlpublisher:425
http_request:1.20
instance-identity:203.v15e81a_1b_7a_38
ionicons-api:82.v0597178874e1
jackson2-api:2.18.3-402.v74c4eb_f122b_2
jakarta-activation-api:2.1.3-2
jakarta-mail-api:2.1.3-2
javadoc:310.v032f3f16b_0f8
javax-activation-api:1.2.0-8
javax-mail-api:1.6.2-11
jaxb:2.3.9-133.vb_ec76a_73f706
jdk-tool:83.v417146707a_3d
jenkins-design-language:1.27.17
jersey2-api:2.45-154.v4ded3dc34f81
jfrog:1.5.8
jira:3.14
jira-steps:2.0.180.vccfe35b_5910d
jjwt-api:0.11.5-120.v0268cf544b_89
job-dsl:1.91
jobConfigHistory:1305.vf20a_356586b_8
joda-time-api:2.13.1-115.va_6b_5f8efb_1d8
jquery:1.12.4-3
jquery3-api:3.7.1-3
jsch:0.2.16-95.v3eecb_55fa_b_78
json-api:20250107-125.v28b_a_ffa_eb_f01
json-path-api:2.9.0-148.v22a_7ffe323ce
jsoup:1.19.1-36.v63b_c859911d0
junit:1319.v000471ca_e5e2
kubernetes:4324.vfec199a_33512
kubernetes-client-api:6.10.0-251.v556f5f100500
kubernetes-credentials:192.v4d5b_1c429d17
kubernetes-credentials-provider:1.276.v99a_de03cb_076
ldap:780.vcb_33c9a_e4332
lockable-resources:1349.v8b_ccb_c5487f7
mailer:489.vd4b_25144138f
material-theme:0.5.2-rc100.6121925fe229
matrix-auth:3.2.5
matrix-project:847.v88a_f90ff9f20
maven-plugin:3.25
metrics:4.2.21-464.vc9fa_a_0d6265d
metrics-datadog:1.0
mina-sshd-api-common:2.14.0-143.v2b_362fc39576
mina-sshd-api-core:2.14.0-143.v2b_362fc39576
mina-sshd-api-scp:2.14.0-143.v2b_362fc39576
multibranch-action-triggers:1.8.10
multiselect-parameter:1.8
node-iterator-api:72.vc90e81737df1
okhttp-api:4.11.0-183.va_87fc7a_89810
opentelemetry-api:1.44.1.40.v93f5f8ca_42c3
oss-symbols-api:308.v0c48656b_15c1
pam-auth:1.12
parameter-separator:276.v7b_5328f5c7a_d
parameterized-scheduler:285.ve611986d4c48
pipeline-build-step:557.v95d96f77b_2b_8
pipeline-github:2.8-162.382498405fdc
pipeline-graph-analysis:231.v56354571a_da_0
pipeline-graph-view:423.v765c49ca_da_3f
pipeline-groovy-lib:752.vdddedf804e72
pipeline-input-step:517.vf8e782ee645c
pipeline-milestone-step:127.vb_52887ca_3b_6d
pipeline-model-api:2.2247.va_423189a_7dff
pipeline-model-definition:2.2247.va_423189a_7dff
pipeline-model-extensions:2.2247.va_423189a_7dff
pipeline-rest-api:2.37
pipeline-stage-step:322.vecffa_99f371c
pipeline-stage-tags-metadata:2.2247.va_423189a_7dff
pipeline-stage-view:2.37
pipeline-utility-steps:2.19.0
plain-credentials:183.va_de8f1dd5a_2b_
plugin-usage-plugin:4.10
plugin-util-api:6.0.0
postgresql-api:42.7.5-56.vc0921b_3cc11e
prism-api:1.30.0-1
prometheus:819.v50953a_c560dd
pubsub-light:1.19
rebuild:338.va_0a_b_50e29397
role-strategy:756.v978cb_392eb_d3
run-condition:243.v3c3f94e46a_8b_
scm-api:704.v3ce5c542825a_
script-security:1373.vb_b_4a_a_c26fa_00
sidebar-link:2.4.2
slack:761.v2a_8770f0d169
snakeyaml-api:2.3-123.v13484c65210a_
sonar:2.18
sse-gateway:1.28
ssh-agent:384.ve275343791a_6
ssh-credentials:355.v9b_e5b_cde5003
ssh-slaves:3.1031.v72c6b_883b_869
ssh-steps:2.0.79.v1d1b_5f76dda_8
sshd:3.353.v2b_d33c46e970
strict-crumb-issuer:2.1.1
structs:343.vdcf37b_a_c81d5
test-results-analyzer:0.4.1
theme-manager:278.v2e3c063e42cc
thinBackup:2.1.2
throttle-concurrents:2.16
timestamper:1.28
token-macro:444.v52de7e9c573d
trilead-api:2.192.vc50a_d147e369
uno-choice:2.8.6
validating-string-parameter:255.v31e2e6d0d273
variant:70.va_d9f17f859e0
warnings-ng:12.4.1
workflow-aggregator:608.v67378e9d3db_1
workflow-api:1366.vf1fb_e1a_f6b_22
workflow-basic-steps:1079.vce64b_a_929c5a_
workflow-cps:4046.v90b_1b_9edec67
workflow-durable-task-step:1405.v1fcd4a_d00096
workflow-job:1506.v77f78a_b_8cc5e
workflow-multibranch:803.v08103b_87c280
workflow-scm-step:437.v05a_f66b_e5ef8
workflow-step-api:700.v6e45cb_a_5a_a_21
workflow-support:963.va_600813d04a_a_
xunit:3.1.5

What Operating System are you using (both controller, and any agents involved in the problem)?

Linux

Reproduction steps

1. Have a Job DSL plugin and define your jobs via DSL.
2. Configure a trigger in your DSL.
3. Upgrade the plugin to the latest version.

Expected Results

I would expect my seed job to continue working after a plugin update.

Actual Results

I have my seed job fail after a plugin upgrade, since "Add reaction" is a mandatory parameter.

Anything else?

My Job DSL example:

      strategy {
        allBranchesSame {
          props {
            suppressAutomaticTriggering {
              strategy("NONE")
              triggeredBranchesRegex('^PR-\\d+$')
            }
            triggerPRCommentBranchProperty {
              commentBody('ci-pr-head')
              // this is the fix I need to do in all my seed jobs --->  addReaction(false)
            }
            triggerPRLabelBranchProperty {
                label('ci-pr-head')
            }
          }

Error when running the seed job:

Processing DSL script cicd/jenkins/jobs/main.groovy
ERROR: (unknown source) the following options are required and must be specified: addReaction

It would probably be best to assume no reaction is needed when the parameter is omitted in Job DSL.

Are you interested in contributing a fix?

No response