From a3240efa4699d8482108300867d136ddf70ccdda Mon Sep 17 00:00:00 2001 From: Instanacd PAT for GitHub Public Date: Tue, 2 Jun 2026 17:04:10 +0000 Subject: [PATCH 1/6] build: bumped redis from 5.12.1 to 6.0.0 --- currencies.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/currencies.json b/currencies.json index 4f74f9bec9..0bf6b837d8 100644 --- a/currencies.json +++ b/currencies.json @@ -972,7 +972,7 @@ "core": false, "versions": [ { - "v": "5.12.1" + "v": "6.0.0" }, { "v": "5.8.3" From 0066308fa11f3a6bb6e0de1d308b53c83e6f3e27 Mon Sep 17 00:00:00 2001 From: Arya Date: Wed, 3 Jun 2026 09:29:07 +0530 Subject: [PATCH 2/6] chore: added node constraint --- currencies.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/currencies.json b/currencies.json index 0bf6b837d8..09de008774 100644 --- a/currencies.json +++ b/currencies.json @@ -972,7 +972,8 @@ "core": false, "versions": [ { - "v": "6.0.0" + "v": "6.0.0", + "node": ">=20" }, { "v": "5.8.3" @@ -1334,4 +1335,4 @@ } ] } -] \ No newline at end of file +] From 606c8c6ea589bf5f6ba35fa46345b3323897d4ab Mon Sep 17 00:00:00 2001 From: Arya Date: Wed, 3 Jun 2026 09:30:18 +0530 Subject: [PATCH 3/6] chore: updated --- currencies.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/currencies.json b/currencies.json index 09de008774..2d170b5075 100644 --- a/currencies.json +++ b/currencies.json @@ -976,7 +976,7 @@ "node": ">=20" }, { - "v": "5.8.3" + "v": "5.12.1" }, { "v": "4.7.1" From b67085cea7a36f12893de8539d411803a3663cc4 Mon Sep 17 00:00:00 2001 From: Arya Date: Wed, 3 Jun 2026 10:16:03 +0530 Subject: [PATCH 4/6] chore: instrumentation fix --- .../core/src/tracing/instrumentation/databases/redis.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/core/src/tracing/instrumentation/databases/redis.js b/packages/core/src/tracing/instrumentation/databases/redis.js index be81fdea7f..4ddd3a2950 100644 --- a/packages/core/src/tracing/instrumentation/databases/redis.js +++ b/packages/core/src/tracing/instrumentation/databases/redis.js @@ -48,9 +48,12 @@ function captureCommands(file) { } function instrument(redis) { - // NOTE: v4 no longer exposes the RedisClient. We need to wait till `createClient` get's called - // to get the instance of the redis client - if (!redis.RedisClient) { + // NOTE: Redis versions differ in export shape: + // v4/v5: are strictly factory-based (createClient/createCluster) and do not expose RedisClient. + // v6: expose RedisClient again, but this does NOT imply legacy/class-based behavior. + // RedisClient presence cannot be used to distinguish v3 from newer versions. + const isLegacyClassAPI = redis.RedisClient?.prototype && typeof redis.createClient !== 'function'; + if (!isLegacyClassAPI) { // redis automatically loads @redis/client, which can trigger a second instrumentation call. // We track the instrumentation status via `isRedisClientInstrumented and skip second time. if (isRedisClientInstrumented) { From e5e8494c5f3b813bbc2647d9de72ba276c2ce730 Mon Sep 17 00:00:00 2001 From: Arya Date: Wed, 3 Jun 2026 10:17:27 +0530 Subject: [PATCH 5/6] chore: instrumentation fix --- packages/core/src/tracing/instrumentation/databases/redis.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/core/src/tracing/instrumentation/databases/redis.js b/packages/core/src/tracing/instrumentation/databases/redis.js index 4ddd3a2950..5630ceb355 100644 --- a/packages/core/src/tracing/instrumentation/databases/redis.js +++ b/packages/core/src/tracing/instrumentation/databases/redis.js @@ -53,6 +53,7 @@ function instrument(redis) { // v6: expose RedisClient again, but this does NOT imply legacy/class-based behavior. // RedisClient presence cannot be used to distinguish v3 from newer versions. const isLegacyClassAPI = redis.RedisClient?.prototype && typeof redis.createClient !== 'function'; + if (!isLegacyClassAPI) { // redis automatically loads @redis/client, which can trigger a second instrumentation call. // We track the instrumentation status via `isRedisClientInstrumented and skip second time. From e9e3ea3a4c75dbb8b2ae9ce4ecd6c457c7081f05 Mon Sep 17 00:00:00 2001 From: Arya Date: Wed, 3 Jun 2026 10:18:31 +0530 Subject: [PATCH 6/6] chore: instrumentation fix --- packages/core/src/tracing/instrumentation/databases/redis.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/tracing/instrumentation/databases/redis.js b/packages/core/src/tracing/instrumentation/databases/redis.js index 5630ceb355..5652138e06 100644 --- a/packages/core/src/tracing/instrumentation/databases/redis.js +++ b/packages/core/src/tracing/instrumentation/databases/redis.js @@ -51,7 +51,7 @@ function instrument(redis) { // NOTE: Redis versions differ in export shape: // v4/v5: are strictly factory-based (createClient/createCluster) and do not expose RedisClient. // v6: expose RedisClient again, but this does NOT imply legacy/class-based behavior. - // RedisClient presence cannot be used to distinguish v3 from newer versions. + // RedisClient presence alone cannot be used to distinguish v3 from newer versions. const isLegacyClassAPI = redis.RedisClient?.prototype && typeof redis.createClient !== 'function'; if (!isLegacyClassAPI) {