Skip to content

[Bug]: node process not cleaned up on server close #692

Description

@klonuo

Preflight

  • I searched existing issues and this isn't a duplicate
  • I'm on the latest version (or I've noted my version below)

What happened?

I started the server with ok start --open. When I press ctrl+c to stop the server it closes fine:

...
{"event":"bridge-tolerance-applied","site":"persistence","class":"commonmark-escape"}
{"event":"bridge-tolerance-applied","site":"persistence","class":"table-align-row-spacing"}
{"event":"bridge-tolerance-applied","site":"persistence","class":"list-indent-canonical"}
{"event":"bridge-tolerance-applied","site":"persistence","class":"paragraph-continuation-indent"}
{"event":"bridge-tolerance-applied","site":"persistence","class":"table-align-row-spacing"}
{"event":"bridge-tolerance-applied","site":"persistence","class":"paragraph-continuation-indent"}
{"event":"bridge-tolerance-applied","site":"persistence","class":"trailing-newline"}

Stopping OpenKnowledge…
  Saving pending changes and releasing the server lock — this can take a few seconds.
  Press Ctrl+C again to force quit.

~\Documents\Obsidian Vault
>

but one node process remains stale:

C:\Users\klo\scoop\apps\nodejs\current\node.exe C:\Users\klo\scoop\apps\nodejs\current\bin\node_modules\@inkeep\open-knowledge\dist\cli.mjs ui

Now if I try to run server again it will use different port as the process also holds the port.

Steps to reproduce

Explained

Platform

Web app

How did you install OpenKnowledge?

Web app

Version

0.34.0

Logs, errors, or screenshots

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions