From 427b3edb796b58287948e18004429c7ff47923e5 Mon Sep 17 00:00:00 2001 From: Jasper Frumau Date: Fri, 21 Aug 2026 10:53:56 +0700 Subject: [PATCH] fix(create-pr): keep assistant names out of generated descriptions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The generation prompt already said not to mention the tooling, but that reads as 'do not credit yourself' rather than 'do not describe a change that happens to concern it'. When a diff touched the contributor guide's commit-message convention, the model described it accurately — and put an assistant's name in prose in a public PR description. The prompt now states that the rule holds even when the diff is about this tooling, and gives the neutral phrasing to use instead. The convention in the contributor guide is widened to match: no mention anywhere in a description, not just no footer. Naming a changed file by its real path stays fine, since that is the file's actual name. --- CHANGELOG.md | 19 +++++++++++++++++++ CLAUDE.md | 2 +- scripts/git/create-pr.sh | 5 +++++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 96bfb39..8d3f530 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,25 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [5.7.1] - 2026-08-21 + +### Fixed + +- **`create-pr.sh` could name an AI assistant in a generated PR description.** + The generation prompt already forbade mentioning the tooling, but that reads + as "do not credit yourself" rather than "do not describe a change that + happens to concern it". So when a diff touched the contributor guide's own + commit-message convention, the model described it faithfully — and named the + assistant in prose, in a public description. The prompt now says explicitly + that the rule survives such a change and that the neutral phrasing + ("the contributor guide", "commit-message conventions") is what belongs + there. Referring to a changed file by its real path stays fine. + +- **The PR-description convention only ruled out footers.** It said "no AI + attribution footers or tool references", which the prose above technically + slipped past. It now rules out any mention anywhere in the description, + matching the commit-message rule. + ## [5.7.0] - 2026-08-21 ### Fixed diff --git a/CLAUDE.md b/CLAUDE.md index ea26c00..b582420 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -303,4 +303,4 @@ Before running backup operations on production: - **Atomic commits**: Each commit should represent a single logical change. Do not bundle unrelated changes in one commit. This makes history easier to review and revert when needed. - **No AI attribution in commits**: do not add `Co-Authored-By` lines for Claude or Mistral, a `Claude-Session` trailer, or any other tool reference. Commit messages carry the change and its reasoning, nothing else. This matches the PR-description rule below. -- **PR descriptions**: Pull request descriptions should be professional and focused on the changes. Do not include AI attribution footers or tool references. +- **PR descriptions**: Pull request descriptions should be professional and focused on the changes. No mention of Claude, Mistral, Codex, or any AI assistant anywhere in the description — not as a footer, and not in prose. This holds even when the change itself concerns AI tooling: describe it neutrally ("the contributor guide", "commit-message conventions"). Referring to a changed file by its real path is fine. diff --git a/scripts/git/create-pr.sh b/scripts/git/create-pr.sh index 01ad57d..1764122 100755 --- a/scripts/git/create-pr.sh +++ b/scripts/git/create-pr.sh @@ -610,6 +610,11 @@ REQUIREMENTS: - Keep each bullet point to 1-2 sentences maximum - Describe the change, never the tooling: do NOT mention Claude, Codex, AI or any assistant, and do NOT append a generated-by / co-authored-by footer of any kind +- This holds even when the diff itself concerns AI tooling. If a commit changes + CLAUDE.md, AGENTS.md, or an assistant convention, describe it in neutral terms + ('the contributor guide', 'commit-message conventions', 'attribution trailers') + rather than naming the assistant. Referring to a changed file by its real path + is fine; naming an assistant in prose is not CHANGED FILES (excluding lock files): $CHANGED_FILES_NO_LOCKS