Skip to content

Code review #1

@igrangel

Description

@igrangel
  1. The name of the project _Modeler_ does not say anything
    
  2. The name of the package _test_ does not say anything
    
  3. The readme should contain how to install and execute the code of the project
    
  4. Don’t spend time in the GUI, after all the mappings are working we will move into a web app
    
  5. Class modeler, it does not contains the goal of the class nor the date where this was created. This should be done in top of it. Eclipse generate this by default if you write /*\* and then press enter
    
  6. Methods of class Modeler not well commented. Please check the best practices how to do this
    
  7. If you press Ctrl + I in Eclipse you will realize that the code is not well formatted. Please do it always
    
  8. In the Sparql class, the name of the class is totally wrong. This should be refactored
    
  9. The query should NEVER be included in the code, but used as an external file
    
  10. Name the variables in a proper way. Abc is totally a wrong name.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions