From e583947e3389f1f8577dc89dcf87b967d666ab79 Mon Sep 17 00:00:00 2001 From: "Jonathan D.A. Jewell" <6759885+hyperpolymath@users.noreply.github.com> Date: Wed, 26 Aug 2026 16:52:45 +0100 Subject: [PATCH] fix(scripts): repoint checks at the .adoc files that exist The .md -> .adoc documentation migration moved these files but never updated the scripts that READ them, so every check naming a .md has been operating on a file that no longer exists. Repointed: MAINTAINERS.md->MAINTAINERS.adoc Three failure modes were in play across the estate, all fixed by the same change: * hard fail - 'check "X.md exists" "[ -f X.md ]"' can never pass * wrong score - '[ -f X.md ] && ((doc_score++))' silently scores lower * SILENT SKIP - 'if [ -f X.md ]; then ...greps... fi' skips the whole block, so the checks inside never run and the gate reports success by not checking at all Human-readable labels are repointed too, so failure messages name the file that is actually inspected. Where a script did 'git add ... X.md', that is fixed as well - it would have failed at release time. Only tokens whose .adoc twin exists in this repository were rewritten; anything without a twin was left untouched for separate triage. Found by an estate-wide sweep of 454 repos: 56 such checks across 18 repos. Same defect class as hyperpolymath/Axiom.jl#82. --- scripts/rsr-verify.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/rsr-verify.sh b/scripts/rsr-verify.sh index f8af5aa..0d9581b 100755 --- a/scripts/rsr-verify.sh +++ b/scripts/rsr-verify.sh @@ -70,7 +70,7 @@ echo " ⚠️ Gold: 0/20 points (Full offline)" echo "" echo "4. Documentation" docs_missing=0 -for file in README.md SECURITY.md CODE_OF_CONDUCT.md MAINTAINERS.md CONTRIBUTING.md CHANGELOG.md LICENSE; do +for file in README.md SECURITY.md CODE_OF_CONDUCT.md MAINTAINERS.adoc CONTRIBUTING.md CHANGELOG.md LICENSE; do [ ! -f "$file" ] && docs_missing=1 done if [ $docs_missing -eq 0 ]; then @@ -166,7 +166,7 @@ total_bronze=$((total_bronze + 100)) # 9. TPCF echo "" echo "9. TPCF" -if [ -f "MAINTAINERS.md" ] && grep -q "Perimeter" MAINTAINERS.md; then +if [ -f "MAINTAINERS.adoc" ] && grep -q "Perimeter" MAINTAINERS.adoc; then echo " ✅ Bronze: 50/50 points" earned_bronze=$((earned_bronze + 50)) else