⚡ Bolt: [performance improvement] Cache Iconify icon lookups#41
⚡ Bolt: [performance improvement] Cache Iconify icon lookups#41sshahriazz wants to merge 1 commit into
Conversation
…iteration across icon sets on every render Co-authored-by: sshahriazz <34005640+sshahriazz@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Implemented a global
Mapcache for icon lookups inclient/src/components/base/IconifyIcon.tsx.🎯 Why: The
IconifyIconcomponent is used heavily (~192 times). For prefix-less icons (or icons missing a prefix),iconDataiteratively searched multiple large icon sets on every single render, causing an O(n) rendering bottleneck.📊 Impact: Reduces O(n) lookups across icon sets to O(1) constant-time cache hits on subsequent renders, significantly reducing rendering overhead globally.
🔬 Measurement: This can be verified using the React Profiler. Prior to the optimization, rendering large pages with many prefix-less icons would show high time spent inside
iconData(). Post-optimization, rendering time in the icon lookup function becomes nearly zero due to cache hits.PR created automatically by Jules for task 14149135810047470037 started by @sshahriazz