Skip to content

Outdated Package and Build Issue #57

@aradhyabob

Description

@aradhyabob

Hi,

Firstly, thanks for your work on this project!

Today I used patch-package to patch react-native-floating-bubble@1.0.12 for the project I'm working on.

As this package is outdated, I was facing problems in the build

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-floating-bubble/android/build.gradle b/node_modules/react-native-floating-bubble/android/build.gradle
index 2173e8d..93db0ae 100644
--- a/node_modules/react-native-floating-bubble/android/build.gradle
+++ b/node_modules/react-native-floating-bubble/android/build.gradle
@@ -1,46 +1,18 @@
-
-buildscript {
-    repositories {
-        jcenter()
-        maven { url 'https://jitpack.io' }
-    }
-
-    dependencies {
-        classpath 'com.android.tools.build:gradle:1.3.1'
-    }
-}
-
 apply plugin: 'com.android.library'
 
 android {
-    compileSdkVersion 23
-    buildToolsVersion "23.0.1"
+    namespace "com.subefir.rnfloatingbubble" // <--- ADDED THIS
+    compileSdkVersion 25
+    buildToolsVersion "25.0.0"
 
     defaultConfig {
         minSdkVersion 16
-        targetSdkVersion 22
+        targetSdkVersion 25
         versionCode 1
         versionName "1.0"
     }
-    lintOptions {
-        abortOnError false
-    }
-}
-
-repositories {
-    mavenCentral()
-    maven { url 'https://jitpack.io' }
-}
-
-allprojects {
-    repositories {
-        maven { url 'https://jitpack.io' }
-    }
 }
 
 dependencies {
-    implementation 'com.facebook.react:react-native:+'
-    //compile 'com.txusballesteros:bubbles:1.2.1',
-    implementation 'com.github.txusballesteros:bubbles-for-android:develop-SNAPSHOT'
+    implementation 'com.facebook.react:react-native:+' // <--- CHANGED "compile" TO "implementation"
 }
\ No newline at end of file
-  
\ No newline at end of file

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions