Merge pull request #30 from hectorespert/capture_login_exception

Improve login exception

Author: hectorespert

oligo/asyncio/asynciber.py

@@ -31,7 +31,8 @@ def __init__(self) -> None:
         self.__session = None
 
     async def close(self):
-        await self.__session.close()
+        if self.__session:
+            await self.__session.close()
 
     async def __request(
         self, path: str, data: Optional[Union[list, dict]] = None
@@ -73,8 +74,9 @@ async def login(self, user: str, password: str) -> bool:
         ]
         data = await self.__request(LOGIN_URL, data=payload)
         if data["success"] != "true":
+            await self.__session.close()
             self.__session = None
-            raise LoginException()
+            raise LoginException(user)
         return True
 
     async def measurement(self) -> dict:

oligo/exception.py

@@ -8,8 +8,8 @@ def __init__(self, status_code):
 
 
 class LoginException(IberException):
-    def __init__(self):
-        super().__init__('Login error, bad login')
+    def __init__(self, username):
+        super().__init__(f'Unable to log in with user {username}')
 
 
 class SessionException(IberException):

oligo/requests/iber.py

@@ -49,7 +49,7 @@ def login(self, user, password, session=Session()):
         json_response = response.json()
         if json_response["success"] != "true":
             self.__session = None
-            raise LoginException()
+            raise LoginException(user)
 
     def __check_session(self):
         if not self.__session:

tests/test_exception.py

@@ -13,8 +13,8 @@ def test_message(self):
 class TestLoginException(unittest.TestCase):
 
     def test_message(self):
-        login_exception = LoginException()
-        self.assertEqual('Login error, bad login', login_exception.args[0])
+        login_exception = LoginException("pepe")
+        self.assertEqual('Unable to log in with user pepe', login_exception.args[0])
 
 
 class TestSessionException(unittest.TestCase):