From 6f00cf606dd43d0d56ff1653d73a3015dd535886 Mon Sep 17 00:00:00 2001 From: Devin Jeanpierre Date: Wed, 4 Mar 2026 12:31:43 -0800 Subject: [PATCH] Polish up type_alias.h (Cover a missing case (return values), remove no-op clang pragma. PiperOrigin-RevId: 878615049 --- rs_bindings_from_cc/test/type_alias/test.rs | 6 ++++++ rs_bindings_from_cc/test/type_alias/type_alias.h | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/rs_bindings_from_cc/test/type_alias/test.rs b/rs_bindings_from_cc/test/type_alias/test.rs index b3e7362e0..0e057a536 100644 --- a/rs_bindings_from_cc/test/type_alias/test.rs +++ b/rs_bindings_from_cc/test/type_alias/test.rs @@ -12,6 +12,12 @@ fn test_return_value() { assert_eq!(return_underlying(i), 42); } +#[gtest] +fn test_return_alias() { + use type_alias::return_alias; + assert_eq!(return_alias(42), 42); +} + /// Vector aliases are not supported (yet???). #[gtest] fn test_vector_alias() { diff --git a/rs_bindings_from_cc/test/type_alias/type_alias.h b/rs_bindings_from_cc/test/type_alias/type_alias.h index 5bb42d33a..59170dfb3 100644 --- a/rs_bindings_from_cc/test/type_alias/type_alias.h +++ b/rs_bindings_from_cc/test/type_alias/type_alias.h @@ -5,8 +5,6 @@ #ifndef CRUBIT_RS_BINDINGS_FROM_CC_TEST_TYPE_ALIAS_TYPE_ALIAS_H_ #define CRUBIT_RS_BINDINGS_FROM_CC_TEST_TYPE_ALIAS_TYPE_ALIAS_H_ -#pragma clang lifetime_elision - namespace ns { using Int = int; } @@ -16,6 +14,8 @@ using ns::Int; // compiles. inline int return_underlying(Int i) { return i; } +inline Int return_alias(int i) { return i; } + // This one, however, should NOT receive bindings. using MyVector __attribute__((vector_size(16))) = int; inline void VectorFunction(MyVector v) {}