From fa630a70280fe2d14210a5ff152bf470ccc16fca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EC=9D=B4=EC=A7=80=ED=9B=88?= <155136709+dlwlgnsrhy@users.noreply.github.com> Date: Tue, 17 Nov 2026 17:00:58 +0900 Subject: [PATCH] fix(extensions): omit config hint when no scaffolding fails Show the generic configuration hint only alongside an actual scaffolding failure. Cover undeclared, empty, and missing-template configurations through the CLI. Assisted-by: OpenAI Codex (model: GPT-6, autonomous) --- src/specify_cli/extensions/command_add.py | 5 ---- .../extensions/test_command_add.py | 30 +++++++++++++++++++ 2 files changed, 30 insertions(+), 5 deletions(-) diff --git a/src/specify_cli/extensions/command_add.py b/src/specify_cli/extensions/command_add.py index 96b7125ea4..a9d981687b 100644 --- a/src/specify_cli/extensions/command_add.py +++ b/src/specify_cli/extensions/command_add.py @@ -348,11 +348,6 @@ def extension_add( "Verify the extension manifest and template files." ) - # Only warn when configuration is actually unresolved. Scaffolding that - # deployed or preserved every template has already answered this, and an - # extension without provides.config has nothing to configure; the blanket - # warning contradicted the output directly above it. - if failed or not (deployed or skipped): console.print("\n[yellow]⚠[/yellow] Configuration may be required") console.print(f" Check: {config_home}/") diff --git a/tests/specify_cli/extensions/test_command_add.py b/tests/specify_cli/extensions/test_command_add.py index fdf1a7fac5..2fc9a2b522 100644 --- a/tests/specify_cli/extensions/test_command_add.py +++ b/tests/specify_cli/extensions/test_command_add.py @@ -40,6 +40,35 @@ class TestExtensionAddCLI: """CLI tests for ``specify extension add``.""" + @pytest.mark.parametrize( + ("config", "warns"), + [ + pytest.param({}, False, id="undeclared"), + pytest.param({"config": []}, False, id="empty"), + pytest.param( + {"config": [{"name": "test-ext-config.yml", "template": "missing.yml"}]}, + True, + id="missing-template", + ), + ], + ) + def test_add_dev_warns_only_when_config_scaffolding_fails( + self, extension_dir, project_dir, valid_manifest_data, config, warns + ): + valid_manifest_data["provides"].update(config) + (extension_dir / "extension.yml").write_text( + yaml.safe_dump(valid_manifest_data), encoding="utf-8" + ) + + with patch.object(Path, "cwd", return_value=project_dir): + result = CliRunner().invoke(app, ["extension", "add", "--dev", str(extension_dir)]) + + assert result.exit_code == 0, result.output + output = strip_ansi(result.output) + assert "Extension installed successfully" in output + assert ("Configuration may be required" in output) == warns, output + assert ("Config templates not scaffolded" in output) == warns, output + @pytest.mark.parametrize("command", [ pytest.param(["speckit.test-ext.hello"], id="list"), pytest.param({"name": "speckit.test-ext.hello"}, id="mapping"), @@ -722,6 +751,7 @@ def fake_install_from_zip( patch("specify_cli.authentication.http.open_url", return_value=FakeResponse(_MINIMAL_ZIP_BYTES)), \ patch("specify_cli.extensions._commands._safe_open_download_zip", side_effect=_open_test_download_zip), \ patch.object(ExtensionManager, "install_from_zip", fake_install_from_zip), \ + patch.object(ExtensionManager, "scaffold_config", return_value=([], [], ["test-ext-config.yml"])), \ patch.object(ExtensionRegistry, "get", return_value={}): result = runner.invoke( app,